Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flutter_migrate] Remove one set of parens that wrap a single String literal #7216

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

srawlins
Copy link
Contributor

@srawlins srawlins commented Jul 25, 2024

In order to address dart-lang/linter#4354, we are reporting a few more cases in unnecessary_parenthesis. ('text') * 2 is one such case. This change is being made in https://dart-review.googlesource.com/c/sdk/ /376540. (These are the only newly-reported unnecessary parentheses for this change.)

This is the same change as flutter/flutter#152031

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

…e cases in `unnecessary_parenthesis`. `('text') * 2` is one such case. This change is being made in https://dart-review.googlesource.com/c/sdk/ /376540. (These are the only newly-reported unnecessary parentheses for this change.)
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srawlins srawlins merged commit 94f8b2f into main Jul 25, 2024
76 checks passed
@srawlins srawlins deleted the unn-parens-2 branch July 25, 2024 18:03
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 26, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 26, 2024
flutter/packages@19daf6f...3d358d9

2024-07-26 [email protected] [many] Ignore NewerVersionAvailable in android lint  (flutter/packages#7218)
2024-07-25 [email protected] [tool] Adds `--wasm` flag to the `drive-examples` command (flutter/packages#7162)
2024-07-25 [email protected] [tool] Add a package-level pre-publish hook (flutter/packages#7156)
2024-07-25 [email protected] [flutter_migrate] Remove one set of parens that wrap a single String literal (flutter/packages#7216)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/ doc/main/autoroll/README.md
TytaniumDev pushed a commit to TytaniumDev/flutter that referenced this pull request Aug 7, 2024
…r#152372)

flutter/packages@19daf6f...3d358d9

2024-07-26 [email protected] [many] Ignore NewerVersionAvailable in android lint  (flutter/packages#7218)
2024-07-25 [email protected] [tool] Adds `--wasm` flag to the `drive-examples` command (flutter/packages#7162)
2024-07-25 [email protected] [tool] Add a package-level pre-publish hook (flutter/packages#7156)
2024-07-25 [email protected] [flutter_migrate] Remove one set of parens that wrap a single String literal (flutter/packages#7216)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/ doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants