Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flutter_plugin_tools] Allow disabling Swift Package Manager when building examples #7145

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

loic-sharma
Copy link
Member

@loic-sharma loic-sharma commented Jul 16, 2024

You can use the Flutter plugin tool to build the plugins' examples apps. Currently, the tool can enable the Swift Package Manager feature.

This change allows the tool to disable the Swift Package Manager feature. This will be useful for when SPM is enabled by default on a release channel.

Preparation for: flutter/flutter#151567

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@loic-sharma loic-sharma marked this pull request as ready for review July 17, 2024 22:43
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loic-sharma loic-sharma added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 18, 2024
@auto-submit auto-submit bot merged commit c7f0526 into flutter:main Jul 18, 2024
76 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 18, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 18, 2024
flutter/packages@d03b1b4...c7f0526

2024-07-18 737941 [email protected] [flutter_plugin_tools] Allow disabling Swift Package Manager when building examples (flutter/packages#7145)
2024-07-17 [email protected] Modernize all `index.html` files to support WASM (flutter/packages#7114)
2024-07-17 [email protected] [in_app_purchase_storekit] Migrate InAppPurchasePluginTests.m to. Swift (flutter/packages#7105)
2024-07-17 [email protected] [ci] Drive tests with html renderer if CHANNEL is stable. (flutter/packages#7146)
2024-07-17 49699333 dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump com.android.tools.build:gradle from 7.3.1 to 8.5.1 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#7120)
2024-07-17 49699333 dependabot[bot]@users.noreply.github.com [image_picker]: Bump com.android.tools.build:gradle from 7.2.1 to 8.5.1 in /packages/image_picker/image_picker_android/android (flutter/packages#7121)
2024-07-17 49699333 dependabot[bot]@users.noreply.github.com [url_launcher]: Bump com.android.tools.build:gradle from 7.3.0 to 8.5.1 in /packages/url_launcher/url_launcher_android/android (flutter/packages#7128)
2024-07-17 30872003 [email protected] [camera_avfoundation] do not append sample buffer when readyForMoreMediaData is NO to avoid crash (flutter/packages#6901)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/ doc/main/autoroll/README.md
TytaniumDev pushed a commit to TytaniumDev/flutter that referenced this pull request Aug 7, 2024
flutter/packages@d03b1b4...c7f0526

2024-07-18 737941 [email protected] [flutter_plugin_tools] Allow disabling Swift Package Manager when building examples (flutter/packages#7145)
2024-07-17 [email protected] Modernize all `index.html` files to support WASM (flutter/packages#7114)
2024-07-17 [email protected] [in_app_purchase_storekit] Migrate InAppPurchasePluginTests.m to. Swift (flutter/packages#7105)
2024-07-17 [email protected] [ci] Drive tests with html renderer if CHANNEL is stable. (flutter/packages#7146)
2024-07-17 49699333 dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump com.android.tools.build:gradle from 7.3.1 to 8.5.1 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#7120)
2024-07-17 49699333 dependabot[bot]@users.noreply.github.com [image_picker]: Bump com.android.tools.build:gradle from 7.2.1 to 8.5.1 in /packages/image_picker/image_picker_android/android (flutter/packages#7121)
2024-07-17 49699333 dependabot[bot]@users.noreply.github.com [url_launcher]: Bump com.android.tools.build:gradle from 7.3.0 to 8.5.1 in /packages/url_launcher/url_launcher_android/android (flutter/packages#7128)
2024-07-17 30872003 [email protected] [camera_avfoundation] do not append sample buffer when readyForMoreMediaData is NO to avoid crash (flutter/packages#6901)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/ doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
flutter/packages@d03b1b4...c7f0526

2024-07-18 737941 [email protected] [flutter_plugin_tools] Allow disabling Swift Package Manager when building examples (flutter/packages#7145)
2024-07-17 [email protected] Modernize all `index.html` files to support WASM (flutter/packages#7114)
2024-07-17 [email protected] [in_app_purchase_storekit] Migrate InAppPurchasePluginTests.m to. Swift (flutter/packages#7105)
2024-07-17 [email protected] [ci] Drive tests with html renderer if CHANNEL is stable. (flutter/packages#7146)
2024-07-17 49699333 dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump com.android.tools.build:gradle from 7.3.1 to 8.5.1 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#7120)
2024-07-17 49699333 dependabot[bot]@users.noreply.github.com [image_picker]: Bump com.android.tools.build:gradle from 7.2.1 to 8.5.1 in /packages/image_picker/image_picker_android/android (flutter/packages#7121)
2024-07-17 49699333 dependabot[bot]@users.noreply.github.com [url_launcher]: Bump com.android.tools.build:gradle from 7.3.0 to 8.5.1 in /packages/url_launcher/url_launcher_android/android (flutter/packages#7128)
2024-07-17 30872003 [email protected] [camera_avfoundation] do not append sample buffer when readyForMoreMediaData is NO to avoid crash (flutter/packages#6901)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/ doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants