Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[many] Remove dependency on kotlin-bom #7088

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gmackall
Copy link
Member

@gmackall gmackall commented Jul 9, 2024

This dependency seems to no longer be necessary. I expected this would be because the the androidx upgrade that landed recently fixed the problem (see theory), but it seems that the packages even build on stable successfully. Perhaps there have been updates to the underlying androidx libraries themselves that fix the conflict, and we updated the versions in plugins far enough? I'm unsure.

In a sense, fixes flutter/flutter#125062

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gmackall
Copy link
Member Author

gmackall commented Jul 9, 2024

Expecting tests to fail on stable, will need to wait until stable contains flutter/engine#53592, aka contains flutter/flutter#150952. This should be 3.24. The tests seem to pass on stable as well?

Tested that the example app for each modified package builds on master still.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@gmackall gmackall removed the waiting for stable update Can't be landed until functionality reaches the stable channel label Jul 9, 2024
@stuartmorgan
Copy link
Contributor

test-exempt: configuration change

Copy link
Contributor

@camsim99 camsim99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo!

@stuartmorgan
Copy link
Contributor

stuartmorgan commented Jul 9, 2024

#3960 suggests that we weren't catching this problem in CI. Given that, are we confident that we would catch it now (i.e., that the green result here is actually telling us what we need to know)? Can we try manually re-creating (on stable) some things like what's described in that PR description?

@gmackall
Copy link
Member Author

gmackall commented Jul 9, 2024

#3960 suggests that we weren't catching this problem in CI. Given that, are we confident that we would catch it now (i.e., that the green result here is actually telling us what we need to know)? Can we try manually re-creating (on stable) some things like what's described in that PR description?

This is a good question, I'll try with a workflow similar to what I described in that PR for all the affected packages on stable.

If I had to guess why we didn't catch this in ci for camerax (and it really is a guess) it would be that the all_packages app maybe already had the workaround included in one of the packages, which fixed it for the app, and perhaps the camerax example was also depending on a plugin that had the fix (but only the example, not the plugin itself). Anyways I'll double check all the plugins.

@gmackall
Copy link
Member Author

gmackall commented Jul 9, 2024

Hmm okay, yeah the workflow described in the PR:

  1. flutter create sample
  2. Add a dependency on the locally changed plugin to the pubspec
  3. flutter build apk

Fails on stable, while succeeding on master. So this will indeed have to wait for the next stable. I'll also try to figure out why the all_packages/example apps aren't catching this in the meantime - I don't know why they wouldn't, but it's clear they aren't.

@gmackall gmackall marked this pull request as draft July 9, 2024 23:36
@gmackall gmackall added the waiting for stable update Can't be landed until functionality reaches the stable channel label Jul 9, 2024
Copy link
Contributor

@reidbaker reidbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve % next stable being set at the minimum

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants