[google_maps_web] Skip a smaller subset of web tests #7087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bparrishMines
changed the title
| @@ -15,6 16,12 @@ import 'src/tiles_inspector.dart' as tiles_inspector; | |||
| void main() { | |||
| IntegrationTestWidgetsFlutterBinding.ensureInitialized(); | |||
|
|
|||
| // TODO(bparrishMines): These tests are failing on web due to an error being | |||
| // thrown after completion. See https://github.com/flutter/flutter/issues/145149 | |||
| if (isWeb) { | |||
There was a problem hiding this comment.
I know it'll be a lot more code, but I think it would be better to do something like:
// TODO(bparrishMines): Tests are failing on web due to an error being
// thrown after completion. See https://github.com/flutter/flutter/issues/145149
const bool _skipOnWeb = isWeb;
[ Add skip: _skipOnWeb to every test ]That way they it'll be obvious both when looking at the test, and from the test run output, that web is skipping tests, vs them being silently skipped in an unusual place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stops skipping all of the web
google_maps_fluttertests and only skips the one of the tests on for the platform implementation and all the tests for the app-facing package. I'll continue working on a permanent fix for flutter/flutter#145149.Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.