-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[google_maps_flutter] Fix Circle update regression #7056
Merged
auto-submit
merged 4 commits into
flutter:main
from
stuartmorgan:maps-pigeon-android-bugfix
Jul 3, 2024
Merged
[google_maps_flutter] Fix Circle update regression #7056
auto-submit
merged 4 commits into
flutter:main
from
stuartmorgan:maps-pigeon-android-bugfix
Jul 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
reidbaker
approved these changes
Jul 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 4, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 4, 2024
flutter/packages@d2705fb...754de19 2024-07-03 49699333 dependabot[bot]@users.noreply.github.com [interactive_media_ads]: Bump com.google.ads.interactivemedia.v3:interactivemedia from 3.33.0 to 3.34.0 in /packages/interactive_media_ads/android (flutter/packages#7037) 2024-07-03 [email protected] [google_maps_flutter] Fix Circle update regression (flutter/packages#7056) 2024-07-03 [email protected] Roll Flutter from 99bb2ff to af913a7 (30 revisions) (flutter/packages#7047) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/ doc/main/autoroll/README.md
TahaTesser
pushed a commit
to TahaTesser/flutter
that referenced
this pull request
Jul 8, 2024
…r#151315) flutter/packages@d2705fb...754de19 2024-07-03 49699333 dependabot[bot]@users.noreply.github.com [interactive_media_ads]: Bump com.google.ads.interactivemedia.v3:interactivemedia from 3.33.0 to 3.34.0 in /packages/interactive_media_ads/android (flutter/packages#7037) 2024-07-03 [email protected] [google_maps_flutter] Fix Circle update regression (flutter/packages#7056) 2024-07-03 [email protected] Roll Flutter from 99bb2ff to af913a7 (30 revisions) (flutter/packages#7047) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/ doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
Jul 8, 2024
…r#151315) flutter/packages@d2705fb...754de19 2024-07-03 49699333 dependabot[bot]@users.noreply.github.com [interactive_media_ads]: Bump com.google.ads.interactivemedia.v3:interactivemedia from 3.33.0 to 3.34.0 in /packages/interactive_media_ads/android (flutter/packages#7037) 2024-07-03 [email protected] [google_maps_flutter] Fix Circle update regression (flutter/packages#7056) 2024-07-03 [email protected] Roll Flutter from 99bb2ff to af913a7 (30 revisions) (flutter/packages#7047) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/ doc/main/autoroll/README.md
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
autosubmit
Merge PR when tree becomes green via auto submit App
p: google_maps_flutter
platform-android
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced in the last PR that did shallow Pigeon conversions of the maps calls, where the new Pigeon wrapper object was being passed directly to one of the not-yet-converted methods that was expecting the JSON data (i.e.,
circle.getJson()
rather thancircle
). Also adds a native unit test exercising that codepath, which reproduced the cast error.As a secondary step to improve safety is this hybrid state, for all of the map object controllers, I converted most of the methods taking
Object
s to takingMap<String, ?>
instead, which is in practice what the JSON serialization of all of those objects is, and further pushed that through the Pigeon layer so that instead of casting throughout the Java code, the cast happens once on the Dart side. While the Dart cast is technically unsafe:Part of flutter/flutter#117907
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///
).