[camera_avfoundation] do not append sample buffer when readyForMoreMediaData is NO to avoid crash #6901
Conversation
misos1
force-pushed
the
append_only_when_ready
branch
2 times, most recently
from
47de9c4
to
e4246d8
Compare
misos1
force-pushed
the
append_only_when_ready
branch
from
e4246d8
to
0a2acd5
Compare
I cannot reproduce with steps from that issue (and without patch from this PR, that is also why I created new issue which is practically duplicate of #69874 but with steps with which I was able to reproduce that more reliably, I mentioned #69874 in that issue) but I suppose it is the same thing, there is just a single call to |
|
I think we can close that issue too, and ask people to update the version. |
|
Actually after looking closely that issue was already closed at the time I posted flutter/flutter#132073 and was reopened just last month, so that is why I needed to create new one instead of just pasting my code sample into that old one, and mentioned only my issue in this PR. So feel free to close that issue again, or should I mention it in this PR to be closed automatically after merge? |
|
That issue was closed in error (there were no fix before). Please link it as a fix to that issue. We can re-open if encounter it again. |
|
From triage: this was missing a second review request. |
# Conflicts: # packages/camera/camera_avfoundation/CHANGELOG.md # packages/camera/camera_avfoundation/pubspec.yaml
bparrishMines
added
the
autosubmit
…yForMoreMediaData is NO to avoid crash (flutter/packages#6901)
…yForMoreMediaData is NO to avoid crash (flutter/packages#6901)
flutter/packages@d03b1b4...c7f0526 2024-07-18 737941 [email protected] [flutter_plugin_tools] Allow disabling Swift Package Manager when building examples (flutter/packages#7145) 2024-07-17 [email protected] Modernize all `index.html` files to support WASM (flutter/packages#7114) 2024-07-17 [email protected] [in_app_purchase_storekit] Migrate InAppPurchasePluginTests.m to. Swift (flutter/packages#7105) 2024-07-17 [email protected] [ci] Drive tests with html renderer if CHANNEL is stable. (flutter/packages#7146) 2024-07-17 49699333 dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump com.android.tools.build:gradle from 7.3.1 to 8.5.1 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#7120) 2024-07-17 49699333 dependabot[bot]@users.noreply.github.com [image_picker]: Bump com.android.tools.build:gradle from 7.2.1 to 8.5.1 in /packages/image_picker/image_picker_android/android (flutter/packages#7121) 2024-07-17 49699333 dependabot[bot]@users.noreply.github.com [url_launcher]: Bump com.android.tools.build:gradle from 7.3.0 to 8.5.1 in /packages/url_launcher/url_launcher_android/android (flutter/packages#7128) 2024-07-17 30872003 [email protected] [camera_avfoundation] do not append sample buffer when readyForMoreMediaData is NO to avoid crash (flutter/packages#6901) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/ doc/main/autoroll/README.md
Sample buffer is not appended when
readyForMoreMediaDatais NO to avoid crash.Fix flutter/flutter#132073
Fix flutter/flutter#69874
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.