-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci][web] Run tests in canvaskit mode. #6879
Conversation
(Linux_android android_platform_tests_shard_6 master is a known flake, I've restarted it) |
dit@dit:/work/flutter/packages/packages/palette_generator$ flutter test --color --platform=chrome --web-renderer=canvaskit -v
...
[ 1 ms] Launching Chromium (url = http://localhost:40285/static/index.html?managerUrl=ws://localhost:40285/0&debug=false, headless = true,
skipCheck = false, debugPort = null)
[ 1 ms] Will use Chromium executable at google-chrome
[ 87 ms] Using Google Chrome 126.0.6478.55
[ 210 ms] [CHROME]:
[ ] [CHROME]: DevTools listening on ws://127.0.0.1:34627/devtools/browser/2bef8322-20d8-4960-8577-5f04f53770d2
[ 187 ms] Running test suite test/palette_generator_test.dart.
00:04 15: PaletteTarget == does not crash on invalid comparisons [ 3491 ms] Shutting down Chromium.
00:04 15: All tests passed!
...
CI is using:
|
Running with Chrome For Testing 114... dit@dit:/work/flutter/packages/packages/palette_generator$ CHROME_EXECUTABLE=/work/flutter/packages/packages/palette_generator/chrome-linux64/chrome flutter test --platform chrome --web-renderer canvaskit -v
...
[ 1 ms] Launching Chromium (url = http://localhost:45565/static/index.html?managerUrl=ws://localhost:45565/0&debug=false, headless = true,
skipCheck = false, debugPort = null)
[ 1 ms] Will use Chromium executable at /work/flutter/packages/packages/palette_generator/chrome-linux64/chrome
[ 58 ms] Using Google Chrome for Testing 114.0.5696.0
[ 122 ms] [CHROME]:
[ 1 ms] [CHROME]: DevTools listening on ws://127.0.0.1:39723/devtools/browser/80547466-8479-4fe4-b64d-2bf927a1aed7
[ 204 ms] Running test suite test/palette_generator_test.dart.
00:03 15: PaletteTarget == does not crash on invalid comparisons [ 3480 ms] Shutting down Chromium.
00:03 15: All tests passed! Running with an older version of Chromium also passes: dit@dit:/work/flutter/packages/packages/palette_generator$ CHROME_EXECUTABLE=/work/flutter/packages/packages/palette_generator/chromium-linux64/chrome flutter test --platform chrome --web-renderer canvaskit -v
...
[ 1 ms] Launching Chromium (url = http://localhost:44353/static/index.html?managerUrl=ws://localhost:44353/0&debug=false, headless = true,
skipCheck = false, debugPort = null)
[ 1 ms] Will use Chromium executable at /work/flutter/packages/packages/palette_generator/chromium-linux64/chrome
[ 51 ms] Using Chromium 113.0.5672.127
[ 124 ms] [CHROME]:
[ 1 ms] [CHROME]: DevTools listening on ws://127.0.0.1:43267/devtools/browser/9c8eafc4-90d4-44fd-925f-2bf667e20cf2
[ 220 ms] Running test suite test/palette_generator_test.dart.
00:04 15: PaletteTarget == does not crash on invalid comparisons [ 4123 ms] Shutting down Chromium.
00:04 15: All tests passed! |
I, too, haven't been able to reproduce the failure locally. |
Rebased (and force-pushed) to get some fresh results |
Working to land this one this week. |
The repo checks are flagging that there's a missing CHANGELOG entry in
|
Created issue to track re-enabling tests for palette_generator on the web: |
PTAL @stuartmorgan! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with small suggestions.
packages/pointer_interceptor/pointer_interceptor_web/example/README.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flutter/packages@ea35fc6...3379e51 2024-07-12 [email protected] [pigeon] Fix C enum naming (flutter/packages#7094) 2024-07-12 [email protected] [ci] Split build_all_packages by JDK version. (flutter/packages#7106) 2024-07-12 41930132 [email protected] [ios]Fix compile error when conforming UIApplication to Launcher due to MainActor annotation (flutter/packages#7100) 2024-07-11 47866232 [email protected] [go_router] Makes GoRouterState lookup more robust. (flutter/packages#6920) 2024-07-11 [email protected] [ci][web] Run tests in canvaskit mode. (flutter/packages#6879) 2024-07-10 49699333 dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.core:core from 1.10.1 to 1.13.1 in /packages/image_picker/image_picker_android/android (flutter/packages#6648) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/ doc/main/autoroll/README.md
Configures the flutter/packages CI to run web tests using the
canvaskit
renderer, which is the new default for web apps.It also does some minor changes:
package:palette_generator
(cleanup issue created below)palette_generator
example run on the web. This was used to manually verify that the package still works as expected with canvaskit.pointer_interceptor
example apps, so they match what's happening in there.Issues
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Co-authored-by: David Iglesias [email protected]