[web_view]Expose the allowsLinkPreview property in WKWebView for iOS #5029
Conversation
Based off of flutter/plugins#5110 Also exposed it through the webview_controller
camfrandsen
requested review from
cyanglaz and
bparrishMines
as code owners
| /// Whether to display a preview of the destination for the link | ||
| /// | ||
| /// This is not supported by all platforms, so it defaults to a noop | ||
| Future<void> setAllowsLinkPreview(bool allow) async {} |
There was a problem hiding this comment.
I thought it was better to default this to a noop so it wouldn't break other platforms if it was called. Having said that, I will change it to whatever you would like
|
@cyanglaz @bparrishMines I saw that you reviewed flutter/plugins#5110 the first time. Sorry to make you re-review it... but I would love if you could review this. I did my best to port it over from that pr. Thank you for your help with this! |
hellohuanlin
changed the title
|
@camfrandsen No worries, I'm glad it was of some use. I had a guilt in the back of my mind to come back to it at some point and get it merged. So I can sleep easily now. 😅 |
|
@camfrandsen Please see https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins for how to structure this PR so that it will pass tests. Please let us know if you have any issues setting that up! |
# Conflicts: # packages/webview_flutter/webview_flutter/CHANGELOG.md # packages/webview_flutter/webview_flutter/lib/src/webview_controller.dart # packages/webview_flutter/webview_flutter/pubspec.yaml # packages/webview_flutter/webview_flutter_wkwebview/CHANGELOG.md # packages/webview_flutter/webview_flutter_wkwebview/ios/Classes/FWFGeneratedWebKitApis.h # packages/webview_flutter/webview_flutter_wkwebview/pigeons/web_kit.dart # packages/webview_flutter/webview_flutter_wkwebview/pubspec.yaml # packages/webview_flutter/webview_flutter_wkwebview/test/src/web_kit/web_kit_test.dart
That's step 3 of the process, which should only be done after the previous steps (which include approvals of the combined PR) are complete. |
|
@stuartmorgan Ah, sorry about that. I looked at the failures of the checks, and it said that it needed to be broken up... I will re-open this one and close the other two. |
There was a problem hiding this comment.
The webview_flutter_wkwebview portion of this is blocked by flutter/flutter#134777.
...es/webview_flutter/webview_flutter_platform_interface/lib/src/legacy/types/web_settings.dart
Outdated
Show resolved
Hide resolved
# Conflicts: # packages/webview_flutter/webview_flutter/CHANGELOG.md # packages/webview_flutter/webview_flutter_wkwebview/CHANGELOG.md # packages/webview_flutter/webview_flutter_wkwebview/ios/Classes/FWFGeneratedWebKitApis.h # packages/webview_flutter/webview_flutter_wkwebview/ios/Classes/FWFWebViewHostApi.m # packages/webview_flutter/webview_flutter_wkwebview/pubspec.yaml
…e merge conflicts
…thod not found: 'FallThroughError'. throw FallThroughError())�dart run pigeon --input pigeons/web_kit.dart
|
Update from triage: still waiting on the wrapper generator, which is currently under very active development. |
|
Sounds like this is blocked by other work. I am converting this to draft. feel free to request my review when it's ready. |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Update from triage: the conversion to the new wrapper automation that this is blocked on is likely to be done sometime around August. |
|
Update from triage: still likely on track for August. |
Based off of flutter/plugins#5110 So most of the credit goes to @b099l3
Also exposed it through the webview_controller
This PR fixes this issue:
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style].///).