Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docimports for flutter_driver #151267

Merged
merged 1 commit into from
Jul 11, 2024
Merged

docimports for flutter_driver #151267

merged 1 commit into from
Jul 11, 2024

Conversation

goderbauer
Copy link
Member

Part of #150800

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Jul 3, 2024
@goderbauer goderbauer requested a review from srawlins July 3, 2024 21:28
gspencergoog
gspencergoog approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 3, 2024
@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented Jul 3, 2024

auto label is removed for flutter/flutter/151267, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 3, 2024
srawlins
srawlins approved these changes Jul 4, 2024
View reviewed changes
packages/flutter_driver/lib/src/driver/frame_request_pending_latency_summarizer.dart
@@ -8,15 8,15 @@ import 'timeline.dart';
/// Event name for frame request pending timeline events.
const String kFrameRequestPendingEvent = 'Frame Request Pending';

/// Summarizes [TimelineEvents]s corresponding to [kFrameRequestPendingEvent] events.
/// Summarizes [TimelineEvent]s corresponding to [kFrameRequestPendingEvent] events.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love all these finds

@goderbauer
Copy link
Member Author

google testing is failing on:

Target of URI doesn't exist. #uri_does_not_exist

/// @docImport 'package:flutter/foundation.dart';

So, submitting this has to wait on getting that warning ignored in google3.

@gspencergoog
Copy link
Contributor

google testing is failing on:

Target of URI doesn't exist. #uri_does_not_exist

/// @docImport 'package:flutter/foundation.dart';

So, submitting this has to wait on getting that warning ignored in google3.

I think we already rewrite regular imports there when we roll. Perhaps it should also rewrite @docImports?

@goderbauer goderbauer force-pushed the docImports14 branch 2 times, most recently from d372bbf to 9a08645 Compare July 10, 2024 18:06
@goderbauer
Copy link
Member Author

@srawlins This is strange. Google testing was in the clear for #151175. But on this change it still complains about non-existing URIs:

Target of URI doesn't exist: 'package:flutter_test/flutter_test.dart'. #uri_does_not_exist_in_doc_import

/// @docImport 'package:flutter_test/flutter_test.dart';
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

It's not clear to me how the docimports added by this change are any different to the ones added in #151175.

@srawlins
Copy link
Contributor

This will require cl/651406900.

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 11, 2024
@goderbauer goderbauer merged commit b13f50a into flutter:master Jul 11, 2024
71 checks passed
@goderbauer goderbauer deleted the docImports14 branch July 11, 2024 18:30
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 11, 2024
@engine-flutter-autoroll
b13f50a91 docimports for flutter_driver (flutter/flutter#151267)
fdc2194
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 11, 2024
@engine-flutter-autoroll
b13f50a91 docimports for flutter_driver (flutter/flutter#151267)
cba529c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 12, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 12, 2024
@engine-flutter-autoroll
b13f50a91 docimports for flutter_driver (flutter/flutter#151267)
cd90b80
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 12, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 12, 2024
@engine-flutter-autoroll
b13f50a91 docimports for flutter_driver (flutter/flutter#151267)
2b9ed42
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 12, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 12, 2024
@engine-flutter-autoroll
b13f50a91 docimports for flutter_driver (flutter/flutter#151267)
4048912
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 12, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 12, 2024
@engine-flutter-autoroll
b13f50a91 docimports for flutter_driver (flutter/flutter#151267)
8b2fcef
ditman added a commit to ditman/flutter-packages that referenced this pull request Jul 12, 2024
@ditman
Manual roll Flutter from 5103d7574361 to 58068d8ea4ec (42 revisions)
25ed6cb 
Roll Flutter from 5103d7574361 to 58068d8ea4ec (42 revisions)

flutter/flutter@5103d75...58068d8

2024-07-12 [email protected] Reland: Move all Linux Moto G4 tests to mokey in staging (flutter/flutter#151654)
2024-07-12 [email protected] Update obsolete comment in InputDecorator test (flutter/flutter#151651)
2024-07-12 [email protected] Fix `TabBar` tab indicator stretch effect (flutter/flutter#150868)
2024-07-12 [email protected] Remove workaround for a bug in dart2wasm (flutter/flutter#151603)
2024-07-12 [email protected] [native_assets] Stop running link hooks in JIT mode (flutter/flutter#151534)
2024-07-12 [email protected] Roll `Switch.adaptive` changes into `CupertinoSwitch` (flutter/flutter#149465)
2024-07-11 34871572 [email protected] Unmark java11 tests as bringup:true (flutter/flutter#151612)
2024-07-11 737941 [email protected] Add link to design document archive (flutter/flutter#151489)
2024-07-11 98614782 auto-submit[bot]@users.noreply.github.com Reverts "Move all Linux Moto G4 tests to mokey in staging (#151608)" (flutter/flutter#151620)
2024-07-11 [email protected] Move all Linux Moto G4 tests to mokey in staging (flutter/flutter#151608)
2024-07-11 [email protected] docimports for API samples (flutter/flutter#151606)
2024-07-11 [email protected] docimports for flutter_goldens, flutter_localizations, flutter_web_plugins, fuchsia_remote_debug_protocol, integration_test (flutter/flutter#151271)
2024-07-11 [email protected] Re-enable debug canvaskit e2e tests. (flutter/flutter#151565)
2024-07-11 57765714 [email protected] Fix: Submenu anchor misaligned with child panel in web (Resolved #151081) (flutter/flutter#151294)
2024-07-11 45459898 [email protected] Replaced {@tool snippet} with {@tool dartpad} in CupertinoTabController (flutter/flutter#151272)
2024-07-11 [email protected] feat: Support overriding native endorsed plugins (flutter/flutter#137040)
2024-07-11 [email protected] expose keyboardType in DropdownMenu #150894 (flutter/flutter#150896)
2024-07-11 [email protected] docimports for flutter_driver (flutter/flutter#151267)
2024-07-11 82763757 [email protected] Add `TimeOfDay` comparison methods (flutter/flutter#151233)
2024-07-11 [email protected] Roll Flutter Engine from 6534fbf3c2c1 to 36dccf7bb25c (2 revisions) (flutter/flutter#151577)
2024-07-11 [email protected] Roll Flutter Engine from 1c23c8f64076 to 6534fbf3c2c1 (3 revisions) (flutter/flutter#151572)
2024-07-11 [email protected] Use correct locale for `CupertinoDatePicker` weekday (flutter/flutter#151494)
2024-07-10 [email protected] doc imports for enum values (flutter/flutter#151548)
2024-07-10 34871572 [email protected] Reland "Upgrade template Gradle, App AGP, Module AGP, and Kotlin versions, and tests"... but no longer upgrade module AGP version (flutter/flutter#151433)
2024-07-10 [email protected] Roll Packages from 14341d1 to ea35fc6 (16 revisions) (flutter/flutter#151556)
2024-07-10 [email protected] [CupertinoActionSheet] Fix padding and font size of buttons (flutter/flutter#151199)
2024-07-10 [email protected] Roll Flutter Engine from db2b45bea2c0 to 1c23c8f64076 (2 revisions) (flutter/flutter#151550)
2024-07-10 [email protected] Add docImports for flutter_test references (flutter/flutter#151175)
2024-07-10 [email protected] Mention not @-mentioning people in commit messages in tree hygiene (flutter/flutter#151487)
2024-07-10 [email protected] Roll Flutter Engine from 371db85f33d7 to db2b45bea2c0 (8 revisions) (flutter/flutter#151522)
2024-07-10 [email protected] fix heading level absorption, diagnostics; add tests and an a11y use-case (flutter/flutter#151421)
2024-07-10 [email protected] Roll Flutter Engine from 9d943eb2b37a to 371db85f33d7 (3 revisions) (flutter/flutter#151505)
2024-07-10 [email protected] Roll Flutter Engine from d3269d5855a7 to 9d943eb2b37a (5 revisions) (flutter/flutter#151495)
2024-07-09 [email protected] Update doc of `SemanticsProperties.identifier` (flutter/flutter#149915)
2024-07-09 [email protected] Clean up leaky test. (flutter/flutter#151131)
2024-07-09 137456488 [email protected] Roll pub packages (flutter/flutter#151492)
2024-07-09 32538273 [email protected] testAdd tests for stepper.controls_builder.0.dart (flutter/flutter#150669)
2024-07-09 [email protected] Add Semantics Property `linkUrl` (flutter/flutter#150639)
2024-07-09 [email protected] Roll Flutter Engine from 4a2ac0e51a8f to d3269d5855a7 (1 revision) (flutter/flutter#151488)
2024-07-09 34871572 [email protected] Link engine docs on AS setup in flutter/flutter docs on engine contributor setup (flutter/flutter#151481)
2024-07-09 [email protected] Roll Flutter Engine from 69075e7e87d4 to 4a2ac0e51a8f (21 revisions) (flutter/flutter#151482)
2024-07-09 [email protected] Fix Material 3 `Dialog` default background color (flutter/flutter#151400)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
...
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 12, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 12, 2024
@engine-flutter-autoroll
b13f50a91 docimports for flutter_driver (flutter/flutter#151267)
96a3242
@Piinks Piinks mentioned this pull request Jul 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srawlins srawlins srawlins approved these changes

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees
No one assigned
Labels
a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goderbauer @gspencergoog @srawlins