Manual engine roll to 6884e83 #150733

gmackall · 2024-06-24T22:35:01Z

Manual engine roll to flutter/engine#53532, because the roll requires lockfile generation.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

gmackall · 2024-06-25T00:45:09Z

Google testing seems stuck as queued, despite saying "No test needed" in FRoB ui. I'm going to override.

gmackall · 2024-06-25T01:15:47Z

Reason for revert: This breaks apps that use plugins that use compileSdk 31, some of which we use in our postsubmit (so it blocks the tree).

This reverts commit ca116ee.

Reverts: #150733 Initiated by: gmackall Reason for reverting: This breaks apps that use plugins that use `compileSdk` 31, some of which we use in our postsubmit (so it blocks the tree). Original PR Author: gmackall Reviewed By: {jason-simmons} This change reverts the following previous change: Manual engine roll to flutter/engine#53532, because the roll requires lockfile generation.

Roll Flutter from 6c06abb to e726eb4 (51 revisions) flutter/flutter@6c06abb...e726eb4 2024-06-25 [email protected] Roll Packages from 711b4ac to 03f5f6d (21 revisions) (flutter/flutter#150779) 2024-06-25 [email protected] Roll Flutter Engine from afa7ce19bca8 to fbd92055f3a6 (1 revision) (flutter/flutter#150777) 2024-06-25 32538273 [email protected] Reland Add tests for form_text_field.1.dart (#150481) (#150696) (flutter/flutter#150750) 2024-06-25 104349824 [email protected] Add an example for CupertinoPopupSurface (flutter/flutter#150357) 2024-06-25 [email protected] [flutter_tools/dap] Handle app.stop errors when launching/attaching (flutter/flutter#149734) 2024-06-25 [email protected] Roll Flutter Engine from be7db94196fe to afa7ce19bca8 (18 revisions) (flutter/flutter#150762) 2024-06-25 [email protected] Remove dubious comment (flutter/flutter#150608) 2024-06-25 98614782 auto-submit[bot]@users.noreply.github.com Reverts "Manual engine roll to 6884e83 (#150733)" (flutter/flutter#150746) 2024-06-25 34871572 [email protected] Manual engine roll to 6884e83 (flutter/flutter#150733) 2024-06-24 [email protected] Linkify 'see also' sections (flutter/flutter#150734) 2024-06-24 137456488 [email protected] Roll pub packages (flutter/flutter#150712) 2024-06-24 [email protected] Update flutter.dev links from framework to more permanent destinations (flutter/flutter#150531) 2024-06-24 [email protected] Manual engine roll to be7db94196fe (flutter/flutter#150714) 2024-06-24 [email protected] allow adb to set canfail then use canFail=true for clearing logs (flutter/flutter#150517) 2024-06-24 [email protected] Update android_device.dart to have clearLogs not print to standard error (flutter/flutter#150197) 2024-06-24 [email protected] Update issue link in analysis_options.yaml (flutter/flutter#150395) 2024-06-24 [email protected] Fix a number of broken doc comment references (flutter/flutter#150540) 2024-06-24 [email protected] Fix flaky sliver tree test (flutter/flutter#150707) 2024-06-24 98614782 auto-submit[bot]@users.noreply.github.com Reverts "Add tests for form_text_field.1.dart (#150481)" (flutter/flutter#150696) 2024-06-24 32538273 [email protected] Add tests for form_text_field.1.dart (flutter/flutter#150481) 2024-06-22 [email protected] Fix: Memory leak in UndoHistory widget because it never de-registered itself as global UndoManager client (Resolves #148291) (flutter/flutter#150661) 2024-06-22 [email protected] [CupertinoActionSheet] Fix the layout (part 1) (flutter/flutter#149636) 2024-06-21 34871572 [email protected] Remove discontinued `device_info` and `connectivity` plugins from `flutter_gallery`, roll pub packages (flutter/flutter#150585) 2024-06-21 [email protected] [a11y] Update semantics in bottom_navigation_bar.dart (flutter/flutter#150576) 2024-06-21 [email protected] Roll Flutter Engine from dda82d905f37 to 33415c6ee7c2 (7 revisions) (flutter/flutter#150637) 2024-06-21 [email protected] Reland 4: [CupertinoActionSheet] Match colors to native (flutter/flutter#150442) 2024-06-21 [email protected] Enable SelectionArea double tap/triple tap gesture support for mobile platforms (flutter/flutter#149295) 2024-06-21 [email protected] made SelectionArea alignment consistent between web and other platform (flutter/flutter#150037) 2024-06-21 [email protected] Fix link hook typo (flutter/flutter#150194) 2024-06-21 [email protected] Stop looking for .packages when analyzing (flutter/flutter#150349) 2024-06-20 [email protected] Update flutter.dev links from misc packages to more permanent destinations (flutter/flutter#150532) 2024-06-20 [email protected] Roll Flutter Engine from dd37cefd4a94 to dda82d905f37 (9 revisions) (flutter/flutter#150582) 2024-06-20 36861262 [email protected] Update Material token to the latest 4.1.0 (flutter/flutter#150382) 2024-06-20 34871572 [email protected] Let the lockfile script generate lockfiles for kotlin gradle files as well (flutter/flutter#150471) 2024-06-20 [email protected] Make popup menu hardcoded padding configurable (flutter/flutter#150506) 2024-06-20 [email protected] [flutter_tools] un-hide the --dds flag (flutter/flutter#150280) 2024-06-20 59215665 [email protected] [material/menu_anchor.dart] Remove _MenuAnchorState from parent when disposed. (flutter/flutter#149586) 2024-06-20 32538273 [email protected] Add test for inherited_notifier.0.dart (flutter/flutter#150344) 2024-06-20 [email protected] [CLI tool] in `flutter test`, consider `--flavor` when validating the cached asset bundle (flutter/flutter#150461) 2024-06-20 82763757 [email protected] Test InputDecoration API examples (flutter/flutter#148560) 2024-06-20 [email protected] Clean leaky tests. (flutter/flutter#150335) 2024-06-20 [email protected] Roll Flutter Engine from f9c497f178d3 to dd37cefd4a94 (2 revisions) (flutter/flutter#150537) 2024-06-20 [email protected] Roll Flutter Engine from a31279381b40 to f9c497f178d3 (9 revisions) (flutter/flutter#150528) 2024-06-19 32538273 [email protected] Add tests for about_list_tile.0.dart (flutter/flutter#150181) 2024-06-19 [email protected] Roll Flutter Engine from 0ad18fe4c0b5 to a31279381b40 (7 revisions) (flutter/flutter#150473) 2024-06-18 [email protected] Revert "[a11y] Add semantics: button to bottom navigation bar items and dropdown menu items" (flutter/flutter#150445) ...

Manual engine roll to flutter/engine#53532, because the roll requires lockfile generation.

) Reverts: flutter#150733 Initiated by: gmackall Reason for reverting: This breaks apps that use plugins that use `compileSdk` 31, some of which we use in our postsubmit (so it blocks the tree). Original PR Author: gmackall Reviewed By: {jason-simmons} This change reverts the following previous change: Manual engine roll to flutter/engine#53532, because the roll requires lockfile generation.

…3592) Re-re-re-land #53001. I recreated the postsubmit failures of the [roll](flutter/flutter#150733) of the [last land](#53532), and then verified on a local branch that those same postsubmits pass with this upgrade after the land of flutter/flutter#150873. So I have pretty high confidence this won't cause any problems in the framework repo. I also tested on a previous land attempt that the `all_packages` app builds on this branch, so that is also a good sign for the packages repo. [C , Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

Gray Mackall added 2 commits June 24, 2024 15:12

roll to hash

8dddc35

lockfiles

3ba0c8b

gmackall and others added 2 commits June 24, 2024 15:39

Merge branch 'master' into manual_engine_androidx_roll

be5f617

empty commit to re run mac test

a37dd03

gmackall requested review from jason-simmons and a team June 24, 2024 23:48

gmackall marked this pull request as ready for review June 24, 2024 23:48

jason-simmons approved these changes Jun 25, 2024

View reviewed changes

gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 25, 2024

auto-submit bot merged commit ca116ee into flutter:master Jun 25, 2024
139 checks passed

gmackall mentioned this pull request Jun 25, 2024

Update androidx window dependency to 1.1 #129307

Closed

gmackall added the revert Autorevert PR (with "Reason for revert:" comment) label Jun 25, 2024

auto-submit bot pushed a commit that referenced this pull request Jun 25, 2024

Revert "Manual engine roll to 6884e83 (#150733)"

9c86d08

This reverts commit ca116ee.

auto-submit bot mentioned this pull request Jun 25, 2024

Reverts "Manual engine roll to 6884e83 (#150733)" #150746

Merged

9 tasks

auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Jun 25, 2024

engine-flutter-autoroll mentioned this pull request Jun 25, 2024

Roll Flutter from 6c06abbb5576 to 93c14565f0ec (49 revisions) flutter/packages#6985

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 25, 2024

ca116ee Manual engine roll to 6884e83 (flutter/flutter#150733)

147efa7

engine-flutter-autoroll mentioned this pull request Jun 25, 2024

Roll Flutter from 6c06abbb5576 to f90f40a86619 (50 revisions) flutter/packages#6986

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 25, 2024

ca116ee Manual engine roll to 6884e83 (flutter/flutter#150733)

92e5b4b

engine-flutter-autoroll mentioned this pull request Jun 25, 2024

Roll Flutter from 6c06abbb5576 to e726eb401c2c (51 revisions) flutter/packages#6987

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 25, 2024

ca116ee Manual engine roll to 6884e83 (flutter/flutter#150733)

0eba44a

sigurdm pushed a commit to sigurdm/flutter that referenced this pull request Jun 26, 2024

Manual engine roll to 6884e83 (flutter#150733)

d195496

Manual engine roll to flutter/engine#53532, because the roll requires lockfile generation.

gmackall mentioned this pull request Jun 27, 2024

Re-re-re-land "Upgrade all[most] androidx dependencies to latest" flutter/engine#53592

Merged

8 tasks

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024

ca116ee Manual engine roll to 6884e83 (flutter/flutter#150733)

e03f39e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Manual engine roll to 6884e83 #150733

Manual engine roll to 6884e83 #150733

gmackall commented Jun 24, 2024 •

edited

Loading

gmackall commented Jun 25, 2024

gmackall commented Jun 25, 2024

Manual engine roll to 6884e83 #150733

Manual engine roll to 6884e83 #150733

Conversation

gmackall commented Jun 24, 2024 • edited Loading

Pre-launch Checklist

gmackall commented Jun 25, 2024

gmackall commented Jun 25, 2024

gmackall commented Jun 24, 2024 •

edited

Loading