Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove zanderso from TESTOWNERS #149935

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Conversation

zanderso
Copy link
Member

@zanderso zanderso commented Jun 7, 2024

Instead I've added @andrewkolos for tools tests and @jtmcdole for engine tests. This doesn't mean you have to investigate and solve the issues filed by the flake bot. Instead, an assignee is just the mechanism used by the flake bot to ensure that the issues are triaged at the appropriate team triage meetings.

FYI @christopherfujino

Copy link
Contributor

@andrewkolos andrewkolos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@zanderso zanderso requested a review from jtmcdole June 7, 2024 21:11
@zanderso zanderso merged commit 47560fa into flutter:master Jun 7, 2024
28 checks passed
@zanderso zanderso deleted the rm-zra-testowner branch June 7, 2024 23:33
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 8, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 8, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 8, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 9, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jun 10, 2024
flutter/flutter@fc19ecf...32081aa

2024-06-08 [email protected] [CupertinoActionSheet] Match colors to native (flutter/flutter#149568)
2024-06-08 98614782 auto-submit[bot]@users.noreply.github.com Reverts "Roll Flutter Engine from 1cdbebee1901 to 45cf05f7a580 (10 revisions) (#149944)" (flutter/flutter#149960)
2024-06-08 [email protected] Roll Flutter Engine from 1cdbebee1901 to 45cf05f7a580 (10 revisions) (flutter/flutter#149944)
2024-06-07 21270878 [email protected] Refactor `getRootWidgetSummaryTree` tests in `widget_inspector_test.dart` (flutter/flutter#149930)
2024-06-07 [email protected] Remove zanderso from TESTOWNERS (flutter/flutter#149935)
2024-06-07 [email protected] PinnedHeaderSliver (flutter/flutter#143196)
2024-06-07 21270878 [email protected] Fix test case in "getRootWidgetSummaryTree" test (flutter/flutter#149923)
2024-06-07 34871572 [email protected] Revert "Identify and re-throw our dependency checking errors in `flutter.groovy` (#149609)" (flutter/flutter#149918)
2024-06-07 98614782 auto-submit[bot]@users.noreply.github.com Reverts "Fix `SegmentedButton` clipping when drawing segments (#149739)" (flutter/flutter#149927)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/ doc/main/autoroll/README.md
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
flutter/flutter@fc19ecf...32081aa

2024-06-08 [email protected] [CupertinoActionSheet] Match colors to native (flutter/flutter#149568)
2024-06-08 98614782 auto-submit[bot]@users.noreply.github.com Reverts "Roll Flutter Engine from 1cdbebee1901 to 45cf05f7a580 (10 revisions) (#149944)" (flutter/flutter#149960)
2024-06-08 [email protected] Roll Flutter Engine from 1cdbebee1901 to 45cf05f7a580 (10 revisions) (flutter/flutter#149944)
2024-06-07 21270878 [email protected] Refactor `getRootWidgetSummaryTree` tests in `widget_inspector_test.dart` (flutter/flutter#149930)
2024-06-07 [email protected] Remove zanderso from TESTOWNERS (flutter/flutter#149935)
2024-06-07 [email protected] PinnedHeaderSliver (flutter/flutter#143196)
2024-06-07 21270878 [email protected] Fix test case in "getRootWidgetSummaryTree" test (flutter/flutter#149923)
2024-06-07 34871572 [email protected] Revert "Identify and re-throw our dependency checking errors in `flutter.groovy` (#149609)" (flutter/flutter#149918)
2024-06-07 98614782 auto-submit[bot]@users.noreply.github.com Reverts "Fix `SegmentedButton` clipping when drawing segments (#149739)" (flutter/flutter#149927)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/ doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants