Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce ChipAnimationStyle to override default chips animations durations #149245

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Introduce ChipAnimationStyle to override default chips animations durations #149245

merged 1 commit into from
Jun 6, 2024

Conversation

TahaTesser
Copy link
Member

fixes Custom backgroundColor on Chip makes it flicker between state transitions

Example preview

Screenshot 2024-05-28 at 17 40 00

Screen.Recording.2024-05-29.at.17.58.18.mov

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. a: animation Animation APIs f: material design flutter/packages/flutter/material repository. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels May 29, 2024
@TahaTesser TahaTesser marked this pull request as ready for review May 29, 2024 15:22
@TahaTesser TahaTesser requested a review from Piinks May 29, 2024 16:12
Piinks
Piinks approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much style! :)
LGTM

@TahaTesser TahaTesser requested a review from bleroux June 6, 2024 07:41
bleroux
bleroux approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@bleroux bleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TahaTesser TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 6, 2024
@auto-submit auto-submit bot merged commit 0a54670 into flutter:master Jun 6, 2024
72 checks passed
@TahaTesser TahaTesser deleted the chip_animation_style branch June 6, 2024 19:44
@QuncCccccc QuncCccccc added the revert Autorevert PR (with "Reason for revert:" comment) label Jun 6, 2024
@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented Jun 6, 2024

A reason for requesting a revert of flutter/flutter/149245 could
not be found or the reason was not properly formatted. Begin a comment with 'Reason for revert:' to tell the bot why
this issue is being reverted.

@auto-submit auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Jun 6, 2024
@QuncCccccc
Copy link
Contributor

Reason for revert: the newly-added unit test might cause the red tree

@QuncCccccc QuncCccccc added the revert Autorevert PR (with "Reason for revert:" comment) label Jun 6, 2024
@Piinks
Copy link
Contributor

Piinks commented Jun 6, 2024

Reason for revert: the newly-added unit test might cause the red tree

This has happened on several PRs this week. How are these tests passing in presubmit? cc @christopherfujino I'll file an infra bug

auto-submit bot pushed a commit that referenced this pull request Jun 6, 2024
Revert "Introduce ChipAnimationStyle to override default chips anim…
da88d49 
…ations durations (#149245)"

This reverts commit 0a54670.
@auto-submit auto-submit bot mentioned this pull request Jun 6, 2024
Merged
9 tasks
@auto-submit auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Jun 6, 2024
auto-submit bot added a commit that referenced this pull request Jun 6, 2024
@auto-submit
Reverts "Introduce ChipAnimationStyle to override default chips ani…
6f2d0be 
…mations durations (#149245)" (#149847)

Reverts: #149245
Initiated by: QuncCccccc
Reason for reverting: the newly-added unit test might cause the red tree
Original PR Author: TahaTesser

Reviewed By: {bleroux, Piinks}

This change reverts the following previous change:
fixes [Custom backgroundColor on Chip makes it flicker between state transitions](#146730)

### Example preview
![Screenshot 2024-05-28 at 17 40 00](https://github.com/flutter/flutter/assets/48603081/b9117ed2-5afa-4d65-93ae-aa866772ffa1)

https://github.com/flutter/flutter/assets/48603081/a4949ce7-f38b-4251-8201-ecc570ec447c
@christopherfujino
Copy link
Member

Reason for revert: the newly-added unit test might cause the red tree

This has happened on several PRs this week. How are these tests passing in presubmit? cc @christopherfujino I'll file an infra bug

Looks like we tested the wrong commit in presubmit: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8745894885153659393/ /u/flutter_doctor/stdout

I don't think we even ran this test. Will follow up on the tracking issue.

@Piinks Piinks mentioned this pull request Jun 6, 2024
Closed
@Piinks
Copy link
Contributor

Piinks commented Jun 6, 2024

Reason for revert: the newly-added unit test might cause the red tree

This has happened on several PRs this week. How are these tests passing in presubmit? cc @christopherfujino I'll file an infra bug

Looks like we tested the wrong commit in presubmit: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8745894885153659393/ /u/flutter_doctor/stdout

I don't think we even ran this test. Will follow up on the tracking issue.

That could have also caused the gold failures at head if some subset of golden file tests did not run in presubmit.

Filed #149851

@TahaTesser TahaTesser mentioned this pull request Jun 7, 2024
Merged
9 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 7, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2024
@engine-flutter-autoroll
0a546705b Introduce ChipAnimationStyle to override default chips an…
d9b1ac7 
…imations durations (flutter/flutter#149245)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 7, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2024
@engine-flutter-autoroll
0a546705b Introduce ChipAnimationStyle to override default chips an…
4535fb2 
…imations durations (flutter/flutter#149245)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 7, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2024
@engine-flutter-autoroll
0a546705b Introduce ChipAnimationStyle to override default chips an…
33212c7 
…imations durations (flutter/flutter#149245)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 7, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2024
@engine-flutter-autoroll
0a546705b Introduce ChipAnimationStyle to override default chips an…
90f894a 
…imations durations (flutter/flutter#149245)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 7, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2024
@engine-flutter-autoroll
0a546705b Introduce ChipAnimationStyle to override default chips an…
28ef330 
…imations durations (flutter/flutter#149245)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 7, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2024
@engine-flutter-autoroll
0a546705b Introduce ChipAnimationStyle to override default chips an…
d1341b2 
…imations durations (flutter/flutter#149245)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 7, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2024
@engine-flutter-autoroll
0a546705b Introduce ChipAnimationStyle to override default chips an…
1a6b089 
…imations durations (flutter/flutter#149245)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jun 7, 2024
@engine-flutter-autoroll
Manual roll Flutter from 4608a8913767 to fc19ecfc585a (38 revisions) (#…
e95fe4a 
…6890)

Manual roll Flutter from 4608a8913767 to fc19ecfc585a (38 revisions)

Manual roll requested by [email protected]

flutter/flutter@4608a89...fc19ecf

2024-06-07 [email protected] Fix `SegmentedButton` clipping when drawing segments (flutter/flutter#149739)
2024-06-07 [email protected] Shift consistently passing tests on mokey to prod (flutter/flutter#149902)
2024-06-07 [email protected] Prepare images for tests individually to enable clean up of cache. (flutter/flutter#149693)
2024-06-07 [email protected] Roll Packages from 586faa6 to 8a2c4e4 (8 revisions) (flutter/flutter#149900)
2024-06-07 [email protected] Roll Flutter Engine from 98e9393bf2e9 to 1cdbebee1901 (4 revisions) (flutter/flutter#149899)
2024-06-07 [email protected] Roll Flutter Engine from 087feab9922b to 98e9393bf2e9 (1 revision) (flutter/flutter#149875)
2024-06-07 21270878 [email protected] Refactor `widget_inspector_test.dart` (flutter/flutter#149850)
2024-06-07 32538273 [email protected] Add test for dropdown_menu.1.dart (flutter/flutter#149547)
2024-06-07 32538273 [email protected] Add test for standard_fab_location.0.dart (flutter/flutter#149225)
2024-06-07 [email protected] [native_assets] Fix framework name deduplication (flutter/flutter#149761)
2024-06-07 [email protected] Roll Flutter Engine from 47b15dfba1da to 087feab9922b (1 revision) (flutter/flutter#149871)
2024-06-07 [email protected] Roll Flutter Engine from 5d5e0ee9102c to 47b15dfba1da (2 revisions) (flutter/flutter#149870)
2024-06-07 [email protected] Roll Flutter Engine from fea8e51b0280 to 5d5e0ee9102c (2 revisions) (flutter/flutter#149867)
2024-06-07 [email protected] Roll Flutter Engine from 5a0a49939c64 to fea8e51b0280 (2 revisions) (flutter/flutter#149865)
2024-06-07 137456488 [email protected] Roll pub packages (flutter/flutter#149864)
2024-06-06 [email protected] Roll Flutter Engine from bf1a4877da0b to 5a0a49939c64 (1 revision) (flutter/flutter#149861)
2024-06-06 [email protected] Remove some vestigial /*!*/ comments (flutter/flutter#149361)
2024-06-06 [email protected] Attempt to fix some web test flakiness. (flutter/flutter#149828)
2024-06-06 [email protected] Remove abi key permanently from golden file testing (flutter/flutter#149858)
2024-06-06 [email protected] [CupertinoActionSheet] Add sliding tap gesture (flutter/flutter#149471)
2024-06-06 137456488 [email protected] Roll pub packages (flutter/flutter#149852)
2024-06-06 [email protected] SliverResizingHeader (flutter/flutter#143325)
2024-06-06 15619084 [email protected] Run tests on macOS 13 or 14 (flutter/flutter#149827)
2024-06-06 [email protected] Fix leaky test. (flutter/flutter#149823)
2024-06-06 [email protected] Roll Flutter Engine from 31804a222f97 to bf1a4877da0b (3 revisions) (flutter/flutter#149848)
2024-06-06 [email protected] Add support for setting the heading level for web semantics (#97894) (flutter/flutter#125771)
2024-06-06 98614782 auto-submit[bot]@users.noreply.github.com Reverts "Introduce `ChipAnimationStyle` to override default chips animations durations (#149245)" (flutter/flutter#149847)
2024-06-06 [email protected] 3.22.2 release notes (flutter/flutter#149818)
2024-06-06 [email protected] Roll Flutter Engine from 25bcbb888939 to 31804a222f97 (3 revisions) (flutter/flutter#149837)
2024-06-06 [email protected] Introduce `ChipAnimationStyle` to override default chips animations durations (flutter/flutter#149245)
2024-06-06 [email protected] Roll Flutter Engine from f5a9690c6061 to 25bcbb888939 (1 revision) (flutter/flutter#149835)
2024-06-06 [email protected] Fix leaky test. (flutter/flutter#149822)
2024-06-06 [email protected] Unpin archive package from tool, update to version without security advisories (flutter/flutter#149430)
2024-06-06 137456488 [email protected] Roll pub packages (flutter/flutter#149630)
2024-06-06 [email protected] Roll Flutter Engine from d9684a37af06 to f5a9690c6061 (7 revisions) (flutter/flutter#149832)
2024-06-06 [email protected] Roll Packages from 11e192a to 586faa6 (13 revisions) (flutter/flutter#149820)
2024-06-06 [email protected] Fix some links in the "Handling breaking change" section (flutter/flutter#149821)
2024-06-06 [email protected] Roll Flutter Engine from 92d0cd9370f7 to d9684a37af06 (1 revision) (flutter/flutter#149793)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
...
auto-submit bot pushed a commit that referenced this pull request Jun 13, 2024
@TahaTesser
[Reland] Introduce ChipAnimationStyle to override default chips ani…
f56e0c2 
…mations durations (#149876)

Reland - #149245

---

fixes [Custom backgroundColor on Chip makes it flicker between state transitions](#146730)

### Example preview
![Screenshot 2024-05-28 at 17 40 00](https://github.com/flutter/flutter/assets/48603081/b9117ed2-5afa-4d65-93ae-aa866772ffa1)

https://github.com/flutter/flutter/assets/48603081/a4949ce7-f38b-4251-8201-ecc570ec447c
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
@engine-flutter-autoroll @arc-yong
Manual roll Flutter from 4608a8913767 to fc19ecfc585a (38 revisions) (f…
97b7061 
…lutter#6890)

Manual roll Flutter from 4608a8913767 to fc19ecfc585a (38 revisions)

Manual roll requested by [email protected]

flutter/flutter@4608a89...fc19ecf

2024-06-07 [email protected] Fix `SegmentedButton` clipping when drawing segments (flutter/flutter#149739)
2024-06-07 [email protected] Shift consistently passing tests on mokey to prod (flutter/flutter#149902)
2024-06-07 [email protected] Prepare images for tests individually to enable clean up of cache. (flutter/flutter#149693)
2024-06-07 [email protected] Roll Packages from 586faa6 to 8a2c4e4 (8 revisions) (flutter/flutter#149900)
2024-06-07 [email protected] Roll Flutter Engine from 98e9393bf2e9 to 1cdbebee1901 (4 revisions) (flutter/flutter#149899)
2024-06-07 [email protected] Roll Flutter Engine from 087feab9922b to 98e9393bf2e9 (1 revision) (flutter/flutter#149875)
2024-06-07 21270878 [email protected] Refactor `widget_inspector_test.dart` (flutter/flutter#149850)
2024-06-07 32538273 [email protected] Add test for dropdown_menu.1.dart (flutter/flutter#149547)
2024-06-07 32538273 [email protected] Add test for standard_fab_location.0.dart (flutter/flutter#149225)
2024-06-07 [email protected] [native_assets] Fix framework name deduplication (flutter/flutter#149761)
2024-06-07 [email protected] Roll Flutter Engine from 47b15dfba1da to 087feab9922b (1 revision) (flutter/flutter#149871)
2024-06-07 [email protected] Roll Flutter Engine from 5d5e0ee9102c to 47b15dfba1da (2 revisions) (flutter/flutter#149870)
2024-06-07 [email protected] Roll Flutter Engine from fea8e51b0280 to 5d5e0ee9102c (2 revisions) (flutter/flutter#149867)
2024-06-07 [email protected] Roll Flutter Engine from 5a0a49939c64 to fea8e51b0280 (2 revisions) (flutter/flutter#149865)
2024-06-07 137456488 [email protected] Roll pub packages (flutter/flutter#149864)
2024-06-06 [email protected] Roll Flutter Engine from bf1a4877da0b to 5a0a49939c64 (1 revision) (flutter/flutter#149861)
2024-06-06 [email protected] Remove some vestigial /*!*/ comments (flutter/flutter#149361)
2024-06-06 [email protected] Attempt to fix some web test flakiness. (flutter/flutter#149828)
2024-06-06 [email protected] Remove abi key permanently from golden file testing (flutter/flutter#149858)
2024-06-06 [email protected] [CupertinoActionSheet] Add sliding tap gesture (flutter/flutter#149471)
2024-06-06 137456488 [email protected] Roll pub packages (flutter/flutter#149852)
2024-06-06 [email protected] SliverResizingHeader (flutter/flutter#143325)
2024-06-06 15619084 [email protected] Run tests on macOS 13 or 14 (flutter/flutter#149827)
2024-06-06 [email protected] Fix leaky test. (flutter/flutter#149823)
2024-06-06 [email protected] Roll Flutter Engine from 31804a222f97 to bf1a4877da0b (3 revisions) (flutter/flutter#149848)
2024-06-06 [email protected] Add support for setting the heading level for web semantics (#97894) (flutter/flutter#125771)
2024-06-06 98614782 auto-submit[bot]@users.noreply.github.com Reverts "Introduce `ChipAnimationStyle` to override default chips animations durations (#149245)" (flutter/flutter#149847)
2024-06-06 [email protected] 3.22.2 release notes (flutter/flutter#149818)
2024-06-06 [email protected] Roll Flutter Engine from 25bcbb888939 to 31804a222f97 (3 revisions) (flutter/flutter#149837)
2024-06-06 [email protected] Introduce `ChipAnimationStyle` to override default chips animations durations (flutter/flutter#149245)
2024-06-06 [email protected] Roll Flutter Engine from f5a9690c6061 to 25bcbb888939 (1 revision) (flutter/flutter#149835)
2024-06-06 [email protected] Fix leaky test. (flutter/flutter#149822)
2024-06-06 [email protected] Unpin archive package from tool, update to version without security advisories (flutter/flutter#149430)
2024-06-06 137456488 [email protected] Roll pub packages (flutter/flutter#149630)
2024-06-06 [email protected] Roll Flutter Engine from d9684a37af06 to f5a9690c6061 (7 revisions) (flutter/flutter#149832)
2024-06-06 [email protected] Roll Packages from 11e192a to 586faa6 (13 revisions) (flutter/flutter#149820)
2024-06-06 [email protected] Fix some links in the "Handling breaking change" section (flutter/flutter#149821)
2024-06-06 [email protected] Roll Flutter Engine from 92d0cd9370f7 to d9684a37af06 (1 revision) (flutter/flutter#149793)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
...
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request Jun 14, 2024
@TahaTesser @victorsanni
[Reland] Introduce ChipAnimationStyle to override default chips ani…
c0663fc 
…mations durations (flutter#149876)

Reland - flutter#149245

---

fixes [Custom backgroundColor on Chip makes it flicker between state transitions](flutter#146730)

### Example preview
![Screenshot 2024-05-28 at 17 40 00](https://github.com/flutter/flutter/assets/48603081/b9117ed2-5afa-4d65-93ae-aa866772ffa1)

https://github.com/flutter/flutter/assets/48603081/a4949ce7-f38b-4251-8201-ecc570ec447c
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request Jun 14, 2024
@TahaTesser @victorsanni
[Reland] Introduce ChipAnimationStyle to override default chips ani…
0608809 
…mations durations (flutter#149876)

Reland - flutter#149245

---

fixes [Custom backgroundColor on Chip makes it flicker between state transitions](flutter#146730)

### Example preview
![Screenshot 2024-05-28 at 17 40 00](https://github.com/flutter/flutter/assets/48603081/b9117ed2-5afa-4d65-93ae-aa866772ffa1)

https://github.com/flutter/flutter/assets/48603081/a4949ce7-f38b-4251-8201-ecc570ec447c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bleroux bleroux bleroux approved these changes

@Piinks Piinks Piinks approved these changes

Assignees
No one assigned
Labels
a: animation Animation APIs autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom backgroundColor on Chip makes it flicker between state transitions
5 participants
@TahaTesser @QuncCccccc @Piinks @christopherfujino @bleroux