Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for actions.0.dart API example. #148678

Merged
merged 1 commit into from
May 22, 2024
Merged

Add tests for actions.0.dart API example. #148678

merged 1 commit into from
May 22, 2024

Conversation

ksokolovskyi
Copy link
Contributor

This PR contributes to #130459

Description

  • Updates examples/api/lib/widgets/actions/actions.0.dart to meet the latest API examples structure
  • Adds tests for examples/api/lib/widgets/actions/actions.0.dart

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels May 20, 2024
bleroux
bleroux approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@bleroux bleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good call on adding a proper disposal of ValueNotifiers 👍 .
Just one small nit.

examples/api/test/widgets/actions/actions.0_test.dart
return button.style?.foregroundColor?.resolve(<WidgetState>{});
}

testWidgets('increments and decrements value', (WidgetTester tester) async {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider capitalizing the first letter of the test description.

TahaTesser
TahaTesser approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TahaTesser TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label May 22, 2024
@auto-submit auto-submit bot merged commit 112e8b5 into flutter:master May 22, 2024
139 checks passed
@ksokolovskyi
Copy link
Contributor Author

@bleroux @TahaTesser thanks for the review and merge!
I fixed the name of the test in my other open PR: #148676

hello-coder-xu added a commit to hello-coder-xu/flutter that referenced this pull request May 22, 2024
@hello-coder-xu
Merge branch 'master' into fix/_floatingActionButtonVisibilityValue-u…
e09a2a2 
…pdate

* master: (92 commits)
  Add tests for actions.0.dart API example. (flutter#148678)
  Introduce `WidgetStateBorderSide.lerp` (flutter#148122)
  add `default-flavor` field to flutter pubspec, which will be used as the flavor in `flutter build/run` if `--flavor` is not provided (flutter#147968)
  [wiki migration] Pages under docs/postmortems/ (flutter#148798)
  Roll Flutter Engine from e5a73e520e89 to c89defa55801 (2 revisions) (flutter#148812)
  Make hover tests functional and cleanup mouse pointers in Material toggleables (flutter#148808)
  Fix two dimensional viewport unexpected null exception when no child is laid out (flutter#148256)
  Roll Flutter Engine from bc1345b6b50a to e5a73e520e89 (3 revisions) (flutter#148807)
  Add test for undo_history_controller.0.dart (flutter#148205)
  Roll Flutter Engine from a8872c8915a2 to bc1345b6b50a (6 revisions) (flutter#148802)
  Fix test that leaks images. (flutter#148494)
  Fix warnings in `dependency_version_checker.gradle.kts` (flutter#148699)
  [wiki migration] Android team pages (flutter#148585)
  Fix leaky test. (flutter#148788)
  Add DropdownButton.menuWidth (flutter#148125)
  Add test for focus example 2 (flutter#147624)
  Add a migrator to remove `FlutterMultiDexApplication.java` (flutter#148515)
  [wiki migration] Infra team pages (flutter#148718)
  Roll Flutter Engine from 8a352f01e503 to a8872c8915a2 (1 revision) (flutter#148776)
  Fix the output of the CDN test. (flutter#148730)
  ...
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 22, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 22, 2024
@engine-flutter-autoroll
112e8b5 Add tests for actions.0.dart API example. (flutter/flutter#14…
ca19537 
…8678)
hello-coder-xu added a commit to hello-coder-xu/flutter that referenced this pull request May 23, 2024
@hello-coder-xu
Merge branch 'master' into fix/slider_text_null_error
dfc4dea 
* master: (29 commits)
  Add tests for actions.0.dart API example. (flutter#148678)
  Introduce `WidgetStateBorderSide.lerp` (flutter#148122)
  add `default-flavor` field to flutter pubspec, which will be used as the flavor in `flutter build/run` if `--flavor` is not provided (flutter#147968)
  [wiki migration] Pages under docs/postmortems/ (flutter#148798)
  Roll Flutter Engine from e5a73e520e89 to c89defa55801 (2 revisions) (flutter#148812)
  Make hover tests functional and cleanup mouse pointers in Material toggleables (flutter#148808)
  Fix two dimensional viewport unexpected null exception when no child is laid out (flutter#148256)
  Roll Flutter Engine from bc1345b6b50a to e5a73e520e89 (3 revisions) (flutter#148807)
  Add test for undo_history_controller.0.dart (flutter#148205)
  Roll Flutter Engine from a8872c8915a2 to bc1345b6b50a (6 revisions) (flutter#148802)
  Fix test that leaks images. (flutter#148494)
  Fix warnings in `dependency_version_checker.gradle.kts` (flutter#148699)
  [wiki migration] Android team pages (flutter#148585)
  Fix leaky test. (flutter#148788)
  Add DropdownButton.menuWidth (flutter#148125)
  Add test for focus example 2 (flutter#147624)
  Add a migrator to remove `FlutterMultiDexApplication.java` (flutter#148515)
  [wiki migration] Infra team pages (flutter#148718)
  Roll Flutter Engine from 8a352f01e503 to a8872c8915a2 (1 revision) (flutter#148776)
  Fix the output of the CDN test. (flutter#148730)
  ...
hello-coder-xu added a commit to hello-coder-xu/flutter that referenced this pull request May 23, 2024
@hello-coder-xu
Merge branch 'master' into feature/grid_delegate_add_assert
c644da0 
* master: (92 commits)
  Add tests for actions.0.dart API example. (flutter#148678)
  Introduce `WidgetStateBorderSide.lerp` (flutter#148122)
  add `default-flavor` field to flutter pubspec, which will be used as the flavor in `flutter build/run` if `--flavor` is not provided (flutter#147968)
  [wiki migration] Pages under docs/postmortems/ (flutter#148798)
  Roll Flutter Engine from e5a73e520e89 to c89defa55801 (2 revisions) (flutter#148812)
  Make hover tests functional and cleanup mouse pointers in Material toggleables (flutter#148808)
  Fix two dimensional viewport unexpected null exception when no child is laid out (flutter#148256)
  Roll Flutter Engine from bc1345b6b50a to e5a73e520e89 (3 revisions) (flutter#148807)
  Add test for undo_history_controller.0.dart (flutter#148205)
  Roll Flutter Engine from a8872c8915a2 to bc1345b6b50a (6 revisions) (flutter#148802)
  Fix test that leaks images. (flutter#148494)
  Fix warnings in `dependency_version_checker.gradle.kts` (flutter#148699)
  [wiki migration] Android team pages (flutter#148585)
  Fix leaky test. (flutter#148788)
  Add DropdownButton.menuWidth (flutter#148125)
  Add test for focus example 2 (flutter#147624)
  Add a migrator to remove `FlutterMultiDexApplication.java` (flutter#148515)
  [wiki migration] Infra team pages (flutter#148718)
  Roll Flutter Engine from 8a352f01e503 to a8872c8915a2 (1 revision) (flutter#148776)
  Fix the output of the CDN test. (flutter#148730)
  ...
auto-submit bot pushed a commit to flutter/packages that referenced this pull request May 23, 2024
@engine-flutter-autoroll
Roll Flutter from d02292d to 73bf206 (31 revisions) (#6780)
1c4eaf3 
flutter/flutter@d02292d...73bf206

2024-05-22 102401667 [email protected] `CupertinoDialogRoute` leak fix (flutter/flutter#148774)
2024-05-22 [email protected] Marks Windows plugin_test to be flaky (flutter/flutter#148835)
2024-05-22 [email protected] Add tests for actions.0.dart API example. (flutter/flutter#148678)
2024-05-22 [email protected] Introduce `WidgetStateBorderSide.lerp` (flutter/flutter#148122)
2024-05-22 [email protected] add `default-flavor` field to flutter pubspec, which will be used as the flavor in `flutter build/run` if `--flavor` is not provided (flutter/flutter#147968)
2024-05-22 [email protected] [wiki migration] Pages under docs/postmortems/ (flutter/flutter#148798)
2024-05-22 [email protected] Roll Flutter Engine from e5a73e520e89 to c89defa55801 (2 revisions) (flutter/flutter#148812)
2024-05-22 [email protected] Make hover tests functional and cleanup mouse pointers in Material toggleables (flutter/flutter#148808)
2024-05-21 [email protected] Fix two dimensional viewport unexpected null exception when no child is laid out (flutter/flutter#148256)
2024-05-21 [email protected] Roll Flutter Engine from bc1345b6b50a to e5a73e520e89 (3 revisions) (flutter/flutter#148807)
2024-05-21 32538273 [email protected] Add test for undo_history_controller.0.dart (flutter/flutter#148205)
2024-05-21 [email protected] Roll Flutter Engine from a8872c8915a2 to bc1345b6b50a (6 revisions) (flutter/flutter#148802)
2024-05-21 [email protected] Fix test that leaks images. (flutter/flutter#148494)
2024-05-21 34871572 [email protected] Fix warnings in `dependency_version_checker.gradle.kts` (flutter/flutter#148699)
2024-05-21 [email protected] [wiki migration] Android team pages (flutter/flutter#148585)
2024-05-21 [email protected] Fix leaky test. (flutter/flutter#148788)
2024-05-21 [email protected] Add DropdownButton.menuWidth (flutter/flutter#148125)
2024-05-21 82763757 [email protected] Add test for focus example 2 (flutter/flutter#147624)
2024-05-21 34871572 [email protected] Add a migrator to remove `FlutterMultiDexApplication.java` (flutter/flutter#148515)
2024-05-21 [email protected] [wiki migration] Infra team pages (flutter/flutter#148718)
2024-05-21 [email protected] Roll Flutter Engine from 8a352f01e503 to a8872c8915a2 (1 revision) (flutter/flutter#148776)
2024-05-21 [email protected] Fix the output of the CDN test. (flutter/flutter#148730)
2024-05-21 [email protected] [wiki migration] Release team pages (flutter/flutter#148723)
2024-05-21 [email protected] Remove hidden dependencies on LocalProcessManager (flutter/flutter#148096)
2024-05-21 [email protected] Adds Missing `onHover` & `onFocusChange` for `OutlinedButton.icon` (flutter/flutter#144374)
2024-05-21 82763757 [email protected] Adds tests to NestedScrollView examples (flutter/flutter#148170)
2024-05-21 [email protected] Roll Flutter Engine from c2ef01f6f1ab to 8a352f01e503 (18 revisions) (flutter/flutter#148766)
2024-05-21 [email protected] `switch` expressions: finale (flutter/flutter#148711)
2024-05-21 [email protected] [iOS] specify minimum os version for native asset frameworks (flutter/flutter#148504)
2024-05-21 59215665 [email protected] Removed brand references from MenuAnchor.dart (flutter/flutter#148760)
2024-05-21 [email protected] Skip flaky test in expression_evaluation_test.dart (flutter/flutter#148737)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/ doc/main/autoroll/README.md
@Piinks Piinks mentioned this pull request May 31, 2024
Open
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request May 31, 2024
@ksokolovskyi @victorsanni
Add tests for actions.0.dart API example. (flutter#148678)
54085d4 
This PR contributes to flutter#130459

### Description
- Updates `examples/api/lib/widgets/actions/actions.0.dart` to meet the latest API examples structure
- Adds tests for `examples/api/lib/widgets/actions/actions.0.dart`
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
@engine-flutter-autoroll @arc-yong
Roll Flutter from d02292d to 73bf206 (31 revisions) (flutter#6780)
fc111a2 
flutter/flutter@d02292d...73bf206

2024-05-22 102401667 [email protected] `CupertinoDialogRoute` leak fix (flutter/flutter#148774)
2024-05-22 [email protected] Marks Windows plugin_test to be flaky (flutter/flutter#148835)
2024-05-22 [email protected] Add tests for actions.0.dart API example. (flutter/flutter#148678)
2024-05-22 [email protected] Introduce `WidgetStateBorderSide.lerp` (flutter/flutter#148122)
2024-05-22 [email protected] add `default-flavor` field to flutter pubspec, which will be used as the flavor in `flutter build/run` if `--flavor` is not provided (flutter/flutter#147968)
2024-05-22 [email protected] [wiki migration] Pages under docs/postmortems/ (flutter/flutter#148798)
2024-05-22 [email protected] Roll Flutter Engine from e5a73e520e89 to c89defa55801 (2 revisions) (flutter/flutter#148812)
2024-05-22 [email protected] Make hover tests functional and cleanup mouse pointers in Material toggleables (flutter/flutter#148808)
2024-05-21 [email protected] Fix two dimensional viewport unexpected null exception when no child is laid out (flutter/flutter#148256)
2024-05-21 [email protected] Roll Flutter Engine from bc1345b6b50a to e5a73e520e89 (3 revisions) (flutter/flutter#148807)
2024-05-21 32538273 [email protected] Add test for undo_history_controller.0.dart (flutter/flutter#148205)
2024-05-21 [email protected] Roll Flutter Engine from a8872c8915a2 to bc1345b6b50a (6 revisions) (flutter/flutter#148802)
2024-05-21 [email protected] Fix test that leaks images. (flutter/flutter#148494)
2024-05-21 34871572 [email protected] Fix warnings in `dependency_version_checker.gradle.kts` (flutter/flutter#148699)
2024-05-21 [email protected] [wiki migration] Android team pages (flutter/flutter#148585)
2024-05-21 [email protected] Fix leaky test. (flutter/flutter#148788)
2024-05-21 [email protected] Add DropdownButton.menuWidth (flutter/flutter#148125)
2024-05-21 82763757 [email protected] Add test for focus example 2 (flutter/flutter#147624)
2024-05-21 34871572 [email protected] Add a migrator to remove `FlutterMultiDexApplication.java` (flutter/flutter#148515)
2024-05-21 [email protected] [wiki migration] Infra team pages (flutter/flutter#148718)
2024-05-21 [email protected] Roll Flutter Engine from 8a352f01e503 to a8872c8915a2 (1 revision) (flutter/flutter#148776)
2024-05-21 [email protected] Fix the output of the CDN test. (flutter/flutter#148730)
2024-05-21 [email protected] [wiki migration] Release team pages (flutter/flutter#148723)
2024-05-21 [email protected] Remove hidden dependencies on LocalProcessManager (flutter/flutter#148096)
2024-05-21 [email protected] Adds Missing `onHover` & `onFocusChange` for `OutlinedButton.icon` (flutter/flutter#144374)
2024-05-21 82763757 [email protected] Adds tests to NestedScrollView examples (flutter/flutter#148170)
2024-05-21 [email protected] Roll Flutter Engine from c2ef01f6f1ab to 8a352f01e503 (18 revisions) (flutter/flutter#148766)
2024-05-21 [email protected] `switch` expressions: finale (flutter/flutter#148711)
2024-05-21 [email protected] [iOS] specify minimum os version for native asset frameworks (flutter/flutter#148504)
2024-05-21 59215665 [email protected] Removed brand references from MenuAnchor.dart (flutter/flutter#148760)
2024-05-21 [email protected] Skip flaky test in expression_evaluation_test.dart (flutter/flutter#148737)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/ doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024
@engine-flutter-autoroll
112e8b5 Add tests for actions.0.dart API example. (flutter/flutter#14…
de5e074 
…8678)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bleroux bleroux bleroux approved these changes

@TahaTesser TahaTesser TahaTesser approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ksokolovskyi @bleroux @TahaTesser