Add tests for shortcuts.dart API examples. #147433

ksokolovskyi · 2024-04-26T20:01:39Z

This PR contributes to #130459

Description

Adds tests for examples/api/lib/widgets/shortcuts/shortcuts.0.dart
Adds tests for examples/api/lib/widgets/shortcuts/shortcuts.1.dart

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

bleroux

LGTM! Thanks for the contribution.

examples/api/test/widgets/shortcuts/shortcuts.0_test.dart

examples/api/test/widgets/shortcuts/shortcuts.1_test.dart

examples/api/test/widgets/shortcuts/shortcuts.0_test.dart

ksokolovskyi · 2024-05-07T09:54:54Z

Hi @bleroux @TahaTesser thanks a lot for the review!

ksokolovskyi · 2024-05-07T10:24:18Z

@TahaTesser thanks for the replies and examples. I updated the tests according to your feedback. Could you please take a look again?

TahaTesser

LGTM! With updated titles

TahaTesser · 2024-05-07T10:32:00Z

examples/api/test/widgets/shortcuts/shortcuts.0_test.dart

+ expect(find.text('count: 0'), findsOneWidget);
+ });
+
+ testWidgets('updates counter on arrowUp and arrowDown press', (WidgetTester tester) async {


Suggested change

testWidgets('updates counter on arrowUp and arrowDown press', (WidgetTester tester) async {

testWidgets(' Up and down arrow press updates counter', (WidgetTester tester) async {

Similar title in other test

TahaTesser · 2024-05-07T10:33:29Z

examples/api/test/widgets/shortcuts/shortcuts.0_test.dart

+import 'package:flutter_test/flutter_test.dart';
+
+void main() {
+ testWidgets('displays correct labels', (WidgetTester tester) async {


Suggested change

testWidgets('displays correct labels', (WidgetTester tester) async {

testWidgets('Verify correct labels are displayed', (WidgetTester tester) async {

Similar title in other test

ksokolovskyi · 2024-05-07T13:56:55Z

@bleroux @TahaTesser thanks for the review!

…#147433)

flutter/flutter@04424e1...7920a52 2024-05-07 [email protected] Add tests for callback_shortcuts.0.dart API example. (flutter/flutter#147536) 2024-05-07 [email protected] Improve Android SDK and NDK mistmatch warning message (flutter/flutter#147809) 2024-05-07 [email protected] Add tests for shortcuts.dart API examples. (flutter/flutter#147433) 2024-05-07 [email protected] Added missing tests for ButtonStyle example (flutter/flutter#147457) 2024-05-07 [email protected] Roll Flutter Engine from ece1d686e3ba to 150f694a7816 (1 revision) (flutter/flutter#147912) 2024-05-07 [email protected] DropdownMenu cleanup (flutter/flutter#147860) 2024-05-07 [email protected] Roll Flutter Engine from 80470584e1e1 to ece1d686e3ba (1 revision) (flutter/flutter#147910) 2024-05-07 [email protected] Roll Flutter Engine from b7bfd94af743 to 80470584e1e1 (1 revision) (flutter/flutter#147906) 2024-05-07 [email protected] Roll Flutter Engine from b64e2300bcd0 to b7bfd94af743 (1 revision) (flutter/flutter#147905) 2024-05-07 [email protected] fix MenuItemButton if child is null (flutter/flutter#147485) 2024-05-07 [email protected] Fix document generation, eliminate template support from snippets tool. (flutter/flutter#147893) 2024-05-07 [email protected] Roll Flutter Engine from 4cb9e02c06ce to b64e2300bcd0 (1 revision) (flutter/flutter#147904) 2024-05-07 82763757 [email protected] test focus example 0 (flutter/flutter#147564) 2024-05-07 [email protected] Roll Flutter Engine from 422f92b992c5 to 4cb9e02c06ce (1 revision) (flutter/flutter#147899) 2024-05-06 137456488 [email protected] Roll pub packages (flutter/flutter#147896) 2024-05-06 [email protected] Roll Flutter Engine from 463ff7d2d4d5 to 422f92b992c5 (5 revisions) (flutter/flutter#147895) 2024-05-06 59215665 [email protected] MultiSelectableSelectionContainerDelegate documentation fixes. (flutter/flutter#147843) 2024-05-06 137456488 [email protected] Roll pub packages (flutter/flutter#147891) 2024-05-06 49699333 dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.4 to 4.1.5 (flutter/flutter#147888) 2024-05-06 32538273 [email protected] Fix janks and memory leaks in `CupertinoPageTransition` and `CupertinoFullscreenDialogTransition` (flutter/flutter#146999) 2024-05-06 [email protected] Roll Flutter Engine from 960a0c8fecbe to 463ff7d2d4d5 (1 revision) (flutter/flutter#147886) 2024-05-06 [email protected] Roll Flutter Engine from 70cc300f9ad8 to 960a0c8fecbe (1 revision) (flutter/flutter#147884) 2024-05-06 [email protected] [new gallery] Reisze gallery images (flutter/flutter#147882) 2024-05-06 [email protected] Roll Flutter Engine from d0f99b35eac6 to 70cc300f9ad8 (1 revision) (flutter/flutter#147880) 2024-05-06 [email protected] Fix leak in a test. (flutter/flutter#147846) 2024-05-06 [email protected] Roll Flutter Engine from a30ae7729c95 to d0f99b35eac6 (3 revisions) (flutter/flutter#147878) 2024-05-06 [email protected] Roll Packages from f4719ca to 2dfe645 (3 revisions) (flutter/flutter#147866) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/ doc/main/autoroll/README.md

…r#6683) flutter/flutter@04424e1...7920a52 2024-05-07 [email protected] Add tests for callback_shortcuts.0.dart API example. (flutter/flutter#147536) 2024-05-07 [email protected] Improve Android SDK and NDK mistmatch warning message (flutter/flutter#147809) 2024-05-07 [email protected] Add tests for shortcuts.dart API examples. (flutter/flutter#147433) 2024-05-07 [email protected] Added missing tests for ButtonStyle example (flutter/flutter#147457) 2024-05-07 [email protected] Roll Flutter Engine from ece1d686e3ba to 150f694a7816 (1 revision) (flutter/flutter#147912) 2024-05-07 [email protected] DropdownMenu cleanup (flutter/flutter#147860) 2024-05-07 [email protected] Roll Flutter Engine from 80470584e1e1 to ece1d686e3ba (1 revision) (flutter/flutter#147910) 2024-05-07 [email protected] Roll Flutter Engine from b7bfd94af743 to 80470584e1e1 (1 revision) (flutter/flutter#147906) 2024-05-07 [email protected] Roll Flutter Engine from b64e2300bcd0 to b7bfd94af743 (1 revision) (flutter/flutter#147905) 2024-05-07 [email protected] fix MenuItemButton if child is null (flutter/flutter#147485) 2024-05-07 [email protected] Fix document generation, eliminate template support from snippets tool. (flutter/flutter#147893) 2024-05-07 [email protected] Roll Flutter Engine from 4cb9e02c06ce to b64e2300bcd0 (1 revision) (flutter/flutter#147904) 2024-05-07 82763757 [email protected] test focus example 0 (flutter/flutter#147564) 2024-05-07 [email protected] Roll Flutter Engine from 422f92b992c5 to 4cb9e02c06ce (1 revision) (flutter/flutter#147899) 2024-05-06 137456488 [email protected] Roll pub packages (flutter/flutter#147896) 2024-05-06 [email protected] Roll Flutter Engine from 463ff7d2d4d5 to 422f92b992c5 (5 revisions) (flutter/flutter#147895) 2024-05-06 59215665 [email protected] MultiSelectableSelectionContainerDelegate documentation fixes. (flutter/flutter#147843) 2024-05-06 137456488 [email protected] Roll pub packages (flutter/flutter#147891) 2024-05-06 49699333 dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.4 to 4.1.5 (flutter/flutter#147888) 2024-05-06 32538273 [email protected] Fix janks and memory leaks in `CupertinoPageTransition` and `CupertinoFullscreenDialogTransition` (flutter/flutter#146999) 2024-05-06 [email protected] Roll Flutter Engine from 960a0c8fecbe to 463ff7d2d4d5 (1 revision) (flutter/flutter#147886) 2024-05-06 [email protected] Roll Flutter Engine from 70cc300f9ad8 to 960a0c8fecbe (1 revision) (flutter/flutter#147884) 2024-05-06 [email protected] [new gallery] Reisze gallery images (flutter/flutter#147882) 2024-05-06 [email protected] Roll Flutter Engine from d0f99b35eac6 to 70cc300f9ad8 (1 revision) (flutter/flutter#147880) 2024-05-06 [email protected] Fix leak in a test. (flutter/flutter#147846) 2024-05-06 [email protected] Roll Flutter Engine from a30ae7729c95 to d0f99b35eac6 (3 revisions) (flutter/flutter#147878) 2024-05-06 [email protected] Roll Packages from f4719ca to 2dfe645 (3 revisions) (flutter/flutter#147866) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/ doc/main/autoroll/README.md

…#147433)

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Apr 26, 2024

goderbauer requested a review from Piinks April 30, 2024 22:15

bleroux approved these changes May 3, 2024

View reviewed changes

ksokolovskyi force-pushed the add-shortcuts-example-tests branch 3 times, most recently from d371abf to 756a7d8 Compare May 5, 2024 08:56

Add tests for shortcuts.dart API examples.

f74e6a1

bleroux force-pushed the add-shortcuts-example-tests branch from 756a7d8 to f74e6a1 Compare May 7, 2024 07:55

bleroux requested a review from TahaTesser May 7, 2024 08:58

TahaTesser requested changes May 7, 2024

View reviewed changes

Remove groups. Update formatting.

e24b431

ksokolovskyi requested a review from TahaTesser May 7, 2024 10:27

TahaTesser approved these changes May 7, 2024

View reviewed changes

Update test names.

2dc919c

ksokolovskyi requested a review from TahaTesser May 7, 2024 10:37

TahaTesser approved these changes May 7, 2024

View reviewed changes

TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label May 7, 2024

auto-submit bot merged commit 28e65b7 into flutter:master May 7, 2024
137 checks passed

engine-flutter-autoroll mentioned this pull request May 7, 2024

Roll Flutter from 04424e10fe28 to 28e65b781105 (25 revisions) flutter/packages#6681

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2024

28e65b781 Add tests for shortcuts.dart API examples. (flutter/flutter…

f086a3c

…#147433)

engine-flutter-autoroll mentioned this pull request May 7, 2024

Roll Flutter from 04424e10fe28 to 7920a52dd568 (27 revisions) flutter/packages#6683

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2024

28e65b781 Add tests for shortcuts.dart API examples. (flutter/flutter…

8974a82

…#147433)

Piinks mentioned this pull request May 10, 2024

Flutter Framework Team: Notable Commits #121415

Open

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024

28e65b781 Add tests for shortcuts.dart API examples. (flutter/flutter…

c84fd6f

…#147433)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add tests for shortcuts.dart API examples. #147433

Add tests for shortcuts.dart API examples. #147433

ksokolovskyi commented Apr 26, 2024 •

edited

Loading

bleroux left a comment

ksokolovskyi commented May 7, 2024

ksokolovskyi commented May 7, 2024

TahaTesser left a comment

TahaTesser May 7, 2024

TahaTesser May 7, 2024

TahaTesser May 7, 2024

TahaTesser May 7, 2024

ksokolovskyi commented May 7, 2024

	testWidgets('updates counter on arrowUp and arrowDown press', (WidgetTester tester) async {
	testWidgets(' Up and down arrow press updates counter', (WidgetTester tester) async {

	testWidgets('displays correct labels', (WidgetTester tester) async {
	testWidgets('Verify correct labels are displayed', (WidgetTester tester) async {

Add tests for shortcuts.dart API examples. #147433

Add tests for shortcuts.dart API examples. #147433

Conversation

ksokolovskyi commented Apr 26, 2024 • edited Loading

Description

Pre-launch Checklist

bleroux left a comment

Choose a reason for hiding this comment

ksokolovskyi commented May 7, 2024

ksokolovskyi commented May 7, 2024

TahaTesser left a comment

Choose a reason for hiding this comment

TahaTesser May 7, 2024

Choose a reason for hiding this comment

TahaTesser May 7, 2024

Choose a reason for hiding this comment

TahaTesser May 7, 2024

Choose a reason for hiding this comment

TahaTesser May 7, 2024

Choose a reason for hiding this comment

ksokolovskyi commented May 7, 2024

ksokolovskyi commented Apr 26, 2024 •

edited

Loading