-
Notifications
You must be signed in to change notification settings - Fork 27.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for single_activator.0.dart API example. #147426
Merged
auto-submit
merged 1 commit into
flutter:master
from
ksokolovskyi:add-single-activator-example-tests
May 1, 2024
Merged
Add tests for single_activator.0.dart API example. #147426
auto-submit
merged 1 commit into
flutter:master
from
ksokolovskyi:add-single-activator-example-tests
May 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
flutter/packages/flutter repository. See also f: labels.
d: api docs
Issues with https://api.flutter.dev/
d: examples
Sample code and demos
labels
Apr 26, 2024
Renzo-Olivares
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for adding these tests!
goderbauer
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
goderbauer
added
the
autosubmit
Merge PR when tree becomes green via auto submit App
label
Apr 30, 2024
@Renzo-Olivares @goderbauer thanks for the review! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 1, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
May 1, 2024
flutter/flutter@b597dd2...d33bb8f 2024-05-01 [email protected] Add tests for single_activator.0.dart API example. (flutter/flutter#147426) 2024-05-01 [email protected] Added missing code block language in docs (flutter/flutter#147481) 2024-05-01 [email protected] Move docs_test and docs_publish to bringup (flutter/flutter#147645) 2024-05-01 98614782 auto-submit[bot]@users.noreply.github.com Reverts "Fix memory leak in `TabPageSelector` (#147403)" (flutter/flutter#147622) 2024-04-30 47866232 [email protected] Revert "add a new PopScope.onPopWithResultInvoke widget to replace Po� (flutter/flutter#147597) 2024-04-30 [email protected] include exception details in tool exit displayed when adb call fails (flutter/flutter#147498) 2024-04-30 32538273 [email protected] Fix memory leak in `TabPageSelector` (flutter/flutter#147403) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/ doc/main/autoroll/README.md
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
flutter/flutter@b597dd2...d33bb8f 2024-05-01 [email protected] Add tests for single_activator.0.dart API example. (flutter/flutter#147426) 2024-05-01 [email protected] Added missing code block language in docs (flutter/flutter#147481) 2024-05-01 [email protected] Move docs_test and docs_publish to bringup (flutter/flutter#147645) 2024-05-01 98614782 auto-submit[bot]@users.noreply.github.com Reverts "Fix memory leak in `TabPageSelector` (#147403)" (flutter/flutter#147622) 2024-04-30 47866232 [email protected] Revert "add a new PopScope.onPopWithResultInvoke widget to replace Po� (flutter/flutter#147597) 2024-04-30 [email protected] include exception details in tool exit displayed when adb call fails (flutter/flutter#147498) 2024-04-30 32538273 [email protected] Fix memory leak in `TabPageSelector` (flutter/flutter#147403) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/ doc/main/autoroll/README.md
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
flutter/flutter@b597dd2...d33bb8f 2024-05-01 [email protected] Add tests for single_activator.0.dart API example. (flutter/flutter#147426) 2024-05-01 [email protected] Added missing code block language in docs (flutter/flutter#147481) 2024-05-01 [email protected] Move docs_test and docs_publish to bringup (flutter/flutter#147645) 2024-05-01 98614782 auto-submit[bot]@users.noreply.github.com Reverts "Fix memory leak in `TabPageSelector` (#147403)" (flutter/flutter#147622) 2024-04-30 47866232 [email protected] Revert "add a new PopScope.onPopWithResultInvoke widget to replace Po� (flutter/flutter#147597) 2024-04-30 [email protected] include exception details in tool exit displayed when adb call fails (flutter/flutter#147498) 2024-04-30 32538273 [email protected] Fix memory leak in `TabPageSelector` (flutter/flutter#147403) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/ doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
autosubmit
Merge PR when tree becomes green via auto submit App
d: api docs
Issues with https://api.flutter.dev/
d: examples
Sample code and demos
framework
flutter/packages/flutter repository. See also f: labels.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contributes to #130459
Description
examples/api/lib/widgets/shortcuts/single_activator.single_activator.0.dart
examples/api/lib/widgets/shortcuts/single_activator.0.dart
Pre-launch Checklist
///
).