Add tests for material_state_mouse_cursor.0.dart API example. #145987

ksokolovskyi · 2024-03-29T16:03:37Z

This PR contributes to #130459

Description

Updates examples/api/lib/material/material_state/material_state_mouse_cursor.0.dart to allow enable/disable ListTile in tests;
Adds tests for examples/api/lib/material/material_state/material_state_mouse_cursor.0.dart.

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

This reverts commit dbe2269.

Renzo-Olivares

LGTM with small nits, thanks for adding this test!

examples/api/test/material/material_state/material_state_mouse_cursor.0_test.dart

Renzo-Olivares

LGTM, thank you for your contribution!

ksokolovskyi · 2024-03-29T18:21:42Z

@Renzo-Olivares thanks for the review!

gspencergoog

examples/api/lib/material/material_state/material_state_mouse_cursor.0.dart

…tate_mouse_cursor.0.dart Co-authored-by: Greg Spencer <[email protected]>

…flutter/flutter#145987)

Roll Flutter from a418568 to e868e2b (34 revisions) flutter/flutter@a418568...e868e2b 2024-04-03 65075121 [email protected] Add SegmentedButton expand feature (flutter/flutter#142804) 2024-04-03 [email protected] Roll Flutter Engine from e36b9b10c36f to 56fa2c33a5f7 (1 revision) (flutter/flutter#146205) 2024-04-03 [email protected] Roll Packages from 83f3842 to 0e848fa (3 revisions) (flutter/flutter#146201) 2024-04-03 [email protected] Enhance ColorScheme.fromSeed with a new `variant` parameter (flutter/flutter#144805) 2024-04-03 [email protected] Roll Flutter Engine from 0280de5be276 to e36b9b10c36f (1 revision) (flutter/flutter#146200) 2024-04-03 [email protected] Fix typos in bottom_sheet.dart (flutter/flutter#146188) 2024-04-03 [email protected] Roll Flutter Engine from 979030d81f8d to 0280de5be276 (2 revisions) (flutter/flutter#146199) 2024-04-03 [email protected] Roll Flutter Engine from bef3bbe3f74e to 979030d81f8d (1 revision) (flutter/flutter#146186) 2024-04-03 [email protected] Roll Flutter Engine from 5fc83bc24b2e to bef3bbe3f74e (1 revision) (flutter/flutter#146183) 2024-04-03 [email protected] Roll Flutter Engine from 0da1b2eb370a to 5fc83bc24b2e (1 revision) (flutter/flutter#146180) 2024-04-03 31859944 [email protected] Avoid calling `TextPainter.plainText` for simple static text (flutter/flutter#146084) 2024-04-03 [email protected] Roll Flutter Engine from e603f89844a9 to 0da1b2eb370a (2 revisions) (flutter/flutter#146179) 2024-04-03 [email protected] Roll Flutter Engine from ef60a95d78c1 to e603f89844a9 (3 revisions) (flutter/flutter#146177) 2024-04-03 31859944 [email protected] Fix chip baseline implementation (flutter/flutter#146162) 2024-04-03 [email protected] Roll Flutter Engine from bb4ec2d7eb39 to ef60a95d78c1 (1 revision) (flutter/flutter#146176) 2024-04-03 [email protected] Add tests for material_state_mouse_cursor.0.dart API example. (flutter/flutter#145987) 2024-04-03 36861262 [email protected] Update material_color_utilities package version to latest 0.11.1 (flutter/flutter#145959) 2024-04-03 [email protected] Roll Flutter Engine from 5f6dec8bd877 to bb4ec2d7eb39 (4 revisions) (flutter/flutter#146169) 2024-04-03 [email protected] Roll Flutter Engine from 5dbcfdc2a456 to 5f6dec8bd877 (1 revision) (flutter/flutter#146163) 2024-04-02 [email protected] Dispose FocusNode in tests. (flutter/flutter#146161) 2024-04-02 [email protected] Add `none` language strings to code blocks. (flutter/flutter#146154) 2024-04-02 103135467 [email protected] Refactor docs (flutter/flutter#145998) 2024-04-02 [email protected] Roll Flutter Engine from c60b00a20fc3 to 5dbcfdc2a456 (3 revisions) (flutter/flutter#146159) 2024-04-02 [email protected] Marks Linux_pixel_7pro complex_layout_scroll_perf_impeller__timeline_summary to be unflaky (flutter/flutter#140038) 2024-04-02 [email protected] Roll Flutter Engine from 5bf8b94505a4 to c60b00a20fc3 (2 revisions) (flutter/flutter#146157) 2024-04-02 103135467 [email protected] Refactor analyze (flutter/flutter#146138) 2024-04-02 [email protected] Implement SelectionArea triple click gestures (flutter/flutter#144563) 2024-04-02 [email protected] Roll Flutter Engine from 6883f7313da0 to 5bf8b94505a4 (2 revisions) (flutter/flutter#146152) 2024-04-02 [email protected] Fix border color is wrong for a focused and hovered TextField (flutter/flutter#146127) 2024-04-02 [email protected] Sync lints and enable `annotate_redeclares` (flutter/flutter#146144) 2024-04-02 31859944 [email protected] Implements `RenderBox.computeDryBaseline` for material render boxes (flutter/flutter#146027) 2024-04-02 [email protected] Roll Flutter Engine from 523fc953ebc8 to 6883f7313da0 (2 revisions) (flutter/flutter#146140) 2024-04-02 [email protected] Fix `MenuItemButton` overflow (flutter/flutter#143932) 2024-04-02 [email protected] Roll Packages from d5aff19 to 83f3842 (4 revisions) (flutter/flutter#146134) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 ...

ksokolovskyi · 2024-04-04T06:49:35Z

@Renzo-Olivares @gspencergoog thanks for the review!

Roll Flutter from a418568 to e868e2b (34 revisions) flutter/flutter@a418568...e868e2b 2024-04-03 65075121 [email protected] Add SegmentedButton expand feature (flutter/flutter#142804) 2024-04-03 [email protected] Roll Flutter Engine from e36b9b10c36f to 56fa2c33a5f7 (1 revision) (flutter/flutter#146205) 2024-04-03 [email protected] Roll Packages from 83f3842 to 0e848fa (3 revisions) (flutter/flutter#146201) 2024-04-03 [email protected] Enhance ColorScheme.fromSeed with a new `variant` parameter (flutter/flutter#144805) 2024-04-03 [email protected] Roll Flutter Engine from 0280de5be276 to e36b9b10c36f (1 revision) (flutter/flutter#146200) 2024-04-03 [email protected] Fix typos in bottom_sheet.dart (flutter/flutter#146188) 2024-04-03 [email protected] Roll Flutter Engine from 979030d81f8d to 0280de5be276 (2 revisions) (flutter/flutter#146199) 2024-04-03 [email protected] Roll Flutter Engine from bef3bbe3f74e to 979030d81f8d (1 revision) (flutter/flutter#146186) 2024-04-03 [email protected] Roll Flutter Engine from 5fc83bc24b2e to bef3bbe3f74e (1 revision) (flutter/flutter#146183) 2024-04-03 [email protected] Roll Flutter Engine from 0da1b2eb370a to 5fc83bc24b2e (1 revision) (flutter/flutter#146180) 2024-04-03 31859944 [email protected] Avoid calling `TextPainter.plainText` for simple static text (flutter/flutter#146084) 2024-04-03 [email protected] Roll Flutter Engine from e603f89844a9 to 0da1b2eb370a (2 revisions) (flutter/flutter#146179) 2024-04-03 [email protected] Roll Flutter Engine from ef60a95d78c1 to e603f89844a9 (3 revisions) (flutter/flutter#146177) 2024-04-03 31859944 [email protected] Fix chip baseline implementation (flutter/flutter#146162) 2024-04-03 [email protected] Roll Flutter Engine from bb4ec2d7eb39 to ef60a95d78c1 (1 revision) (flutter/flutter#146176) 2024-04-03 [email protected] Add tests for material_state_mouse_cursor.0.dart API example. (flutter/flutter#145987) 2024-04-03 36861262 [email protected] Update material_color_utilities package version to latest 0.11.1 (flutter/flutter#145959) 2024-04-03 [email protected] Roll Flutter Engine from 5f6dec8bd877 to bb4ec2d7eb39 (4 revisions) (flutter/flutter#146169) 2024-04-03 [email protected] Roll Flutter Engine from 5dbcfdc2a456 to 5f6dec8bd877 (1 revision) (flutter/flutter#146163) 2024-04-02 [email protected] Dispose FocusNode in tests. (flutter/flutter#146161) 2024-04-02 [email protected] Add `none` language strings to code blocks. (flutter/flutter#146154) 2024-04-02 103135467 [email protected] Refactor docs (flutter/flutter#145998) 2024-04-02 [email protected] Roll Flutter Engine from c60b00a20fc3 to 5dbcfdc2a456 (3 revisions) (flutter/flutter#146159) 2024-04-02 [email protected] Marks Linux_pixel_7pro complex_layout_scroll_perf_impeller__timeline_summary to be unflaky (flutter/flutter#140038) 2024-04-02 [email protected] Roll Flutter Engine from 5bf8b94505a4 to c60b00a20fc3 (2 revisions) (flutter/flutter#146157) 2024-04-02 103135467 [email protected] Refactor analyze (flutter/flutter#146138) 2024-04-02 [email protected] Implement SelectionArea triple click gestures (flutter/flutter#144563) 2024-04-02 [email protected] Roll Flutter Engine from 6883f7313da0 to 5bf8b94505a4 (2 revisions) (flutter/flutter#146152) 2024-04-02 [email protected] Fix border color is wrong for a focused and hovered TextField (flutter/flutter#146127) 2024-04-02 [email protected] Sync lints and enable `annotate_redeclares` (flutter/flutter#146144) 2024-04-02 31859944 [email protected] Implements `RenderBox.computeDryBaseline` for material render boxes (flutter/flutter#146027) 2024-04-02 [email protected] Roll Flutter Engine from 523fc953ebc8 to 6883f7313da0 (2 revisions) (flutter/flutter#146140) 2024-04-02 [email protected] Fix `MenuItemButton` overflow (flutter/flutter#143932) 2024-04-02 [email protected] Roll Packages from d5aff19 to 83f3842 (4 revisions) (flutter/flutter#146134) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 ...

Add tests for material_state_mouse_cursor.0.dart API example.

711255b

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Mar 29, 2024

ksokolovskyi added 3 commits March 29, 2024 17:22

Update _knownMissingTests

dbe2269

Revert "Update _knownMissingTests"

c1723d6

This reverts commit dbe2269.

Update _knownMissingTests

0d657b9

Renzo-Olivares approved these changes Mar 29, 2024

View reviewed changes

Renzo-Olivares reviewed Mar 29, 2024

View reviewed changes

examples/api/test/material/material_state/material_state_mouse_cursor.0_test.dart Show resolved Hide resolved

Renzo-Olivares reviewed Mar 29, 2024

View reviewed changes

examples/api/test/material/material_state/material_state_mouse_cursor.0_test.dart Show resolved Hide resolved

Add teardowns in tests

2b8e5e2

ksokolovskyi requested a review from Renzo-Olivares March 29, 2024 18:14

Renzo-Olivares approved these changes Mar 29, 2024

View reviewed changes

Merge branch 'master' into add-material-state-mouse-cursor-example-tests

26727ed

gspencergoog approved these changes Apr 1, 2024

View reviewed changes

examples/api/lib/material/material_state/material_state_mouse_cursor.0.dart Outdated Show resolved Hide resolved

ksokolovskyi and others added 3 commits April 2, 2024 18:35

Update comment in examples/api/lib/material/material_state/material_s…

f907ef6

…tate_mouse_cursor.0.dart Co-authored-by: Greg Spencer <[email protected]>

Merge branch 'master' into add-material-state-mouse-cursor-example-tests

ed6e01d

Merge branch 'master' into add-material-state-mouse-cursor-example-tests

1cec7a6

gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 3, 2024

auto-submit bot merged commit e6f078f into flutter:master Apr 3, 2024
132 checks passed

engine-flutter-autoroll mentioned this pull request Apr 3, 2024

Roll Flutter from a418568a6498 to bd4c17155d02 (28 revisions) flutter/packages#6452

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2024

e6f078f Add tests for material_state_mouse_cursor.0.dart API example. (…

97f7e77

…flutter/flutter#145987)

engine-flutter-autoroll mentioned this pull request Apr 3, 2024

Roll Flutter from a418568a6498 to 1326c8ee536e (29 revisions) flutter/packages#6454

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2024

e6f078f Add tests for material_state_mouse_cursor.0.dart API example. (…

c6c93a9

…flutter/flutter#145987)

engine-flutter-autoroll mentioned this pull request Apr 3, 2024

Roll Flutter from a418568a6498 to e868e2b3834f (34 revisions) flutter/packages#6455

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2024

e6f078f Add tests for material_state_mouse_cursor.0.dart API example. (…

1aa9560

…flutter/flutter#145987)

HansMuller mentioned this pull request Apr 5, 2024

Flutter Framework Team: Notable Commits #121415

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add tests for material_state_mouse_cursor.0.dart API example. #145987

Add tests for material_state_mouse_cursor.0.dart API example. #145987

ksokolovskyi commented Mar 29, 2024

Renzo-Olivares left a comment •

edited

Loading

Renzo-Olivares left a comment

ksokolovskyi commented Mar 29, 2024

gspencergoog left a comment

ksokolovskyi commented Apr 4, 2024

Add tests for material_state_mouse_cursor.0.dart API example. #145987

Add tests for material_state_mouse_cursor.0.dart API example. #145987

Conversation

ksokolovskyi commented Mar 29, 2024

Description

Pre-launch Checklist

Renzo-Olivares left a comment • edited Loading

Choose a reason for hiding this comment

Renzo-Olivares left a comment

Choose a reason for hiding this comment

ksokolovskyi commented Mar 29, 2024

gspencergoog left a comment

Choose a reason for hiding this comment

ksokolovskyi commented Apr 4, 2024

Renzo-Olivares left a comment •

edited

Loading