Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover more test/widgets tests with leak tracking #7 #134943

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Cover more test/widgets tests with leak tracking #7 #134943

merged 1 commit into from
Sep 20, 2023

Conversation

ksokolovskyi
Copy link
Contributor

Description

This PR changes testWidgets by testWidgetsWithLeakTracking in number of flutter/test/widgets tests according to the dart-lang/leak_tracker#134.

Tests

  • Updates pop_scope_test.dart to use testWidgetsWithLeakTracking;
  • Updates positioned_test.dart to use testWidgetsWithLeakTracking;
  • Updates range_maintaining_scroll_physics_test.dart to use testWidgetsWithLeakTracking;
  • Updates raw_keyboard_listener_test.dart to use testWidgetsWithLeakTracking;
  • Updates reassemble_test.dart to use testWidgetsWithLeakTracking;
  • Updates render_object_element_test.dart to use testWidgetsWithLeakTracking;
  • Updates render_object_widget_test.dart to use testWidgetsWithLeakTracking;
  • Updates reorderable_list_test.dart to use testWidgetsWithLeakTracking;
  • Updates reparent_state_harder_test.dart to use testWidgetsWithLeakTracking;
  • Updates reparent_state_test.dart to use testWidgetsWithLeakTracking;
  • Updates reparent_state_with_layout_builder_test.dart to use testWidgetsWithLeakTracking;
  • Updates restorable_property_test.dart to use testWidgetsWithLeakTracking;
  • Updates restoration_mixin_test.dart to use testWidgetsWithLeakTracking;
  • Updates restoration_scope_test.dart to use testWidgetsWithLeakTracking;
  • Updates restoration_scopes_moving_test.dart to use testWidgetsWithLeakTracking;
  • Updates rich_text_test.dart to use testWidgetsWithLeakTracking;
  • Updates root_restoration_scope_test.dart to use testWidgetsWithLeakTracking;
  • Updates rotated_box_test.dart to use testWidgetsWithLeakTracking;
  • Updates route_notification_messages_test.dart to use testWidgetsWithLeakTracking;
  • Updates routes_test.dart to use testWidgetsWithLeakTracking;
  • Updates row_test.dart to use testWidgetsWithLeakTracking;
  • Updates rtl_test.dart to use testWidgetsWithLeakTracking;
  • Updates run_app_test.dart to use testWidgetsWithLeakTracking;
  • Updates safe_area_test.dart to use testWidgetsWithLeakTracking;
  • Updates scroll_activity_test.dart to use testWidgetsWithLeakTracking;
  • Updates scroll_aware_image_provider_test.dart to use testWidgetsWithLeakTracking;
  • Updates scroll_behavior_test.dart to use testWidgetsWithLeakTracking;
  • Updates scroll_controller_test.dart to use testWidgetsWithLeakTracking;
  • Updates scroll_events_test.dart to use testWidgetsWithLeakTracking.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. f: routes Navigator, Router, and related APIs. labels Sep 18, 2023
@ksokolovskyi
Copy link
Contributor Author

cc @polina-c

@polina-c polina-c added the a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker label Sep 20, 2023
@polina-c polina-c merged commit e6d160a into flutter:master Sep 20, 2023
67 checks passed
@ksokolovskyi
Copy link
Contributor Author

@polina-c thanks for the review!

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2023
@engine-flutter-autoroll
e6d160a Cover more test/widgets tests with leak tracking flutter#7 (f…
c1142f2 
…lutter/flutter#134943)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2023
@engine-flutter-autoroll
e6d160a Cover more test/widgets tests with leak tracking flutter#7 (f…
dfbcb61 
…lutter/flutter#134943)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2023
@engine-flutter-autoroll
e6d160a Cover more test/widgets tests with leak tracking flutter#7 (f…
8243a68 
…lutter/flutter#134943)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2023
@engine-flutter-autoroll
e6d160a Cover more test/widgets tests with leak tracking flutter#7 (f…
a7d56b5 
…lutter/flutter#134943)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2023
@engine-flutter-autoroll
e6d160a Cover more test/widgets tests with leak tracking flutter#7 (f…
b501680 
…lutter/flutter#134943)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2023
@engine-flutter-autoroll
e6d160a Cover more test/widgets tests with leak tracking flutter#7 (f…
abebaa4 
…lutter/flutter#134943)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2023
@engine-flutter-autoroll
e6d160a Cover more test/widgets tests with leak tracking flutter#7 (f…
c358f3c 
…lutter/flutter#134943)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2023
@engine-flutter-autoroll
e6d160a Cover more test/widgets tests with leak tracking flutter#7 (f…
6d9307e 
…lutter/flutter#134943)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2023
@engine-flutter-autoroll
e6d160a Cover more test/widgets tests with leak tracking flutter#7 (f…
d2bc187 
…lutter/flutter#134943)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2023
@engine-flutter-autoroll
e6d160a Cover more test/widgets tests with leak tracking flutter#7 (f…
f7d27ba 
…lutter/flutter#134943)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
e6d160a Cover more test/widgets tests with leak tracking flutter#7 (f…
6602a88 
…lutter/flutter#134943)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
e6d160a Cover more test/widgets tests with leak tracking flutter#7 (f…
e11f89b 
…lutter/flutter#134943)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
e6d160a Cover more test/widgets tests with leak tracking flutter#7 (f…
e8af271 
…lutter/flutter#134943)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
e6d160a Cover more test/widgets tests with leak tracking flutter#7 (f…
1883896 
…lutter/flutter#134943)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
e6d160a Cover more test/widgets tests with leak tracking flutter#7 (f…
1ab5e9b 
…lutter/flutter#134943)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
e6d160a Cover more test/widgets tests with leak tracking flutter#7 (f…
837f242 
…lutter/flutter#134943)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Sep 23, 2023
@engine-flutter-autoroll
Manual roll Flutter from 8936504 to f92884c (48 revisions) (#4985)
4becde9 
Manual roll Flutter from 8936504 to f92884c (48 revisions)

Manual roll requested by [email protected]

flutter/flutter@8936504...f92884c

2023-09-21 [email protected] Rename `debugProfilePlatformChannels` to a constant that works in release mode (flutter/flutter#134922)
2023-09-20 82763757 [email protected] Mark ReastaurationManager not disposed (flutter/flutter#134832)
2023-09-20 82763757 [email protected] cover more tests with leak tracing (flutter/flutter#134834)
2023-09-20 82763757 [email protected] Fix leak in hardware_keyboard_test.dart (flutter/flutter#134380)
2023-09-20 [email protected] Fix memory leak in _SelectableTextState (flutter/flutter#135049)
2023-09-20 [email protected] Roll Flutter Engine from 39c0f2ea1f53 to 89d864552acd (4 revisions) (flutter/flutter#135169)
2023-09-20 [email protected] [deps] Update package:web dependency. (flutter/flutter#135174)
2023-09-20 [email protected] finer grained logging of Chromium launch sequence (flutter/flutter#135078)
2023-09-20 34871572 [email protected] Upgrade AGP version in tracing_tests (flutter/flutter#134671)
2023-09-20 82763757 [email protected] Cover cupertino/form_section_test with leak tracing (flutter/flutter#135158)
2023-09-20 [email protected] Cover more test/widgets tests with leak tracking #7 (flutter/flutter#134943)
2023-09-20 [email protected] Enable strict-inference (flutter/flutter#135043)
2023-09-20 [email protected] Cover more test/widgets tests with leak tracking #10 (flutter/flutter#135143)
2023-09-20 82763757 [email protected] cover more tests with leak tracing (flutter/flutter#134833)
2023-09-20 [email protected] codeisn extension safe iOS framework (flutter/flutter#134966)
2023-09-20 [email protected] Roll Flutter Engine from 6f256257b79f to 55314d08d792 (2 revisions) (flutter/flutter#135151)
2023-09-20 [email protected] Remove 'must be non-null' and 'must not be null' comments in widgets library (flutter/flutter#134992)
2023-09-20 [email protected] Roll Flutter Engine from 5f82fc2f6f24 to 6f256257b79f (1 revision) (flutter/flutter#135147)
2023-09-20 43054281 [email protected] [Android] Add Java/AGP/Gradle incompatibility warning to `flutter create` (flutter/flutter#131444)
2023-09-20 [email protected] Roll Packages from d4e2454 to 51e74b9 (12 revisions) (flutter/flutter#135145)
2023-09-20 [email protected] Remove 'must not be null' comments from various libraries. (flutter/flutter#134984)
2023-09-20 [email protected] Roll Flutter Engine from 6535421b30d3 to 5f82fc2f6f24 (2 revisions) (flutter/flutter#135142)
2023-09-20 [email protected] Roll Flutter Engine from 67d4aaef3c7b to 6535421b30d3 (1 revision) (flutter/flutter#135139)
2023-09-20 [email protected] Cover more test/widgets tests with leak tracking #8 (flutter/flutter#135045)
2023-09-20 [email protected] Cover more test/widgets tests with leak tracking #9 (flutter/flutter#135054)
2023-09-20 [email protected] Roll Flutter Engine from 83b4df415bf3 to 67d4aaef3c7b (1 revision) (flutter/flutter#135128)
2023-09-20 [email protected] Roll Flutter Engine from df4e6c079682 to 83b4df415bf3 (2 revisions) (flutter/flutter#135102)
2023-09-20 [email protected] Roll Flutter Engine from 9c6b2500282b to df4e6c079682 (1 revision) (flutter/flutter#135101)
2023-09-20 [email protected] Roll Flutter Engine from 24f7ac38dfa2 to 9c6b2500282b (3 revisions) (flutter/flutter#135098)
2023-09-20 [email protected] Roll Flutter Engine from 36379b62bec8 to 24f7ac38dfa2 (2 revisions) (flutter/flutter#135096)
2023-09-20 [email protected] Roll Flutter Engine from 81b93fc4a2cc to 36379b62bec8 (2 revisions) (flutter/flutter#135095)
2023-09-20 [email protected] Roll Flutter Engine from 5a924a9017d7 to 81b93fc4a2cc (2 revisions) (flutter/flutter#135093)
2023-09-20 [email protected] Remove 'must be non-null' and 'must not be null' comments from material. (flutter/flutter#134991)
2023-09-20 34871572 [email protected] Unpin url launcher (remake) (flutter/flutter#134958)
2023-09-20 [email protected] Roll Flutter Engine from a7af55c56aa6 to 5a924a9017d7 (10 revisions) (flutter/flutter#135085)
2023-09-20 [email protected] Manual roll Flutter Engine from a7af55c56aa6 to 0d7db40c27fd (7 revisions) (flutter/flutter#135079)
2023-09-20 [email protected] Remove 'must not be null' comments from painting and rendering libraries. (flutter/flutter#134993)
2023-09-20 82763757 [email protected] cover more tests with leak tracking (flutter/flutter#134837)
2023-09-20 [email protected] [flutter roll] Revert "Native assets support for Linux" (flutter/flutter#135069)
2023-09-20 [email protected] Manual roll Flutter Engine from 10c480310926 to a7af55c56aa6 (4 revisions) (flutter/flutter#135071)
2023-09-19 [email protected] Retry Linux web tests 1 time on roll presubmit (flutter/flutter#135073)
2023-09-19 [email protected] [web] Encode AssetManifest.bin as JSON and use that on the web. (flutter/flutter#131382)
2023-09-19 [email protected] Specify suggested format in doc comment. (flutter/flutter#134887)
2023-09-19 [email protected] Manual roll Flutter Engine from 28f14e6eec4f to 10c480310926 (6 revisions) (flutter/flutter#135066)
...
@HansMuller HansMuller mentioned this pull request Sep 28, 2023
Open
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@ksokolovskyi @Mairramer
Cover more test/widgets tests with leak tracking flutter#7 (flutter#1…
72d0694 
…34943)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
e6d160a Cover more test/widgets tests with leak tracking flutter#7 (f…
6623621 
…lutter/flutter#134943)
HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023
@engine-flutter-autoroll @HugoOlthof
Manual roll Flutter from 8936504 to f92884c (48 revisions) (flutter#4985
c20a4c8 
)

Manual roll Flutter from 8936504 to f92884c (48 revisions)

Manual roll requested by [email protected]

flutter/flutter@8936504...f92884c

2023-09-21 [email protected] Rename `debugProfilePlatformChannels` to a constant that works in release mode (flutter/flutter#134922)
2023-09-20 82763757 [email protected] Mark ReastaurationManager not disposed (flutter/flutter#134832)
2023-09-20 82763757 [email protected] cover more tests with leak tracing (flutter/flutter#134834)
2023-09-20 82763757 [email protected] Fix leak in hardware_keyboard_test.dart (flutter/flutter#134380)
2023-09-20 [email protected] Fix memory leak in _SelectableTextState (flutter/flutter#135049)
2023-09-20 [email protected] Roll Flutter Engine from 39c0f2ea1f53 to 89d864552acd (4 revisions) (flutter/flutter#135169)
2023-09-20 [email protected] [deps] Update package:web dependency. (flutter/flutter#135174)
2023-09-20 [email protected] finer grained logging of Chromium launch sequence (flutter/flutter#135078)
2023-09-20 34871572 [email protected] Upgrade AGP version in tracing_tests (flutter/flutter#134671)
2023-09-20 82763757 [email protected] Cover cupertino/form_section_test with leak tracing (flutter/flutter#135158)
2023-09-20 [email protected] Cover more test/widgets tests with leak tracking flutter#7 (flutter/flutter#134943)
2023-09-20 [email protected] Enable strict-inference (flutter/flutter#135043)
2023-09-20 [email protected] Cover more test/widgets tests with leak tracking flutter#10 (flutter/flutter#135143)
2023-09-20 82763757 [email protected] cover more tests with leak tracing (flutter/flutter#134833)
2023-09-20 [email protected] codeisn extension safe iOS framework (flutter/flutter#134966)
2023-09-20 [email protected] Roll Flutter Engine from 6f256257b79f to 55314d08d792 (2 revisions) (flutter/flutter#135151)
2023-09-20 [email protected] Remove 'must be non-null' and 'must not be null' comments in widgets library (flutter/flutter#134992)
2023-09-20 [email protected] Roll Flutter Engine from 5f82fc2f6f24 to 6f256257b79f (1 revision) (flutter/flutter#135147)
2023-09-20 43054281 [email protected] [Android] Add Java/AGP/Gradle incompatibility warning to `flutter create` (flutter/flutter#131444)
2023-09-20 [email protected] Roll Packages from d4e2454 to 51e74b9 (12 revisions) (flutter/flutter#135145)
2023-09-20 [email protected] Remove 'must not be null' comments from various libraries. (flutter/flutter#134984)
2023-09-20 [email protected] Roll Flutter Engine from 6535421b30d3 to 5f82fc2f6f24 (2 revisions) (flutter/flutter#135142)
2023-09-20 [email protected] Roll Flutter Engine from 67d4aaef3c7b to 6535421b30d3 (1 revision) (flutter/flutter#135139)
2023-09-20 [email protected] Cover more test/widgets tests with leak tracking flutter#8 (flutter/flutter#135045)
2023-09-20 [email protected] Cover more test/widgets tests with leak tracking flutter#9 (flutter/flutter#135054)
2023-09-20 [email protected] Roll Flutter Engine from 83b4df415bf3 to 67d4aaef3c7b (1 revision) (flutter/flutter#135128)
2023-09-20 [email protected] Roll Flutter Engine from df4e6c079682 to 83b4df415bf3 (2 revisions) (flutter/flutter#135102)
2023-09-20 [email protected] Roll Flutter Engine from 9c6b2500282b to df4e6c079682 (1 revision) (flutter/flutter#135101)
2023-09-20 [email protected] Roll Flutter Engine from 24f7ac38dfa2 to 9c6b2500282b (3 revisions) (flutter/flutter#135098)
2023-09-20 [email protected] Roll Flutter Engine from 36379b62bec8 to 24f7ac38dfa2 (2 revisions) (flutter/flutter#135096)
2023-09-20 [email protected] Roll Flutter Engine from 81b93fc4a2cc to 36379b62bec8 (2 revisions) (flutter/flutter#135095)
2023-09-20 [email protected] Roll Flutter Engine from 5a924a9017d7 to 81b93fc4a2cc (2 revisions) (flutter/flutter#135093)
2023-09-20 [email protected] Remove 'must be non-null' and 'must not be null' comments from material. (flutter/flutter#134991)
2023-09-20 34871572 [email protected] Unpin url launcher (remake) (flutter/flutter#134958)
2023-09-20 [email protected] Roll Flutter Engine from a7af55c56aa6 to 5a924a9017d7 (10 revisions) (flutter/flutter#135085)
2023-09-20 [email protected] Manual roll Flutter Engine from a7af55c56aa6 to 0d7db40c27fd (7 revisions) (flutter/flutter#135079)
2023-09-20 [email protected] Remove 'must not be null' comments from painting and rendering libraries. (flutter/flutter#134993)
2023-09-20 82763757 [email protected] cover more tests with leak tracking (flutter/flutter#134837)
2023-09-20 [email protected] [flutter roll] Revert "Native assets support for Linux" (flutter/flutter#135069)
2023-09-20 [email protected] Manual roll Flutter Engine from 10c480310926 to a7af55c56aa6 (4 revisions) (flutter/flutter#135071)
2023-09-19 [email protected] Retry Linux web tests 1 time on roll presubmit (flutter/flutter#135073)
2023-09-19 [email protected] [web] Encode AssetManifest.bin as JSON and use that on the web. (flutter/flutter#131382)
2023-09-19 [email protected] Specify suggested format in doc comment. (flutter/flutter#134887)
2023-09-19 [email protected] Manual roll Flutter Engine from 28f14e6eec4f to 10c480310926 (6 revisions) (flutter/flutter#135066)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polina-c polina-c polina-c approved these changes

Assignees
No one assigned
Labels
a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker a: text input Entering text in a text field or keyboard related problems f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ksokolovskyi @polina-c