Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date picker dialog state should dispose members. #134804

Merged
merged 3 commits into from
Sep 15, 2023

Conversation

polina-c
Copy link
Contributor

No description provided.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Sep 15, 2023
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@polina-c polina-c merged commit 72b69f9 into flutter:master Sep 15, 2023
66 of 67 checks passed
@polina-c polina-c deleted the _DatePickerDialogState branch September 15, 2023 15:56
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 15, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Sep 15, 2023
flutter/flutter@58ba6c2...72b69f9

2023-09-15 [email protected] Date picker dialog state should dispose members. (flutter/flutter#134804)
2023-09-15 [email protected] Roll Packages from 275b76c to bc8c2f2 (7 revisions) (flutter/flutter#134823)
2023-09-15 [email protected] Fix navigation rail hover misplaced when direction is RTL and extended is true (flutter/flutter#134815)
2023-09-15 [email protected] Applied the logo to the Discord badge. (flutter/flutter#134339)
2023-09-15 [email protected] Fix memory leak in ListWheelScrollView (flutter/flutter#134732)
2023-09-15 [email protected] Move two tests on Pixel 7 from staging to prod (flutter/flutter#134784)
2023-09-14 [email protected] Roll Flutter Engine from 683bca53d4d7 to 45bc4307cda3 (2 revisions) (flutter/flutter#134789)
2023-09-14 [email protected] [web] provide serviceWorkerVersion to the getNewServiceWorker function (flutter/flutter#131240)
2023-09-14 [email protected] Roll Flutter Engine from 3a3a2807c3b6 to 683bca53d4d7 (3 revisions) (flutter/flutter#134778)
2023-09-14 [email protected] Roll Flutter Engine from 035932d64017 to 3a3a2807c3b6 (5 revisions) (flutter/flutter#134769)
2023-09-14 47866232 [email protected] Allows page removal that contains Localhistoryentry (flutter/flutter#134757)
2023-09-14 [email protected] Roll Flutter Engine from e0b5b6c4eb76 to 035932d64017 (2 revisions) (flutter/flutter#134763)
2023-09-14 [email protected] Cover more test/widgets tests with leak tracking #3 (flutter/flutter#134576)
2023-09-14 [email protected] Roll Flutter Engine from 2cd34d23c1a2 to e0b5b6c4eb76 (2 revisions) (flutter/flutter#134755)
2023-09-14 15619084 [email protected] Set xcode version to older compatible version for microbenchmarks_ios_xcode_debug test (flutter/flutter#134693)
2023-09-14 82763757 [email protected] Cover some Services tests with leak tracing (flutter/flutter#134381)
2023-09-14 [email protected] Roll Flutter Engine from 4160ebacdae2 to 2cd34d23c1a2 (18 revisions) (flutter/flutter#134749)
2023-09-14 [email protected] ð��� Setup color tween for `RefreshIndicator` in a better way (flutter/flutter#134492)
2023-09-14 [email protected] Fix NavigationRail hover misplaced when using large icons (flutter/flutter#134719)
2023-09-14 [email protected] Roll Flutter Engine from cd90cc8469fb to 4160ebacdae2 (5 revisions) (flutter/flutter#134695)
2023-09-14 30870216 [email protected] Added a devicelab test for vulkan validation layers (flutter/flutter#134685)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/ doc/main/autoroll/README.md
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023
…r#4934)

flutter/flutter@58ba6c2...72b69f9

2023-09-15 [email protected] Date picker dialog state should dispose members. (flutter/flutter#134804)
2023-09-15 [email protected] Roll Packages from 275b76c to bc8c2f2 (7 revisions) (flutter/flutter#134823)
2023-09-15 [email protected] Fix navigation rail hover misplaced when direction is RTL and extended is true (flutter/flutter#134815)
2023-09-15 [email protected] Applied the logo to the Discord badge. (flutter/flutter#134339)
2023-09-15 [email protected] Fix memory leak in ListWheelScrollView (flutter/flutter#134732)
2023-09-15 [email protected] Move two tests on Pixel 7 from staging to prod (flutter/flutter#134784)
2023-09-14 [email protected] Roll Flutter Engine from 683bca53d4d7 to 45bc4307cda3 (2 revisions) (flutter/flutter#134789)
2023-09-14 [email protected] [web] provide serviceWorkerVersion to the getNewServiceWorker function (flutter/flutter#131240)
2023-09-14 [email protected] Roll Flutter Engine from 3a3a2807c3b6 to 683bca53d4d7 (3 revisions) (flutter/flutter#134778)
2023-09-14 [email protected] Roll Flutter Engine from 035932d64017 to 3a3a2807c3b6 (5 revisions) (flutter/flutter#134769)
2023-09-14 47866232 [email protected] Allows page removal that contains Localhistoryentry (flutter/flutter#134757)
2023-09-14 [email protected] Roll Flutter Engine from e0b5b6c4eb76 to 035932d64017 (2 revisions) (flutter/flutter#134763)
2023-09-14 [email protected] Cover more test/widgets tests with leak tracking flutter#3 (flutter/flutter#134576)
2023-09-14 [email protected] Roll Flutter Engine from 2cd34d23c1a2 to e0b5b6c4eb76 (2 revisions) (flutter/flutter#134755)
2023-09-14 15619084 [email protected] Set xcode version to older compatible version for microbenchmarks_ios_xcode_debug test (flutter/flutter#134693)
2023-09-14 82763757 [email protected] Cover some Services tests with leak tracing (flutter/flutter#134381)
2023-09-14 [email protected] Roll Flutter Engine from 4160ebacdae2 to 2cd34d23c1a2 (18 revisions) (flutter/flutter#134749)
2023-09-14 [email protected] ð��� Setup color tween for `RefreshIndicator` in a better way (flutter/flutter#134492)
2023-09-14 [email protected] Fix NavigationRail hover misplaced when using large icons (flutter/flutter#134719)
2023-09-14 [email protected] Roll Flutter Engine from cd90cc8469fb to 4160ebacdae2 (5 revisions) (flutter/flutter#134695)
2023-09-14 30870216 [email protected] Added a devicelab test for vulkan validation layers (flutter/flutter#134685)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/ doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants