Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover focus tests with leak tracking #134457

Merged
merged 3 commits into from
Sep 11, 2023
Merged

Cover focus tests with leak tracking #134457

merged 3 commits into from
Sep 11, 2023

Conversation

ksokolovskyi
Copy link
Contributor

Description

This PR changes testWidgets by testWidgetsWithLeakTracking in number of flutter/test/widgets tests according to the dart-lang/leak_tracker#134.

Tests

  • Updates focus_manager_test.dart to use testWidgetsWithLeakTracking;
  • Updates focus_scope_test.dart to use testWidgetsWithLeakTracking;
  • Updates focus_traversal_test.dart to use testWidgetsWithLeakTracking.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: focus Focus traversal, gaining or losing focus labels Sep 11, 2023
@ksokolovskyi
Copy link
Contributor Author

cc @polina-c

@XilaiZhang
Copy link
Contributor

side note: I was testing out a few things and Google Testing wasn't triggered on this PR, it should be triggered on future commits pushed to this pr.

@polina-c
Copy link
Contributor

@XilaiZhang , i merged master, but I do not see google testing in the list. Is it ok to merge if everything is green or I need to trigger google testing somehow?

@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 11, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 11, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 11, 2023

auto label is removed for flutter/flutter/134457, due to This PR has not met approval requirements for merging. You are not a member of flutter-hackers and need 1 more review(s) in order to merge this PR.

  • Merge guidelines: You need at least one approved review if you are already part of flutter-hackers or two member reviews if you are not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

chunhtai
chunhtai approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 11, 2023
@polina-c polina-c merged commit adaf78a into flutter:master Sep 11, 2023
65 of 67 checks passed
@XilaiZhang
Copy link
Contributor

Umm looks like Google Testing was pending due to merge conflict, very likely due to flutter rolls being 2 weeks behind current head.

I sent cl/564524744 to better manifest the information on propagating merge conflict information

@ksokolovskyi
Copy link
Contributor Author

@polina-c @chunhtai @XilaiZhang thanks for the review!

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2023
@engine-flutter-autoroll
adaf78a60 Cover focus tests with leak tracking (flutter/flutter#134457)
e3fa6e6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2023
@engine-flutter-autoroll
adaf78a60 Cover focus tests with leak tracking (flutter/flutter#134457)
7aaca5d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2023
@engine-flutter-autoroll
adaf78a60 Cover focus tests with leak tracking (flutter/flutter#134457)
fcd0e7e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2023
@engine-flutter-autoroll
adaf78a60 Cover focus tests with leak tracking (flutter/flutter#134457)
a2a3849
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2023
@engine-flutter-autoroll
adaf78a60 Cover focus tests with leak tracking (flutter/flutter#134457)
49df19d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 12, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2023
@engine-flutter-autoroll
adaf78a60 Cover focus tests with leak tracking (flutter/flutter#134457)
6623db6
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Sep 12, 2023
@engine-flutter-autoroll
Roll Flutter from 219efce7f16d to 4e7a07af882c (30 revisions) (#4910)
7d31e9b 
flutter/flutter@219efce...4e7a07a

2023-09-12 [email protected] Remove chip tooltip deprecations (flutter/flutter#134486)
2023-09-12 [email protected] Roll Flutter Engine from 8a8ddaeecf8a to d4698c65aa8d (2 revisions) (flutter/flutter#134553)
2023-09-12 [email protected] Remove deprecated TextSelectionOverlay.fadeDuration (flutter/flutter#134485)
2023-09-12 [email protected] Roll Flutter Engine from 25be03186d82 to 8a8ddaeecf8a (1 revision) (flutter/flutter#134545)
2023-09-12 [email protected] Roll Packages from ef0c65e to e04ba88 (5 revisions) (flutter/flutter#134546)
2023-09-12 47866232 [email protected] Revert "Adds a parent scope TraversalEdgeBehavior and fixes modal rouâ�¦ (flutter/flutter#134550)
2023-09-12 [email protected] Marks Windows_android channels_integration_test_win to be unflaky (flutter/flutter#133129)
2023-09-12 [email protected] Roll Flutter Engine from 4091167e402d to 25be03186d82 (1 revision) (flutter/flutter#134536)
2023-09-12 [email protected] Roll Flutter Engine from 54175da7ba90 to 4091167e402d (1 revision) (flutter/flutter#134532)
2023-09-12 [email protected] Roll Flutter Engine from 85f3f02e5c37 to 54175da7ba90 (2 revisions) (flutter/flutter#134531)
2023-09-12 [email protected] Roll Flutter Engine from 1369ab35aaa7 to 85f3f02e5c37 (1 revision) (flutter/flutter#134519)
2023-09-12 [email protected] Roll Flutter Engine from 2f1efe5967f3 to 1369ab35aaa7 (1 revision) (flutter/flutter#134512)
2023-09-12 [email protected] Roll Flutter Engine from 4d8265cbc133 to 2f1efe5967f3 (3 revisions) (flutter/flutter#134511)
2023-09-12 [email protected] Roll Flutter Engine from ee7215553deb to 4d8265cbc133 (1 revision) (flutter/flutter#134506)
2023-09-12 [email protected] Roll Flutter Engine from 6ddee4423d2c to ee7215553deb (2 revisions) (flutter/flutter#134505)
2023-09-12 [email protected] Roll Flutter Engine from a98348946d61 to 6ddee4423d2c (1 revision) (flutter/flutter#134490)
2023-09-12 [email protected] [New feature] Allowing the `ListView` slivers to have different extents while still having scrolling performance (flutter/flutter#131393)
2023-09-12 [email protected] Roll Flutter Engine from 8389ad914b21 to a98348946d61 (4 revisions) (flutter/flutter#134487)
2023-09-12 [email protected] ScaleGestureRecognizer: make pointerCount public (flutter/flutter#127310)
2023-09-11 [email protected] Fix DataTable example not being scrollable (flutter/flutter#131556)
2023-09-11 [email protected] Roll Flutter Engine from 06696e768c1b to 8389ad914b21 (2 revisions) (flutter/flutter#134469)
2023-09-11 [email protected] [flutter_tools] disallow -O0 for flutter build web (flutter/flutter#134185)
2023-09-11 [email protected] Cover focus tests with leak tracking (flutter/flutter#134457)
2023-09-11 [email protected] Roll Flutter Engine from 0774ddcda9b0 to 06696e768c1b (4 revisions) (flutter/flutter#134462)
2023-09-11 [email protected] Fix memory leak in RenderAnimatedSize (flutter/flutter#133653)
2023-09-11 [email protected] Roll Flutter Engine from e42fd367adcb to 0774ddcda9b0 (1 revision) (flutter/flutter#134447)
2023-09-11 [email protected] Roll Flutter Engine from d593002b7159 to e42fd367adcb (1 revision) (flutter/flutter#134444)
2023-09-11 [email protected] Roll Packages from aaae5ef to ef0c65e (6 revisions) (flutter/flutter#134445)
2023-09-11 [email protected] Roll Flutter Engine from 2b5961cbc40d to d593002b7159 (3 revisions) (flutter/flutter#134439)
2023-09-11 [email protected] Mark leak: instances of OpacityLayer, created by _RenderChip, should be disposed. (flutter/flutter#134395)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/ doc/main/autoroll/README.md
@HansMuller HansMuller mentioned this pull request Sep 15, 2023
Open
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
adaf78a60 Cover focus tests with leak tracking (flutter/flutter#134457)
cad2523
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polina-c polina-c polina-c approved these changes

@chunhtai chunhtai chunhtai approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: focus Focus traversal, gaining or losing focus framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ksokolovskyi @XilaiZhang @polina-c @chunhtai