Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark leak: instances of OpacityLayer, created by _RenderChip, should be disposed. #134395

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Mark leak: instances of OpacityLayer, created by _RenderChip, should be disposed. #134395

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift click to select a range
1e337b0
Update chip_test.dart
polina-c Sep 11, 2023
8c313d0
Update chip_test.dart
polina-c Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/flutter/test/material/chip_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 217,7 @@ Finder findTooltipContainer(String tooltipText) {
}

void main() {
testWidgets('M2 Chip defaults', (WidgetTester tester) async {
testWidgetsWithLeakTracking('M2 Chip defaults', (WidgetTester tester) async {
late TextTheme textTheme;

Widget buildFrame(Brightness brightness) {
Expand Down Expand Up @@ -292,7 292,12 @@ void main() {
expect(labelStyle.overflow, textTheme.bodyLarge?.overflow);
expect(labelStyle.textBaseline, textTheme.bodyLarge?.textBaseline);
expect(labelStyle.wordSpacing, textTheme.bodyLarge?.wordSpacing);
});
},
// TODO(polina-c): remove after fixing
// https://github.com/flutter/flutter/issues/134394
leakTrackingTestConfig: const LeakTrackingTestConfig(
notDisposedAllowList: <String, int?>{'OpacityLayer': 2},
));

testWidgetsWithLeakTracking('M3 Chip defaults', (WidgetTester tester) async {
late TextTheme textTheme;
Expand Down