[Windows Arm64] Remove device_type property #134181

loic-sharma · 2023-09-07T00:23:43Z

The Windows Arm64 tests are failing to start as no machines match desired properties. This removes the device_type: none property as no Windows Arm64 machines match this (with device_type, without device_type).

This allows the tests to run on the Windows Arm64 machine pool. I tested this manually using led.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

christopherfujino · 2023-09-07T00:31:44Z

.ci.yaml

@@ -204,7  204,6 @@ platform_properties:
          {"dependency": "certs", "version": "version:9563bb"}
        ]
      os: Windows
-      device_type: none


Is this the right change to make, or is the issue that the bot is missing this dimension?

That's a good question. Let me loop back on that.

In this case, which is odd, I believe this to be the correct change as the target Windows-11 machines do not have this dimension. So attempting to match on this actually excludes them.

Here is an example: https://chromium-swarm.appspot.com/bot?id=flutter-win-10

If you go to the bot list searching on device_type:none it does not appear there: https://chromium-swarm.appspot.com/botlist?c=id&c=task&c=os&c=status&d=asc&f=pool:luci.flutter.staging&f=device_type:none&k=device_type&s=id

Which admittedly I find odd and would have assumed that this was the default.

In this case, which is odd, I believe this to be the correct change as the target Windows-11 machines do not have this dimension. So attempting to match on this actually excludes them.

Right, I was wondering if this was a mistake, and if the true fix should not be adding the dimension to be consistent with the other devicelab bots.

In this case, which is odd, I believe this to be the correct change as the target Windows-11 machines do not have this dimension. So attempting to match on this actually excludes them.

Right, I was wondering if this was a mistake, and if the true fix should not be adding the dimension to be consistent with the other devicelab bots.

Ah that is a good point. I am not sure if there is a precedent but you might be right here. It might be more intuitive to have to include this as device_type: none.

I talked to @yusuf-goog, the Windows Arm64 devices are physical machines, and normally physical machines have devices attached to them. The Windows x64 devices device_type: none are actually VMs. In other words, this is expected from the bots perspective.

Ah, I commented below but I will defer to Yusuf. He knows more about this than I do so go for it. I'll find a place in the docs to update this as this is confusing for sure.

Small note: we do have windows x64 devices in the devicelab as well, so builds should target the right dimensions to pick the arm64 win bots. (which the cpu: arm64 does)

I talked to @yusuf-goog, the Windows Arm64 devices are physical machines, and normally physical machines have devices attached to them. The Windows x64 devices device_type: none are actually VMs. In other words, this is expected from the bots perspective.

ahh yeah, of course!

ricardoamador

Go lucky!

ricardoamador · 2023-09-07T00:55:34Z

You could validate this with LED as well by just targeting the staging pool assuming that the builder has been created.

loic-sharma · 2023-09-07T01:12:12Z

You could validate this with LED as well by just targeting the staging pool assuming that the builder has been created.

Yup, the manual run did indeed find a machine.

ricardoamador · 2023-09-07T01:12:53Z

Let me see if I can make the change first in the infra configs.

ricardoamador · 2023-09-07T01:24:45Z

Ah okay. Good to know. I would trust Yusuf on this one. Proceed my friend!

AmrSaaad

Great

yusuf-goog · 2023-09-07T16:16:28Z

@XilaiZhang do you know why google testing has been queued and not running?

XilaiZhang · 2023-09-07T20:25:26Z

Ah yeah its probably merge conflicts again. I can merge it in manually for you

…134181)

flutter/flutter@aea4552...da676f7 2023-09-08 [email protected] Marks Linux_android very_long_picture_scrolling_perf__e2e_summary to be unflaky (flutter/flutter#134116) 2023-09-08 31859944 [email protected] Make `CupertinoTextField` at least as tall as its first line of placeholder (flutter/flutter#134198) 2023-09-08 [email protected] Roll Flutter Engine from f09a139101c3 to 6d6b44886175 (3 revisions) (flutter/flutter#134306) 2023-09-08 [email protected] Update links to iOS embedder docs to point to new Doxygen docs (flutter/flutter#134246) 2023-09-08 [email protected] Roll Packages from 22d4754 to aaae5ef (7 revisions) (flutter/flutter#134301) 2023-09-08 [email protected] Roll Flutter Engine from c38feb382e96 to f09a139101c3 (1 revision) (flutter/flutter#134299) 2023-09-08 [email protected] Roll Flutter Engine from f146d4bf244b to c38feb382e96 (1 revision) (flutter/flutter#134293) 2023-09-08 [email protected] Roll Flutter Engine from a140ab4a4ec6 to f146d4bf244b (1 revision) (flutter/flutter#134290) 2023-09-08 [email protected] Roll Flutter Engine from ea1d0d28e26f to a140ab4a4ec6 (5 revisions) (flutter/flutter#134288) 2023-09-08 [email protected] fix a Scrollbar example crash (flutter/flutter#127925) 2023-09-08 [email protected] Fix `Drawer` examples are missing `dartpad` tag (flutter/flutter#134219) 2023-09-08 [email protected] Roll Flutter Engine from 4ac4429a206b to ea1d0d28e26f (1 revision) (flutter/flutter#134270) 2023-09-08 [email protected] Roll Flutter Engine from df3965a55fd8 to 4ac4429a206b (1 revision) (flutter/flutter#134267) 2023-09-08 [email protected] Roll Flutter Engine from 505ef3c33102 to df3965a55fd8 (1 revision) (flutter/flutter#134263) 2023-09-08 [email protected] _TabBarViewState should dispose created instances of PageController. (flutter/flutter#134091) 2023-09-08 [email protected] Remove non needed controllers in SegmentedButton. (flutter/flutter#134064) 2023-09-08 [email protected] EditableTextState should dispose cursorVisibilityNotifier. (flutter/flutter#133858) 2023-09-08 [email protected] TestWidgetsFlutterBinding should dispose old RestorationManager on reset. (flutter/flutter#133999) 2023-09-08 [email protected] Roll Flutter Engine from 65f6fb841c7a to 505ef3c33102 (4 revisions) (flutter/flutter#134260) 2023-09-07 [email protected] CupertinoAlertDialog should not create ScrollController on every build, if null values are passed in constructor. (flutter/flutter#134075) 2023-09-07 [email protected] Roll Flutter Engine from a828c26e7e97 to 65f6fb841c7a (1 revision) (flutter/flutter#134254) 2023-09-07 [email protected] _SearchBarState should dispose FocusNode, if it created it. (flutter/flutter#134076) 2023-09-07 [email protected] Roll Flutter Engine from 2dba8ceca824 to a828c26e7e97 (8 revisions) (flutter/flutter#134249) 2023-09-07 34871572 [email protected] [integration_test] Allow capture of screenshots for `FlutterFragmentActivity`s (flutter/flutter#132406) 2023-09-07 [email protected] Roll Flutter Engine from 8d07c2947e60 to 2dba8ceca824 (2 revisions) (flutter/flutter#134243) 2023-09-07 [email protected] Fix `ExpansionTile` properties cannot be updated with `setState` (flutter/flutter#134218) 2023-09-07 737941 [email protected] [Windows Arm64] Remove device_type property (flutter/flutter#134181) 2023-09-07 [email protected] Roll Flutter Engine from f0b718e28779 to 8d07c2947e60 (3 revisions) (flutter/flutter#134240) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/ doc/main/autoroll/README.md

…134181)

[Windows Arm64] Remove device_type property

d9a4be8

loic-sharma requested review from christopherfujino and ricardoamador September 7, 2023 00:30

loic-sharma marked this pull request as ready for review September 7, 2023 00:30

christopherfujino reviewed Sep 7, 2023

View reviewed changes

ricardoamador approved these changes Sep 7, 2023

View reviewed changes

yusuf-goog approved these changes Sep 7, 2023

View reviewed changes

AmrSaaad reviewed Sep 7, 2023

View reviewed changes

loic-sharma added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 7, 2023

XilaiZhang merged commit 2032fcc into master Sep 7, 2023
133 of 134 checks passed

XilaiZhang deleted the windows_arm64_ci_device_type branch September 7, 2023 20:25

engine-flutter-autoroll mentioned this pull request Sep 8, 2023

Roll Flutter from aea4552acdc7 to 7b06874ef565 (23 revisions) flutter/packages#4871

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 8, 2023

2032fcc [Windows Arm64] Remove device_type property (flutter/flutter#…

692dc28

…134181)

engine-flutter-autoroll mentioned this pull request Sep 8, 2023

Roll Flutter from aea4552acdc7 to 53017f8525e6 (24 revisions) flutter/packages#4872

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 8, 2023

2032fcc [Windows Arm64] Remove device_type property (flutter/flutter#…

14c793f

…134181)

engine-flutter-autoroll mentioned this pull request Sep 8, 2023

Roll Flutter from aea4552acdc7 to 3ce6174e6b49 (25 revisions) flutter/packages#4873

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 8, 2023

2032fcc [Windows Arm64] Remove device_type property (flutter/flutter#…

6768506

…134181)

engine-flutter-autoroll mentioned this pull request Sep 8, 2023

Roll Flutter from aea4552acdc7 to da676f79aa37 (28 revisions) flutter/packages#4874

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 8, 2023

2032fcc [Windows Arm64] Remove device_type property (flutter/flutter#…

052619a

…134181)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023

2032fcc [Windows Arm64] Remove device_type property (flutter/flutter#…

62db34f

…134181)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Windows Arm64] Remove device_type property #134181

[Windows Arm64] Remove device_type property #134181

loic-sharma commented Sep 7, 2023 •

edited

Loading

christopherfujino Sep 7, 2023

loic-sharma Sep 7, 2023

ricardoamador Sep 7, 2023

ricardoamador Sep 7, 2023

christopherfujino Sep 7, 2023

ricardoamador Sep 7, 2023

loic-sharma Sep 7, 2023

ricardoamador Sep 7, 2023 •

edited

Loading

yusuf-goog Sep 7, 2023 •

edited

Loading

christopherfujino Sep 7, 2023

ricardoamador left a comment

ricardoamador commented Sep 7, 2023

loic-sharma commented Sep 7, 2023

ricardoamador commented Sep 7, 2023

ricardoamador commented Sep 7, 2023

AmrSaaad left a comment

yusuf-goog commented Sep 7, 2023

XilaiZhang commented Sep 7, 2023

[Windows Arm64] Remove device_type property #134181

[Windows Arm64] Remove device_type property #134181

Conversation

loic-sharma commented Sep 7, 2023 • edited Loading

Pre-launch Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ricardoamador Sep 7, 2023 • edited Loading

Choose a reason for hiding this comment

yusuf-goog Sep 7, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ricardoamador left a comment

Choose a reason for hiding this comment

ricardoamador commented Sep 7, 2023

loic-sharma commented Sep 7, 2023

ricardoamador commented Sep 7, 2023

ricardoamador commented Sep 7, 2023

AmrSaaad left a comment

Choose a reason for hiding this comment

yusuf-goog commented Sep 7, 2023

XilaiZhang commented Sep 7, 2023

loic-sharma commented Sep 7, 2023 •

edited

Loading

ricardoamador Sep 7, 2023 •

edited

Loading

yusuf-goog Sep 7, 2023 •

edited

Loading