Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TabController should dispatch creation in constructor. [prod-leak-fix] #133952

Merged
merged 15 commits into from
Sep 22, 2023
Merged

TabController should dispatch creation in constructor. [prod-leak-fix] #133952

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift click to select a range
3ea456b
-
polina-c Sep 3, 2023
ab60eea
Create tab_controller_test.dart
polina-c Sep 3, 2023
f301079
Update tab_bar_theme_test.dart
polina-c Sep 3, 2023
1a9797a
Merge branch 'master' into TabController
polina-c Sep 11, 2023
fe99dfe
Merge branch 'master' of https://github.com/flutter/flutter into TabC…
polina-c Sep 11, 2023
ff38b52
-
polina-c Sep 11, 2023
5163587
Merge branch 'master' of https://github.com/flutter/flutter into TabC…
polina-c Sep 15, 2023
46987c3
-
polina-c Sep 15, 2023
f3a0adb
Merge branch 'master' of https://github.com/flutter/flutter into TabC…
polina-c Sep 16, 2023
0cc9b69
Update tab_bar_theme_test.dart
polina-c Sep 16, 2023
c47f287
Update page_selector_test.dart
polina-c Sep 16, 2023
c59e492
Merge branch 'master' of https://github.com/flutter/flutter into TabC…
polina-c Sep 22, 2023
db2c144
Update framework_test.dart
polina-c Sep 22, 2023
c70c633
-
polina-c Sep 22, 2023
2e08f50
Update scrollable_test.dart
polina-c Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
-
  • Loading branch information
@polina-c
polina-c committed Sep 22, 2023
commit c70c633ba42902b61f7e29df06f563f96caaf901
2 changes: 1 addition & 1 deletion packages/flutter/lib/src/material/tab_controller.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 117,7 @@ class TabController extends ChangeNotifier {
vsync: vsync,
) {
if (kFlutterMemoryAllocationsEnabled) {
maybeDispatchObjectCreation();
ChangeNotifier.maybeDispatchObjectCreation(this);
}
}

Expand Down
5 changes: 4 additions & 1 deletion packages/flutter/test/material/tab_controller_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 8,9 @@ import 'package:leak_tracker_flutter_testing/leak_tracker_flutter_testing.dart';

void main() {
testWidgetsWithLeakTracking('$TabController dispatches creation in constructor.', (WidgetTester widgetTester) async {
expect(() => TabController(length: 1, vsync: const TestVSync()).dispose(), dispatchesMemoryEvents(TabController));
await expectLater(
await memoryEvents(() async => TabController(length: 1, vsync: const TestVSync()).dispose(), TabController),
areCreateAndDispose,
);
});
}