Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover some test/widgets tests with leak tracking #133803

Merged
merged 11 commits into from
Sep 7, 2023
Merged

Cover some test/widgets tests with leak tracking #133803

merged 11 commits into from
Sep 7, 2023

Conversation

ksokolovskyi
Copy link
Contributor

@ksokolovskyi ksokolovskyi commented Aug 31, 2023 •
edited
Loading

Description

This is the fixed copy of the #133767.

This PR changes testWidgets by testWidgetsWithLeakTracking in number of flutter/test/widgets tests according to the dart-lang/leak_tracker#134.

Marks leaks

Tests

  • Updates absorb_pointer_test.dart to use testWidgetsWithLeakTracking;
  • Updates actions_test.dart to use testWidgetsWithLeakTracking;
  • Updates align_test.dart to use testWidgetsWithLeakTracking;
  • Updates animated_align_test.dart to use testWidgetsWithLeakTracking;
  • Updates animated_container_test.dart to use testWidgetsWithLeakTracking;
  • Updates animated_cross_fade_test.dart to use testWidgetsWithLeakTracking;
  • Updates animated_grid_test.dart to use testWidgetsWithLeakTracking;
  • Updates animated_image_filtered_repaint_test.dart to use testWidgetsWithLeakTracking;
  • Updates animated_list_test.dart to use testWidgetsWithLeakTracking;
  • Updates animated_opacity_repaint_test.dart to use testWidgetsWithLeakTracking;
  • Updates animated_padding_test.dart to use testWidgetsWithLeakTracking;
  • Updates animated_positioned_test.dart to use testWidgetsWithLeakTracking;
  • Updates animated_size_test.dart to use testWidgetsWithLeakTracking;
  • Updates animated_switcher_test.dart to use testWidgetsWithLeakTracking;
  • Updates annotated_region_test.dart to use testWidgetsWithLeakTracking;
  • Updates app_lifecycle_listener_test.dart to use testWidgetsWithLeakTracking;
  • Updates app_navigator_key_test.dart to use testWidgetsWithLeakTracking;
  • Updates app_overrides_test.dart to use testWidgetsWithLeakTracking;
  • Updates app_test.dart to use testWidgetsWithLeakTracking;
  • Updates app_title_test.dart to use testWidgetsWithLeakTracking;
  • Updates aspect_ratio_test.dart to use testWidgetsWithLeakTracking;
  • Updates async_test.dart to use testWidgetsWithLeakTracking;
  • Updates autocomplete_test.dart to use testWidgetsWithLeakTracking;
  • Updates autofill_group_test.dart to use testWidgetsWithLeakTracking;
  • Updates automatic_keep_alive_test.dart to use testWidgetsWithLeakTracking;
  • Updates backdrop_filter_test.dart to use testWidgetsWithLeakTracking;
  • Updates banner_test.dart to use testWidgetsWithLeakTracking;
  • Updates baseline_test.dart to use testWidgetsWithLeakTracking;
  • Updates basic_test.dart to use testWidgetsWithLeakTracking;
  • Updates binding_deferred_first_frame_test.dart to use testWidgetsWithLeakTracking;
  • Updates binding_test.dart to use testWidgetsWithLeakTracking;
  • Updates box_decoration_test.dart to use testWidgetsWithLeakTracking;
  • Updates build_context_test.dart to use testWidgetsWithLeakTracking;
  • Updates build_scope_test.dart to use testWidgetsWithLeakTracking;
  • Updates center_test.dart to use testWidgetsWithLeakTracking;
  • Updates clamp_overscrolls_test.dart to use testWidgetsWithLeakTracking;
  • Updates clip_test.dart to use testWidgetsWithLeakTracking;
  • Updates color_filter_test.dart to use testWidgetsWithLeakTracking;
  • Updates column_test.dart to use testWidgetsWithLeakTracking;
  • Updates composited_transform_test.dart to use testWidgetsWithLeakTracking;
  • Updates constrained_box_test.dart to use testWidgetsWithLeakTracking;
  • Updates container_test.dart to use testWidgetsWithLeakTracking;
  • Updates context_menu_controller_test.dart to use testWidgetsWithLeakTracking;
  • Updates coordinates_test.dart to use testWidgetsWithLeakTracking;
  • Updates custom_multi_child_layout_test.dart to use testWidgetsWithLeakTracking;
  • Updates custom_paint_test.dart to use testWidgetsWithLeakTracking;
  • Updates custom_painter_test.dart to use testWidgetsWithLeakTracking;
  • Updates custom_scroll_view_test.dart to use testWidgetsWithLeakTracking;
  • Updates custom_single_child_layout_test.dart to use testWidgetsWithLeakTracking;
  • Updates debug_test.dart to use testWidgetsWithLeakTracking;
  • Updates decorated_sliver_test.dart to use testWidgetsWithLeakTracking;
  • Updates default_colors_test.dart to use testWidgetsWithLeakTracking;
  • Updates default_text_editing_shortcuts_test.dart to use testWidgetsWithLeakTracking;
  • Updates default_text_height_behavior_test.dart to use testWidgetsWithLeakTracking;
  • Updates default_text_style_test.dart to use testWidgetsWithLeakTracking;
  • Updates did_update_widget_test.dart to use testWidgetsWithLeakTracking;
  • Updates directionality_test.dart to use testWidgetsWithLeakTracking;
  • Updates dismissible_test.dart to use testWidgetsWithLeakTracking;
  • Updates display_feature_sub_screen_test.dart to use testWidgetsWithLeakTracking;
  • Updates disposable_build_context_test.dart to use testWidgetsWithLeakTracking.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Aug 31, 2023
@ksokolovskyi
Copy link
Contributor Author

@polina-c please review this PR when you have time.

polina-c
polina-c reviewed Aug 31, 2023
View reviewed changes
packages/flutter/test/widgets/actions_test.dart Outdated
@@ -392,9 393,11 @@ void main() {
await buildTest(true);
expect(hovering, isFalse);
expect(focusing, isFalse);

focusNode.dispose();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update disposals to be aligned with newly gained knowledge: dart-lang/leak_tracker#138

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@polina-c great rule, thanks.

polina-c
polina-c requested changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@polina-c polina-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment.

@ksokolovskyi
Copy link
Contributor Author

@polina-c Could you please take a look again?

@polina-c polina-c mentioned this pull request Sep 2, 2023
Closed
@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems f: scrolling Viewports, list views, slivers, etc. f: routes Navigator, Router, and related APIs. labels Sep 6, 2023
@ksokolovskyi ksokolovskyi mentioned this pull request Sep 7, 2023
Closed
2 tasks
@ksokolovskyi
Copy link
Contributor Author

@polina-c could you please take a look again?

@polina-c polina-c merged commit aca91df into flutter:master Sep 7, 2023
67 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
aca91df6b Cover some test/widgets tests with leak tracking (flutter/f…
63a73bf 
…lutter#133803)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
aca91df6b Cover some test/widgets tests with leak tracking (flutter/f…
bb6de27 
…lutter#133803)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 7, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
aca91df6b Cover some test/widgets tests with leak tracking (flutter/f…
cb9690d 
…lutter#133803)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
Manual roll Flutter from 685ce14b2d0f to aea4552acdc7 (64 revisions) (#…
913c946 
…4870)

Manual roll Flutter from 685ce14b2d0f to aea4552acdc7 (64 revisions)

Manual roll requested by [email protected]

flutter/flutter@685ce14...aea4552

2023-09-07 [email protected] add --exit flag to dev/devicelab/bin/test_runner.dart (flutter/flutter#134165)
2023-09-07 [email protected] fix `--exit` flag in dev/devicelab/bin/run.dart (flutter/flutter#134162)
2023-09-07 [email protected] Roll Packages from e7d812c to 22d4754 (9 revisions) (flutter/flutter#134232)
2023-09-07 [email protected] Roll Flutter Engine from 71bea01d3abe to f0b718e28779 (2 revisions) (flutter/flutter#134231)
2023-09-07 [email protected] DropdownRoutePage should dispose the created ScrollController. (flutter/flutter#133941)
2023-09-07 [email protected] Cover some test/widgets tests with leak tracking (flutter/flutter#133803)
2023-09-07 [email protected] SearchDelegate should dispose resources. (flutter/flutter#133948)
2023-09-07 [email protected] Fixed [NavigationRailDestination]'s label opacity while disabled not being coherent with the icon (flutter/flutter#132345)
2023-09-07 [email protected] Roll Flutter Engine from 558136a1ccbf to 71bea01d3abe (2 revisions) (flutter/flutter#134216)
2023-09-07 [email protected] Roll Flutter Engine from 5a45ecd24aa3 to 558136a1ccbf (1 revision) (flutter/flutter#134206)
2023-09-07 [email protected] Roll Flutter Engine from d864ae68db3c to 5a45ecd24aa3 (1 revision) (flutter/flutter#134201)
2023-09-07 [email protected] Fix `TabBar` doesn't use `labelStyle` & `unselectedLabelStyle` color (flutter/flutter#133989)
2023-09-07 [email protected] Fix `DataTable`'s `headingTextStyle` & `dataTextStyle` are not merged with default text style (flutter/flutter#134138)
2023-09-07 [email protected] Roll Flutter Engine from 187c5b3c5f71 to d864ae68db3c (2 revisions) (flutter/flutter#134199)
2023-09-07 [email protected] Reland "Fix `Chip.shape`'s side is not used when provided in Material 3" (flutter/flutter#133856)
2023-09-07 [email protected] Roll Flutter Engine from 75437a3bd002 to 187c5b3c5f71 (1 revision) (flutter/flutter#134193)
2023-09-07 [email protected] Manual roll Flutter Engine from 2c69d05dfafb to 75437a3bd002 (15 revisions) (flutter/flutter#134188)
2023-09-07 [email protected] Revert "Roll Flutter Engine from 2c69d05dfafb to fa14d337449b (6 revisions)" (flutter/flutter#134183)
2023-09-06 49699333 dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 3.1.2 to 3.1.3 (flutter/flutter#134173)
2023-09-06 [email protected] Roll Flutter Engine from 2c69d05dfafb to fa14d337449b (6 revisions) (flutter/flutter#134169)
2023-09-06 [email protected] DraggableScrollableActuator should dispose notifier. (flutter/flutter#133917)
2023-09-06 [email protected] Roll Flutter Engine from b04c2a378302 to 2c69d05dfafb (3 revisions) (flutter/flutter#134164)
2023-09-06 [email protected] Clean the fixed TODOs. (flutter/flutter#133859)
2023-09-06 [email protected] Roll Flutter Engine from 839051596b1d to b04c2a378302 (7 revisions) (flutter/flutter#134158)
2023-09-06 737941 [email protected] [Windows Arm64] Also use Windows 11 for Devicelab tests (flutter/flutter#134082)
2023-09-06 70351342 [email protected] Fix `subtitleTextStyle.color` isn't applied to the `ListTile.subtitle` in Material 2 (flutter/flutter#133422)
2023-09-06 [email protected] Add `CheckedPopupMenuItem.onTap` callback (flutter/flutter#134000)
2023-09-06 [email protected] MinimumTextContrastGuideline should dispose image. (flutter/flutter#133861)
2023-09-06 [email protected] [flutter_tools] Fix "FormatException: Invalid date format" during version freshness check (flutter/flutter#134088)
2023-09-06 [email protected] Fix not disposed items in Cupertino app and route. (flutter/flutter#134085)
2023-09-06 [email protected] Roll Flutter Engine from a5e7fa6bf81a to 839051596b1d (2 revisions) (flutter/flutter#134140)
2023-09-06 [email protected] _DropdownMenuState should dispose TextEditingController. (flutter/flutter#133914)
2023-09-06 [email protected] Roll Flutter Engine from 5253a33096d1 to a5e7fa6bf81a (1 revision) (flutter/flutter#134137)
2023-09-06 [email protected] Roll Flutter Engine from c7fd088291e2 to 5253a33096d1 (1 revision) (flutter/flutter#134135)
2023-09-06 [email protected] Roll Flutter Engine from 3d9989f1e155 to c7fd088291e2 (1 revision) (flutter/flutter#134132)
2023-09-06 [email protected] Roll Flutter Engine from bace539bb654 to 3d9989f1e155 (3 revisions) (flutter/flutter#134128)
2023-09-06 [email protected] Roll Flutter Engine from 9344685efbc3 to bace539bb654 (1 revision) (flutter/flutter#134104)
2023-09-06 [email protected] Roll Flutter Engine from 0c8c1647dcd0 to 9344685efbc3 (1 revision) (flutter/flutter#134103)
2023-09-06 [email protected] Roll Flutter Engine from 0c663258fd09 to 0c8c1647dcd0 (1 revision) (flutter/flutter#134100)
2023-09-06 [email protected] Roll Flutter Engine from 8bacc3b38707 to 0c663258fd09 (3 revisions) (flutter/flutter#134096)
2023-09-06 [email protected] Roll Flutter Engine from 590349006d23 to 8bacc3b38707 (5 revisions) (flutter/flutter#134089)
2023-09-06 [email protected] Roll Flutter Engine from 5b2cc9d9b8fe to 590349006d23 (2 revisions) (flutter/flutter#134081)
2023-09-05 [email protected] Roll Flutter Engine from 98b036ae708e to 5b2cc9d9b8fe (2 revisions) (flutter/flutter#134080)
2023-09-05 [email protected] Roll Flutter Engine from f4975e04f35e to 98b036ae708e (3 revisions) (flutter/flutter#134077)
...
@HansMuller HansMuller mentioned this pull request Sep 8, 2023
Open
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
aca91df6b Cover some test/widgets tests with leak tracking (flutter/f…
f4007b6 
…lutter#133803)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polina-c polina-c Awaiting requested review from polina-c

Assignees
No one assigned
Labels
a: text input Entering text in a text field or keyboard related problems f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ksokolovskyi @polina-c