Added option to disable [NavigationDestination]s ([NavigationBar] destination widget) #132361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
|
bump |
|
Bump v2.0 |
HansMuller
reviewed
Sep 18, 2023
|
You are right, I have learned how the Material States works only after this PR, code updated |
|
It looks like the presubmit tests need your attention. |
QuncCccccc
approved these changes
Sep 22, 2023
QuncCccccc
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/flutter/132361, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
Could you please rebase master to trigger Google testing again? Somehow in Google testing, some tests are broken but I don't think it is related to this change:) |
…ement problems inserted during the development of the disabled option for the NavigationDestination
…d to avoid double negatives
…ntation to use the word selectable instead of acessible.
… on disabled [NavigationBar] destinations
…ed state pr Co-authored-by: Qun Cheng <36861262 [email protected]>
matheus-kirchesch
force-pushed
the
feature/disable_navigation_bar_destination
branch
from
719f1b6
to
5ad6a2c
Compare
CaseyHillers
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 28, 2023
…onBar] destination widget) (flutter/flutter#132361)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 29, 2023
…onBar] destination widget) (flutter/flutter#132361)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 29, 2023
…onBar] destination widget) (flutter/flutter#132361)
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Sep 29, 2023
Roll Flutter from ff4a0f676f41 to 57b5c3cda000 (47 revisions) flutter/flutter@ff4a0f6...57b5c3c 2023-09-29 [email protected] Roll Packages from c070b0a to d0e9a0e (5 revisions) (flutter/flutter#135753) 2023-09-29 [email protected] Roll Flutter Engine from db4d3b5b3f59 to c52251a8b2d0 (1 revision) (flutter/flutter#135748) 2023-09-29 [email protected] Roll Flutter Engine from 8b4e633c65eb to db4d3b5b3f59 (2 revisions) (flutter/flutter#135745) 2023-09-29 [email protected] Roll Flutter Engine from 09130bf5be97 to 8b4e633c65eb (1 revision) (flutter/flutter#135744) 2023-09-29 [email protected] Roll Flutter Engine from ccb30585d3f3 to 09130bf5be97 (1 revision) (flutter/flutter#135741) 2023-09-29 [email protected] Roll Flutter Engine from 2052515c44f3 to ccb30585d3f3 (1 revision) (flutter/flutter#135737) 2023-09-29 [email protected] Update localizations. (flutter/flutter#135691) 2023-09-29 [email protected] Roll Flutter Engine from 485543c6765a to 2052515c44f3 (4 revisions) (flutter/flutter#135732) 2023-09-29 54558023 [email protected] Add arch property for windows_arm64 platform (flutter/flutter#135725) 2023-09-29 [email protected] [flutter_tools] remove VmService screenshot for native devices. (flutter/flutter#135462) 2023-09-29 [email protected] Pin leak_tracker before publishing breaking change. (flutter/flutter#135720) 2023-09-28 [email protected] Roll Flutter Engine from cc7c3c1f0f41 to 485543c6765a (8 revisions) (flutter/flutter#135717) 2023-09-28 [email protected] Remove assertions on getOffsetToReveal (flutter/flutter#135634) 2023-09-28 [email protected] Marks Linux_android flutter_gallery__start_up_delayed to be unflaky (flutter/flutter#135565) 2023-09-28 [email protected] Roll Flutter Engine from dbb60932a6ab to cc7c3c1f0f41 (2 revisions) (flutter/flutter#135701) 2023-09-28 [email protected] [tool] fallback to sigkill when closing Chromium (flutter/flutter#135521) 2023-09-28 137456488 [email protected] Roll pub packages (flutter/flutter#135455) 2023-09-28 [email protected] Roll Flutter Engine from 9789dbc2ec3f to dbb60932a6ab (2 revisions) (flutter/flutter#135694) 2023-09-28 [email protected] Fix TabBarView.viewportFraction change is ignored (flutter/flutter#135590) 2023-09-28 [email protected] Roll Flutter Engine from d9eaebd05851 to 9789dbc2ec3f (2 revisions) (flutter/flutter#135688) 2023-09-28 [email protected] Added option to disable [NavigationDestination]s ([NavigationBar] destination widget) (flutter/flutter#132361) 2023-09-28 98614782 auto-submit[bot]@users.noreply.github.com Reverts "Marks Windows module_custom_host_app_name_test to be unflaky" (flutter/flutter#135692) 2023-09-28 [email protected] � Add more fields to `RefreshProgressIndicator` (flutter/flutter#135207) 2023-09-28 [email protected] Roll Flutter Engine from 82b69dadc07a to d9eaebd05851 (1 revision) (flutter/flutter#135679) 2023-09-28 [email protected] Add API to read flavor from framework at run time (flutter/flutter#134179) 2023-09-28 [email protected] Marks Windows module_custom_host_app_name_test to be unflaky (flutter/flutter#135567) 2023-09-28 [email protected] [web] fix: do not call onSubmitted of TextField when switching browser tabs on mobile web (flutter/flutter#134870) 2023-09-28 [email protected] Roll Packages from 21c2ebb to c070b0a (3 revisions) (flutter/flutter#135676) 2023-09-28 [email protected] Fix `RangeSlider` throws an exception in a `ListView` (flutter/flutter#135667) 2023-09-28 [email protected] Roll Flutter Engine from d09c2dbe2292 to 82b69dadc07a (2 revisions) (flutter/flutter#135675) 2023-09-28 [email protected] Roll Flutter Engine from 495955a3b5de to d09c2dbe2292 (1 revision) (flutter/flutter#135669) 2023-09-28 [email protected] Revert "Upload generated frame-request-pending stats" (flutter/flutter#135672) 2023-09-28 [email protected] Upload generated frame-request-pending stats (flutter/flutter#135645) 2023-09-28 [email protected] Roll Flutter Engine from 937bf0432214 to 495955a3b5de (1 revision) (flutter/flutter#135665) 2023-09-28 [email protected] Roll Flutter Engine from d2540d87fd96 to 937bf0432214 (1 revision) (flutter/flutter#135660) 2023-09-28 [email protected] Roll Flutter Engine from c47faed53afe to d2540d87fd96 (2 revisions) (flutter/flutter#135652) 2023-09-28 [email protected] Update `TextField.style` documentation for Material 3 (flutter/flutter#135556) 2023-09-28 [email protected] Roll Flutter Engine from 44aef2e61718 to c47faed53afe (1 revision) (flutter/flutter#135647) 2023-09-28 [email protected] Manual roll Flutter Engine from be32dcc9117a to 44aef2e61718 (4 revisions) (flutter/flutter#135646) 2023-09-28 [email protected] Manual roll Flutter Engine from f70f65f7a622 to be32dcc9117a (31 revisions) (flutter/flutter#135637) 2023-09-28 [email protected] Implement SelectionArea single click/tap gestures (flutter/flutter#132682) 2023-09-27 [email protected] Support ensureVisible/showOnScreen/showInViewport for 2D Scrolling (flutter/flutter#135182) 2023-09-27 [email protected] made top level if checks gaurd clauses (flutter/flutter#135070) 2023-09-27 [email protected] Fix `SearchAnchor`'s search view isn't updated when the theme changes & widgets inside the search view do not inherit local themes (flutter/flutter#132749) 2023-09-27 [email protected] Config changes for linux coverage. (flutter/flutter#135604) 2023-09-27 [email protected] Roll Packages from 619af75 to 21c2ebb (6 revisions) (flutter/flutter#135602) ...
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
…tination widget) (flutter#132361) This PR adds a new option in the NavigationDestination api (the destination widget for the NavigationBar) allowing it to be disabled. As the issue states this PR is the NavigationBar's version of these two PRs (flutter#132349 and flutter#127113) * flutter#132359
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2023
…onBar] destination widget) (flutter/flutter#132361)
HugoOlthof
pushed a commit
to moneybird/packages
that referenced
this pull request
Dec 13, 2023
…r#5036) Roll Flutter from ff4a0f676f41 to 57b5c3cda000 (47 revisions) flutter/flutter@ff4a0f6...57b5c3c 2023-09-29 [email protected] Roll Packages from c070b0a to d0e9a0e (5 revisions) (flutter/flutter#135753) 2023-09-29 [email protected] Roll Flutter Engine from db4d3b5b3f59 to c52251a8b2d0 (1 revision) (flutter/flutter#135748) 2023-09-29 [email protected] Roll Flutter Engine from 8b4e633c65eb to db4d3b5b3f59 (2 revisions) (flutter/flutter#135745) 2023-09-29 [email protected] Roll Flutter Engine from 09130bf5be97 to 8b4e633c65eb (1 revision) (flutter/flutter#135744) 2023-09-29 [email protected] Roll Flutter Engine from ccb30585d3f3 to 09130bf5be97 (1 revision) (flutter/flutter#135741) 2023-09-29 [email protected] Roll Flutter Engine from 2052515c44f3 to ccb30585d3f3 (1 revision) (flutter/flutter#135737) 2023-09-29 [email protected] Update localizations. (flutter/flutter#135691) 2023-09-29 [email protected] Roll Flutter Engine from 485543c6765a to 2052515c44f3 (4 revisions) (flutter/flutter#135732) 2023-09-29 54558023 [email protected] Add arch property for windows_arm64 platform (flutter/flutter#135725) 2023-09-29 [email protected] [flutter_tools] remove VmService screenshot for native devices. (flutter/flutter#135462) 2023-09-29 [email protected] Pin leak_tracker before publishing breaking change. (flutter/flutter#135720) 2023-09-28 [email protected] Roll Flutter Engine from cc7c3c1f0f41 to 485543c6765a (8 revisions) (flutter/flutter#135717) 2023-09-28 [email protected] Remove assertions on getOffsetToReveal (flutter/flutter#135634) 2023-09-28 [email protected] Marks Linux_android flutter_gallery__start_up_delayed to be unflaky (flutter/flutter#135565) 2023-09-28 [email protected] Roll Flutter Engine from dbb60932a6ab to cc7c3c1f0f41 (2 revisions) (flutter/flutter#135701) 2023-09-28 [email protected] [tool] fallback to sigkill when closing Chromium (flutter/flutter#135521) 2023-09-28 137456488 [email protected] Roll pub packages (flutter/flutter#135455) 2023-09-28 [email protected] Roll Flutter Engine from 9789dbc2ec3f to dbb60932a6ab (2 revisions) (flutter/flutter#135694) 2023-09-28 [email protected] Fix TabBarView.viewportFraction change is ignored (flutter/flutter#135590) 2023-09-28 [email protected] Roll Flutter Engine from d9eaebd05851 to 9789dbc2ec3f (2 revisions) (flutter/flutter#135688) 2023-09-28 [email protected] Added option to disable [NavigationDestination]s ([NavigationBar] destination widget) (flutter/flutter#132361) 2023-09-28 98614782 auto-submit[bot]@users.noreply.github.com Reverts "Marks Windows module_custom_host_app_name_test to be unflaky" (flutter/flutter#135692) 2023-09-28 [email protected] ð��� Add more fields to `RefreshProgressIndicator` (flutter/flutter#135207) 2023-09-28 [email protected] Roll Flutter Engine from 82b69dadc07a to d9eaebd05851 (1 revision) (flutter/flutter#135679) 2023-09-28 [email protected] Add API to read flavor from framework at run time (flutter/flutter#134179) 2023-09-28 [email protected] Marks Windows module_custom_host_app_name_test to be unflaky (flutter/flutter#135567) 2023-09-28 [email protected] [web] fix: do not call onSubmitted of TextField when switching browser tabs on mobile web (flutter/flutter#134870) 2023-09-28 [email protected] Roll Packages from 21c2ebb to c070b0a (3 revisions) (flutter/flutter#135676) 2023-09-28 [email protected] Fix `RangeSlider` throws an exception in a `ListView` (flutter/flutter#135667) 2023-09-28 [email protected] Roll Flutter Engine from d09c2dbe2292 to 82b69dadc07a (2 revisions) (flutter/flutter#135675) 2023-09-28 [email protected] Roll Flutter Engine from 495955a3b5de to d09c2dbe2292 (1 revision) (flutter/flutter#135669) 2023-09-28 [email protected] Revert "Upload generated frame-request-pending stats" (flutter/flutter#135672) 2023-09-28 [email protected] Upload generated frame-request-pending stats (flutter/flutter#135645) 2023-09-28 [email protected] Roll Flutter Engine from 937bf0432214 to 495955a3b5de (1 revision) (flutter/flutter#135665) 2023-09-28 [email protected] Roll Flutter Engine from d2540d87fd96 to 937bf0432214 (1 revision) (flutter/flutter#135660) 2023-09-28 [email protected] Roll Flutter Engine from c47faed53afe to d2540d87fd96 (2 revisions) (flutter/flutter#135652) 2023-09-28 [email protected] Update `TextField.style` documentation for Material 3 (flutter/flutter#135556) 2023-09-28 [email protected] Roll Flutter Engine from 44aef2e61718 to c47faed53afe (1 revision) (flutter/flutter#135647) 2023-09-28 [email protected] Manual roll Flutter Engine from be32dcc9117a to 44aef2e61718 (4 revisions) (flutter/flutter#135646) 2023-09-28 [email protected] Manual roll Flutter Engine from f70f65f7a622 to be32dcc9117a (31 revisions) (flutter/flutter#135637) 2023-09-28 [email protected] Implement SelectionArea single click/tap gestures (flutter/flutter#132682) 2023-09-27 [email protected] Support ensureVisible/showOnScreen/showInViewport for 2D Scrolling (flutter/flutter#135182) 2023-09-27 [email protected] made top level if checks gaurd clauses (flutter/flutter#135070) 2023-09-27 [email protected] Fix `SearchAnchor`'s search view isn't updated when the theme changes & widgets inside the search view do not inherit local themes (flutter/flutter#132749) 2023-09-27 [email protected] Config changes for linux coverage. (flutter/flutter#135604) 2023-09-27 [email protected] Roll Packages from 619af75 to 21c2ebb (6 revisions) (flutter/flutter#135602) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new option in the NavigationDestination api (the destination widget for the NavigationBar) allowing it to be disabled.
As the issue states this PR is the NavigationBar's version of these two PRs (#132349 and #127113)
Pre-launch Checklist
///).