[flutter_tools] Remove --no-sound-null-safety #3 #123297

christopherfujino · 2023-03-22T22:56:19Z

The previous attempt, #123031, was reverted because some Google-specific workflows relied on being able to build non-null-safe apps.

This re-land leaves the top-level flag, while hiding it and throwing a tool exit if it ever used, unless a new context getter globals.nonNullSafeBuilds evaluates to NonNullSafeBuilds.notAllowed, which will only be provided in Google-specific workflows.

cl/519269413 is the internal fix that will override globals.nonNullSafeBuilds.

This reverts commit 71f115b.

This reverts commit 5ca3f42.

… in context)

andrewkolos

LGTM; waiting for cl/519269413

eliasyishak

LGTM

andrewkolos · 2023-03-28T20:01:03Z

I updated this branch to try to get Google testing unstuck, but now two checks are failing on recently-added Clipboard.getData tests. I get the same failures when running on master (and even the commit that introduced the tests), which is weird because recent PRs have had these tests pass.

Command I'm using to run the tests (from the packages/flutter directory): flutter test test/services/clipboard_test.dart --platform=chrome --web-renderer=canvaskit

…ter/flutter#123297)

This reverts commit 820ec70.

Re-land of #123297 without any of the commits at the end attempting to fix customer-testing. Fixes #118810

[flutter_tools] Remove --no-sound-null-safety #3

Re-land of flutter#123297 without any of the commits at the end attempting to fix customer-testing. Fixes flutter#118810

…ter/flutter#123297)

flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 22, 2023

christopherfujino added 3 commits March 22, 2023 15:59

migrate dev/bots/test.dart

87dd55d

migrate framework test code

e1223a1

migrate executable.dart

5ca3f42

christopherfujino force-pushed the re-land-no-sound-null-safety branch from 6b1c456 to 5ca3f42 Compare March 22, 2023 22:59

christopherfujino changed the title ~~[flutter_tools] Re-land remvoe --no-sound-null-safety #3~~ [flutter_tools] Re-land remove --no-sound-null-safety #3 Mar 22, 2023

flutter-dashboard bot added framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. labels Mar 22, 2023

goderbauer mentioned this pull request Mar 23, 2023

☂️ Prepare for Dart 3 #118837

Closed

23 tasks

christopherfujino added 5 commits March 24, 2023 14:06

foo

71f115b

Revert "foo"

4c7da71

This reverts commit 71f115b.

Revert "migrate executable.dart"

755c3b3

This reverts commit 5ca3f42.

throwToolExit when --no-sound-null-safety provided (unless overridden…

1398b86

… in context)

fix

fdeb0e2

christopherfujino changed the title ~~[flutter_tools] Re-land remove --no-sound-null-safety #3~~ [flutter_tools] Remove --no-sound-null-safety #3 Mar 25, 2023

christopherfujino added 3 commits March 24, 2023 18:22

fix test

e64b4ef

fix test

cb19782

remove null-unsafe test

6e55c1d

christopherfujino mentioned this pull request Mar 25, 2023

Remove option to pass unsound null safety flag in flutter build/run commands #118810

Closed

add two new tests

91709b2

christopherfujino marked this pull request as ready for review March 25, 2023 03:00

christopherfujino requested review from zanderso, andrewkolos and eliasyishak March 25, 2023 03:12

andrewkolos approved these changes Mar 27, 2023

View reviewed changes

eliasyishak approved these changes Mar 28, 2023

View reviewed changes

zanderso approved these changes Mar 28, 2023

View reviewed changes

Merge branch 'master' into re-land-no-sound-null-safety

51cf609

Attempt to fix tests to handle async closure

49a1867

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023

820ec70 [flutter_tools] Remove --no-sound-null-safety flutter#3 (flut…

730b95e

…ter/flutter#123297)

engine-flutter-autoroll mentioned this pull request Mar 30, 2023

Roll Flutter from 12b36de8f7ac to 302c087738a4 (46 revisions) flutter/packages#3593

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023

820ec70 [flutter_tools] Remove --no-sound-null-safety flutter#3 (flut…

948e171

…ter/flutter#123297)

engine-flutter-autoroll mentioned this pull request Mar 30, 2023

Roll Flutter from 12b36de8f7ac to 8c5d223bab70 (49 revisions) flutter/packages#3863

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023

820ec70 [flutter_tools] Remove --no-sound-null-safety flutter#3 (flut…

9555615

…ter/flutter#123297)

engine-flutter-autoroll mentioned this pull request Mar 30, 2023

Roll Flutter from 12b36de8f7ac to 5f7117948072 (50 revisions) flutter/packages#3595

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023

820ec70 [flutter_tools] Remove --no-sound-null-safety flutter#3 (flut…

defb6f9

…ter/flutter#123297)

engine-flutter-autoroll mentioned this pull request Mar 30, 2023

Roll Flutter from 12b36de8f7ac to a28aae918eae (51 revisions) flutter/packages#3597

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023

820ec70 [flutter_tools] Remove --no-sound-null-safety flutter#3 (flut…

7cb2b05

…ter/flutter#123297)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023

820ec70 [flutter_tools] Remove --no-sound-null-safety flutter#3 (flut…

26166a7

…ter/flutter#123297)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023

820ec70 [flutter_tools] Remove --no-sound-null-safety flutter#3 (flut…

16c5a2e

…ter/flutter#123297)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023

820ec70 [flutter_tools] Remove --no-sound-null-safety flutter#3 (flut…

beca6b7

…ter/flutter#123297)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023

820ec70 [flutter_tools] Remove --no-sound-null-safety flutter#3 (flut…

347fcee

…ter/flutter#123297)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023

820ec70 [flutter_tools] Remove --no-sound-null-safety flutter#3 (flut…

3595efe

…ter/flutter#123297)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023

820ec70 [flutter_tools] Remove --no-sound-null-safety flutter#3 (flut…

c9b8e35

…ter/flutter#123297)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023

820ec70 [flutter_tools] Remove --no-sound-null-safety flutter#3 (flut…

df8a33e

…ter/flutter#123297)

reidbaker mentioned this pull request Apr 1, 2023

Add Java-Gradle-AGP validation to flutter analyze #123916

Merged

8 tasks

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023

820ec70 [flutter_tools] Remove --no-sound-null-safety flutter#3 (flut…

f9804c5

…ter/flutter#123297)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023

820ec70 [flutter_tools] Remove --no-sound-null-safety flutter#3 (flut…

1ad839b

…ter/flutter#123297)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023

820ec70 [flutter_tools] Remove --no-sound-null-safety flutter#3 (flut…

acdf66f

…ter/flutter#123297)

CaseyHillers added a commit that referenced this pull request Apr 2, 2023

Revert "[flutter_tools] Remove --no-sound-null-safety #3 (#123297)"

557799b

This reverts commit 820ec70.

CaseyHillers mentioned this pull request Apr 2, 2023

Revert "[flutter_tools] Remove --no-sound-null-safety #3" #123969

Merged

christopherfujino mentioned this pull request Apr 3, 2023

[flutter_tools] Remove --no-sound-null-safety #4 #124039

Merged

christopherfujino deleted the re-land-no-sound-null-safety branch April 3, 2023 17:56

CaseyHillers pushed a commit that referenced this pull request Apr 4, 2023

[flutter_tools] Remove --no-sound-null-safety #4 (#124039)

b2c65ac

Re-land of #123297 without any of the commits at the end attempting to fix customer-testing. Fixes #118810

reidbaker mentioned this pull request Apr 5, 2023

Update getGradleVersion to ignore commented out lines #124260

Merged

8 tasks

exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023

[flutter_tools] Remove --no-sound-null-safety #3 (flutter#123297)

23dd1e7

[flutter_tools] Remove --no-sound-null-safety #3

exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023

[flutter_tools] Remove --no-sound-null-safety #4 (flutter#124039)

178d99b

Re-land of flutter#123297 without any of the commits at the end attempting to fix customer-testing. Fixes flutter#118810

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023

820ec70 [flutter_tools] Remove --no-sound-null-safety flutter#3 (flut…

25dbcfc

…ter/flutter#123297)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023

820ec70 [flutter_tools] Remove --no-sound-null-safety flutter#3 (flut…

53364d7

…ter/flutter#123297)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[flutter_tools] Remove --no-sound-null-safety #3 #123297

[flutter_tools] Remove --no-sound-null-safety #3 #123297

christopherfujino commented Mar 22, 2023 •

edited

Loading

andrewkolos left a comment

eliasyishak left a comment

andrewkolos commented Mar 28, 2023 •

edited

Loading

[flutter_tools] Remove --no-sound-null-safety #3 #123297

[flutter_tools] Remove --no-sound-null-safety #3 #123297

Conversation

christopherfujino commented Mar 22, 2023 • edited Loading

andrewkolos left a comment

Choose a reason for hiding this comment

eliasyishak left a comment

Choose a reason for hiding this comment

andrewkolos commented Mar 28, 2023 • edited Loading

christopherfujino commented Mar 22, 2023 •

edited

Loading

andrewkolos commented Mar 28, 2023 •

edited

Loading