Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fadeDuration back to TextSelectionOverlay #100381

Merged
merged 4 commits into from
Mar 18, 2022
Merged

Add fadeDuration back to TextSelectionOverlay #100381

merged 4 commits into from
Mar 18, 2022

Conversation

chunhtai
Copy link
Contributor

fixes #100343

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Mar 18, 2022
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@chunhtai chunhtai requested a review from justinmc March 18, 2022 17:04
justinmc
justinmc approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Was this removed before without being deprecated?

packages/flutter/lib/src/widgets/text_selection.dart Outdated
/// Controls the fade-in and fade-out animations for the toolbar and handles.
@Deprecated(
'Use `SelectionOverlay.fadeDuration` instead. '
'This feature was deprecated after 2.12.0-4.1.pre.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have an analyzer failure about this deprecated format. Maybe it's just a missing trailing comma here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@chunhtai chunhtai requested a review from Piinks March 18, 2022 17:35
@Hixie
Copy link
Contributor

Hixie commented Mar 18, 2022

Writing a test for this seems simple: just check that the property exists and has the value you expect. :-)

@chunhtai
Copy link
Contributor Author

chunhtai commented Mar 18, 2022 •
edited
Loading

@Hixie I thought the analyzer will complain about using deprecated field in test? Also is it worth it to add a test for a to-be-deprecated field

edit:

nvm it looks like the analyzer won't complain

Piinks
Piinks approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for writing dart fixes!

@chunhtai chunhtai merged commit c98cb4a into flutter:master Mar 18, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 18, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 18, 2022
@engine-flutter-autoroll
c98cb4a Add fadeDuration back to TextSelectionOverlay (flutter/flutte…
4a63b8e 
…r#100381)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 18, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 18, 2022
@engine-flutter-autoroll
c98cb4a Add fadeDuration back to TextSelectionOverlay (flutter/flutte…
71a7277 
…r#100381)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 18, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 18, 2022
@engine-flutter-autoroll
c98cb4a Add fadeDuration back to TextSelectionOverlay (flutter/flutte…
73044bf 
…r#100381)
@Piinks Piinks mentioned this pull request Sep 12, 2023
Merged
8 tasks
auto-submit bot pushed a commit that referenced this pull request Sep 12, 2023
@Piinks
Remove deprecated TextSelectionOverlay.fadeDuration (#134485)
90ae98f 
Part of #133171

This was deprecated in #100381
Th replacement is to use `SelectionOverlay.fadeDuration` instead.
This migration is supported by dart fix. â�
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmc justinmc justinmc approved these changes

@Piinks Piinks Piinks approved these changes

Assignees
No one assigned
Labels
a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Depending on packages which use TextSelectionOverlay.fadeDuration results in build failure
4 participants
@chunhtai @Hixie @justinmc @Piinks