Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge dart:ui_internals into dart:ui #83

Closed
FlutterIssues opened this issue Nov 9, 2015 · 3 comments
Closed

Merge dart:ui_internals into dart:ui #83

FlutterIssues opened this issue Nov 9, 2015 · 3 comments
Assignees
@abarth
Labels
c: API break Backwards-incompatible API changes engine flutter/engine repository. See also e: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels.

Comments

@FlutterIssues
Copy link

Issue by Hixie
Thursday Jul 16, 2015 at 22:34 GMT
Originally opened as https://github.com/flutter/engine/issues/51

From @Hixie on June 18, 2015 19:55

We should move the "take*" functions from dart:internals to dart:sky.

While we're at it, we should probably remove contentAsText() and renderTreeAsText() (since those test obsolete features). This leaves only notifyTestComplete(), at which point we should rename dart:internals to dart:sky.testing or some such.

Copied from original issue: domokit/mojo#254
@FlutterIssues
Copy link
Author

Comment by Hixie
Thursday Jul 16, 2015 at 22:34 GMT

We might want to rename dart:sky_builtin to dart:sky.internals then too.

@FlutterIssues FlutterIssues added engine flutter/engine repository. See also e: labels. c: new feature Nothing broken; request for a new capability labels Nov 9, 2015
@Hixie Hixie changed the title Merge dart:sky.internals into dart:sky Merge dart:ui_internals into dart:ui Nov 11, 2015
@Hixie Hixie added team Infra upgrades, team productivity, code health, technical debt. See also team: labels. and removed c: new feature Nothing broken; request for a new capability labels Dec 16, 2015
@Hixie Hixie added this to the Blue Sky milestone Dec 16, 2015
@Hixie Hixie added the c: API break Backwards-incompatible API changes label Dec 16, 2015
@abarth abarth self-assigned this Feb 1, 2016
@abarth
Copy link
Contributor

abarth commented Feb 13, 2016

flutter/engine#2397

abarth added a commit to abarth/flutter that referenced this issue Feb 13, 2016
@abarth
Remove references to dart:ui_internals
3d51d6a 
This library is being folded into dart:ui.

Fixes flutter#83
@abarth abarth mentioned this issue Feb 13, 2016
Closed
@abarth abarth closed this as completed Feb 13, 2016
abarth added a commit that referenced this issue Feb 13, 2016
@abarth
Remove references to dart:ui_internals
deb9d0b 
This library is being folded into dart:ui.

Fixes #83
@jason-simmons jason-simmons mentioned this issue Jul 21, 2016
Closed
@ppolasek ppolasek mentioned this issue Feb 8, 2017
Closed
@skybrian skybrian mentioned this issue Feb 16, 2017
Closed
@Reagankm Reagankm mentioned this issue Feb 24, 2017
Closed
@jamesgopinath jamesgopinath mentioned this issue Aug 4, 2017
Closed
@apwilson apwilson mentioned this issue Aug 10, 2017
Closed
@arnold-nonstop arnold-nonstop mentioned this issue Sep 29, 2017
Closed
@amirh amirh mentioned this issue Oct 9, 2017
Closed
@PlanovskyJus PlanovskyJus mentioned this issue Nov 3, 2017
Closed
@steele232 steele232 mentioned this issue Nov 9, 2017
Closed
@Hixie Hixie mentioned this issue Dec 11, 2017
Closed
@silverAndroid silverAndroid mentioned this issue Dec 14, 2017
Closed
@Monotoba Monotoba mentioned this issue Dec 28, 2017
Closed
Closed
@ybmeng ybmeng mentioned this issue Feb 28, 2018
Closed
@gorjan-mishevski gorjan-mishevski mentioned this issue Mar 6, 2018
Open
@hamzaehsansatti hamzaehsansatti mentioned this issue Sep 8, 2020
Closed
@flow-rajkarthik flow-rajkarthik mentioned this issue Sep 10, 2020
Closed
@Dawnhan Dawnhan mentioned this issue Sep 15, 2020
Closed
@dahmaular dahmaular mentioned this issue Sep 15, 2020
Closed
@Niroop4444 Niroop4444 mentioned this issue Oct 1, 2020
Closed
@JeetBhattachariya JeetBhattachariya mentioned this issue Oct 8, 2020
Closed
This was referenced Oct 16, 2020
Closed
Closed
Closed
@lv823063712 lv823063712 mentioned this issue Oct 19, 2020
Closed
@right7ctrl right7ctrl mentioned this issue Oct 24, 2020
Closed
@Jiangshan2015 Jiangshan2015 mentioned this issue Oct 30, 2020
Closed
@hasanworks hasanworks mentioned this issue Oct 30, 2020
Closed
@Tony-Akani Tony-Akani mentioned this issue Nov 1, 2020
Closed
@issantech issantech mentioned this issue Nov 23, 2020
Closed
This was referenced Dec 11, 2020
Closed
Closed
@sureace sureace mentioned this issue Jan 13, 2021
Closed
@staminna staminna mentioned this issue Jan 22, 2021
Closed
@yannainghtun-mk yannainghtun-mk mentioned this issue Jan 26, 2021
Closed
@1005274291 1005274291 mentioned this issue Jan 26, 2021
Closed
@praneethpj praneethpj mentioned this issue Jan 29, 2021
Closed
@sravanpabolu sravanpabolu mentioned this issue Feb 11, 2021
Closed
@Marko1994 Marko1994 mentioned this issue Mar 4, 2021
Closed
@bladeofgod bladeofgod mentioned this issue Apr 14, 2021
Open
@SlowGen SlowGen mentioned this issue May 27, 2021
Closed
@akashgk akashgk mentioned this issue Jun 18, 2021
Closed
@94wogus 94wogus mentioned this issue Jul 3, 2021
Open
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@abarth abarth

Labels
c: API break Backwards-incompatible API changes engine flutter/engine repository. See also e: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove references to dart:ui_internals abarth/flutter
3 participants
@abarth @Hixie @FlutterIssues