Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New release tag format (e.g. "1.17.0-dev.0.0") not detected by flutter tool #53688

Closed
christopherfujino opened this issue Mar 31, 2020 · 11 comments · Fixed by #53715
Closed

New release tag format (e.g. "1.17.0-dev.0.0") not detected by flutter tool #53688

christopherfujino opened this issue Mar 31, 2020 · 11 comments · Fixed by #53715
Assignees
@christopherfujino
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
Tools - installer / upgrade review
Milestone
April 2020

Comments

@christopherfujino
Copy link
Member

christopherfujino commented Mar 31, 2020 •
edited
Loading

NOTE: This was fixed with both #53775 and #53715, if cherry-picking the fix include both.

I suspect this is because we use a regex on git tags in the flutter tool to detect tagged releases, which the new tag does not match.

~/git/flutter$ flutter doctor -v
[✓] Flutter (Channel master, v1.16.4-pre.46, on Mac OS X 10.15.3 19D76, locale en-US)
    • Flutter version 1.16.4-pre.46 at /Users/fujino/git/flutter
    • Framework revision 730a440fd5 (12 minutes ago), 2020-03-31 16:26:01 -0400
    • Engine revision 6b09714a2c
    • Dart version 2.8.0 (build 2.8.0-dev.18.0 11d6bc6055)

~/git/flutter$ git tag | grep 'dev'
1.17.0-dev.0.0

UPDATE: The problem code is:

    return parse(_runGit('git describe --match v*.*.* --first-parent --long --tags', processUtils, workingDirectory));
@christopherfujino christopherfujino self-assigned this Mar 31, 2020
@christopherfujino christopherfujino added tool Affects the "flutter" command-line tool. See also t: labels. ⚠ TODAY labels Mar 31, 2020
@christopherfujino
Copy link
Member Author

@tvolkert did you use the roll_dev.dart script (or its internal wrapper) to publish this?

@christopherfujino
Copy link
Member Author

Hmm, I'm guessing this was a manual tag

@jmagman jmagman added this to Awaiting triage in Tools - installer / upgrade review via automation Mar 31, 2020
@christopherfujino christopherfujino moved this from Awaiting triage to Engineer reviewed in Tools - installer / upgrade review Mar 31, 2020
@tvolkert
Copy link
Contributor

Yep, manual tag. (for now - gonna update scripts after I've documented all the changes to the publishing)

@zanderso
Copy link
Member

/cc @jonahwilliams

I don't know if this is one, but I wanted to note that we need to be careful of places where the tool needs to be able to handle both the old and the new version string formats.

@jonahwilliams
Copy link
Member

Could we tag the releases with both naming schemes for now, until the update percolates everywhere? Alternatively, we need to wait up for the tool fix for now

@tvolkert
Copy link
Contributor

I'm gonna wait for the tool fix and mark 1.17.0-dev.0.0 as bad, since it's only on dev for now.

@Hixie Hixie added this to the April 2020 milestone Mar 31, 2020
@christopherfujino christopherfujino mentioned this issue Apr 1, 2020
Merged
13 tasks
@tvolkert
Copy link
Contributor

tvolkert commented Apr 1, 2020

FYI, I'm going to publish another dev release that still contains this bug despite it being TODAY, to at least ensure that our dev build is signed on MacOS.

@christopherfujino
Copy link
Member Author

FYI, I'm going to publish another dev release that still contains this bug despite it being TODAY, to at least ensure that our dev build is signed on MacOS.

SGTM

@christopherfujino christopherfujino mentioned this issue Apr 1, 2020
Merged
13 tasks
@jamesderlin jamesderlin mentioned this issue Apr 2, 2020
Merged
@zanderso
Copy link
Member

zanderso commented Apr 3, 2020

Thanks, Chris!

@pcsosinski pcsosinski mentioned this issue Apr 6, 2020
Merged
@christopherfujino christopherfujino mentioned this issue Apr 7, 2020
Merged
13 tasks
@pcsosinski
Copy link

also need #54217 for CP

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@christopherfujino christopherfujino

Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
Tools - installer / upgrade review
  
Engineer reviewed
Milestone
April 2020
Development

Successfully merging a pull request may close this issue.

Support old and new git release tag formats christopherfujino/flutter
6 participants
@Hixie @zanderso @christopherfujino @jonahwilliams @tvolkert @pcsosinski