Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmarks stop gathering data after passing --no-dds to flutter drive. #153057

Closed
chinmaygarde opened this issue Aug 7, 2024 · 1 comment · Fixed by #153129
Closed

Benchmarks stop gathering data after passing --no-dds to flutter drive. #153057

chinmaygarde opened this issue Aug 7, 2024 · 1 comment · Fixed by #153129
Assignees
@zanderso

Comments

@chinmaygarde
Copy link
Member

The commit in question is fc46534

An example is here. There may be others too but not sure.

Screenshot 2024-08-07 at 2 19 08 PM
@zanderso zanderso mentioned this issue Aug 8, 2024
Merged
@auto-submit auto-submit bot closed this as completed in 76107bd Aug 8, 2024
DBowen33 pushed a commit to DBowen33/flutter that referenced this issue Aug 16, 2024
@zanderso @DBowen33
Re-enable dds for flutter drive tests that use DevTools (flutter#153129)
fed4026 
Fixes flutter#153057
@github-actions GitHub Actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2024
Buchimi pushed a commit to Buchimi/flutter that referenced this issue Sep 2, 2024
@zanderso @Buchimi
Re-enable dds for flutter drive tests that use DevTools (flutter#153129)
e0398c6 
Fixes flutter#153057
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@zanderso zanderso

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-enable dds for flutter drive tests that use DevTools zanderso/flutter
2 participants
@chinmaygarde @zanderso