Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[integration_test] Enable assertions when running with --wasm #151426

Closed
Rexios80 opened this issue Jul 8, 2024 · 7 comments
Closed

[integration_test] Enable assertions when running with --wasm #151426

Rexios80 opened this issue Jul 8, 2024 · 7 comments
Labels
a: tests "flutter test", flutter_test, or one of our tests c: new feature Nothing broken; request for a new capability c: proposal A detailed proposal for a change to Flutter e: wasm Issues related to the wasm build of Flutter Web. f: integration_test The flutter/packages/integration_test plugin P2 Important issues not at the top of the work list platform-web Web applications specifically r: fixed Issue is closed as already fixed in a newer version t: flutter driver "flutter driver", flutter_drive, or a driver test team-tool Owned by Flutter Tool team tool Affects the "flutter" command-line tool. See also t: labels. triaged-tool Triaged by Flutter Tool team

Comments

@Rexios80
Copy link
Member

Rexios80 commented Jul 8, 2024

Use case

Testing

Proposal

Pass the flag to enable assertions when running flutter drive --wasm

Similar issue that was already resolved for the test package: dart-lang/test#2240
@Rexios80 Rexios80 mentioned this issue Jul 8, 2024
Merged
@danagbemava-nc danagbemava-nc added in triage Presently being triaged by the triage team a: tests "flutter test", flutter_test, or one of our tests c: new feature Nothing broken; request for a new capability tool Affects the "flutter" command-line tool. See also t: labels. platform-web Web applications specifically c: proposal A detailed proposal for a change to Flutter f: integration_test The flutter/packages/integration_test plugin e: wasm Issues related to the wasm build of Flutter Web. team-tool Owned by Flutter Tool team t: flutter driver "flutter driver", flutter_drive, or a driver test and removed in triage Presently being triaged by the triage team labels Jul 9, 2024
This was referenced Jul 12, 2024
Open
Merged
@andrewkolos andrewkolos added P2 Important issues not at the top of the work list triaged-tool Triaged by Flutter Tool team labels Jul 16, 2024
@andrewkolos
Copy link
Contributor

fyi @eyebrowsoffire

@Rexios80
Copy link
Member Author

I see this line:

flutter/packages/flutter_tools/lib/src/test/web_test_compiler.dart

Line 239 in 8c17a74

'--extra-compiler-option=--enable-asserts',

Is this not where web integration tests get compiled or is this flag just not working?

@ditman ditman mentioned this issue Jul 24, 2024
Merged
@eyebrowsoffire
Copy link
Contributor

I see this line:

flutter/packages/flutter_tools/lib/src/test/web_test_compiler.dart

Line 239 in 8c17a74

'--extra-compiler-option=--enable-asserts',

Is this not where web integration tests get compiled or is this flag just not working?

To answer your question, web_test_compiler.dart is used only in fluttter test. flutter drive and flutter run go through a different code path.

@eyebrowsoffire
Copy link
Contributor

eyebrowsoffire commented Jul 25, 2024 •
edited

Fixed with #152262

@kevmoo
Copy link
Contributor

kevmoo commented Jul 25, 2024

@Rexios80 – can you confirm this is fixed and close if you're happy?

@Rexios80
Copy link
Member Author

This appears to be working with both flutter run and flutter drive

@danagbemava-nc danagbemava-nc added the r: fixed Issue is closed as already fixed in a newer version label Jul 26, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this issue Jul 31, 2024
@Rexios80
[google_maps_flutter_web] Migrate to google_maps: 8.0.0 (#7077)
b0b4469 
Migrates `google_maps_flutter_web` to `google_maps: ^8.0.0`

Blocked on the following:
- a14n/dart-google-maps#132
- flutter/flutter#151426
- flutter/flutter#145149
- a14n/dart-google-maps#133
- flutter/flutter#151561

Fixes flutter/flutter#148624
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
a: tests "flutter test", flutter_test, or one of our tests c: new feature Nothing broken; request for a new capability c: proposal A detailed proposal for a change to Flutter e: wasm Issues related to the wasm build of Flutter Web. f: integration_test The flutter/packages/integration_test plugin P2 Important issues not at the top of the work list platform-web Web applications specifically r: fixed Issue is closed as already fixed in a newer version t: flutter driver "flutter driver", flutter_drive, or a driver test team-tool Owned by Flutter Tool team tool Affects the "flutter" command-line tool. See also t: labels. triaged-tool Triaged by Flutter Tool team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kevmoo @Rexios80 @andrewkolos @eyebrowsoffire @danagbemava-nc