Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use singular static const for minimum iOS/macOS version where possible #145104

Open
vashworth opened this issue Mar 13, 2024 · 1 comment
Open

Use singular static const for minimum iOS/macOS version where possible #145104

vashworth opened this issue Mar 13, 2024 · 1 comment
Labels
c: tech-debt Technical debt, code quality, testing, etc. fyi-tool For the attention of Flutter Tool team P2 Important issues not at the top of the work list platform-ios iOS applications specifically team-ios Owned by iOS platform team tool Affects the "flutter" command-line tool. See also t: labels. triaged-ios Triaged by iOS platform team

Comments

@vashworth
Copy link
Contributor

vashworth commented Mar 13, 2024 •
edited

The minimum iOS/macOS deployment version is hardcoded in a bunch of different places within the tool. It would be nice if we had a single const we can use everywhere.

Would also be nice if we could make it a variable in the templates so we don't have to change each template manually.

Here's some examples of places it's used:

https://github.com/flutter/flutter/pull/140823/files
@vashworth vashworth added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. team-ios Owned by iOS platform team fyi-tool For the attention of Flutter Tool team P2 Important issues not at the top of the work list c: tech-debt Technical debt, code quality, testing, etc. labels Mar 13, 2024
@jmagman
Copy link
Member

jmagman commented Mar 13, 2024

1 for doing this in the tool and templates. The dev and example changes are annoying and add lots of files, but I usually use them as proof that the version migrator is doing what I expect.

@mossmana mossmana added the triaged-ios Triaged by iOS platform team label Mar 13, 2024
@jmagman jmagman mentioned this issue May 16, 2024
Merged
9 tasks
@dcharkes dcharkes mentioned this issue Jul 8, 2024
Merged
9 tasks
auto-submit bot pushed a commit that referenced this issue Jul 9, 2024
@dcharkes
[deps] Roll dart-lang/native packages (#151403)
9ab8b6e 
Pass in the minimum iOS and MacOS version.

Roll dart-lang/native deps.

Related issues:

* #145104
* Relevant discussion: #148504
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: tech-debt Technical debt, code quality, testing, etc. fyi-tool For the attention of Flutter Tool team P2 Important issues not at the top of the work list platform-ios iOS applications specifically team-ios Owned by iOS platform team tool Affects the "flutter" command-line tool. See also t: labels. triaged-ios Triaged by iOS platform team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mossmana @jmagman @vashworth