Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web] drawRect benchmark regressed for Skwasm #135167

Closed
yjbanov opened this issue Sep 20, 2023 · 2 comments
Closed

[web] drawRect benchmark regressed for Skwasm #135167

yjbanov opened this issue Sep 20, 2023 · 2 comments
Labels
e: web_skwasm Skwasm rendering backend for web engine flutter/engine repository. See also e: labels. platform-web Web applications specifically team-web Owned by Web platform team

Comments

@yjbanov yjbanov added engine flutter/engine repository. See also e: labels. platform-web Web applications specifically e: web_skwasm Skwasm rendering backend for web team-web Owned by Web platform team labels Sep 20, 2023
@eyebrowsoffire
Copy link
Contributor

This is probably expected actually, with flutter/engine#46061. I think we might have been cheating the numbers a bit since the platform view changes went in, because what ended up happening is that when the web worker was backed up, we just dropped frames which looks really fast on the UI thread.

If you zoom out a bit on the graph, you can see that it's just returning to the same level that it was before the platform views change.

I really do need to add some measurements to the benchmarks for dropped frames and for total end-to-end render time.

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
e: web_skwasm Skwasm rendering backend for web engine flutter/engine repository. See also e: labels. platform-web Web applications specifically team-web Owned by Web platform team
Projects
None yet
Development

No branches or pull requests

2 participants