-
Notifications
You must be signed in to change notification settings - Fork 27.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[web] drawRect benchmark regressed for Skwasm #135167
Comments
This is probably expected actually, with flutter/engine#46061. I think we might have been cheating the numbers a bit since the platform view changes went in, because what ended up happening is that when the web worker was backed up, we just dropped frames which looks really fast on the UI thread. If you zoom out a bit on the graph, you can see that it's just returning to the same level that it was before the platform views change. I really do need to add some measurements to the benchmarks for dropped frames and for total end-to-end render time. |
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
Reported by Skia Perf: https://flutter-flutter-perf.skia.org/e/?keys=Xed2eff54443a26af4263ce51cdfc1509&selected=commit=36940&name=%2Carch%3Dintel%2Cbranch%3Dmaster%2Cconfig%3Ddefault%2Cdevice_type%3Dnone%2Cdevice_version%3Dnone%2Chost_type%3Dlinux%2Csub_result%3Ddraw_rect_variable_paint.skwasm.drawFrameDuration.average%2Ctest%3Dweb_benchmarks_skwasm%2C&xbaroffset=36940
Happened on this engine roll: 07e70a4
The text was updated successfully, but these errors were encountered: