Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google testing failure missing triage info #134668

Closed
keyonghan opened this issue Sep 13, 2023 · 21 comments
Closed

Google testing failure missing triage info #134668

keyonghan opened this issue Sep 13, 2023 · 21 comments
Assignees
Labels
fyi-infra For the attention of Infrastructure team P1 High-priority issues at the top of the work list team-release Owned by Release team

Comments

@keyonghan
Copy link
Contributor

Example RP: #134637

Screenshot 2023-09-13 at 9 16 08 AM

By clicking details, here is the check run page:
https://github.com/flutter/flutter/pull/134637/checks?check_run_id=16761209576

The View more details on Flutter Roll on Borg however directs to the wiki page as well.

Not sure how to debug this failure.

@keyonghan
Copy link
Contributor Author

@XilaiZhang Could you help take a look?

@keyonghan keyonghan added the team-infra Owned by Infrastructure team label Sep 13, 2023
@keyonghan keyonghan changed the title Google testing failure Google testing failure missing triage info Sep 13, 2023
@ricardoamador
Copy link
Contributor

https://github.com/flutter/flutter/wiki/Understanding-Google-Testing#my-cl-reached-max-number-of-retry-why-and-how-do-i-resolve-this

This is concerning as the only solution offered is to ask a Googler to investigate or follow the solutions below:

  1. rebase and ignore google testing which it looks like you cannot or
  2. wait for commits to catch up and hope the conflict is resolved then resubmit or
  3. manually override if you are a Googler, which you can no longer do.

Can we revert this functionality at this time?

@ricardoamador ricardoamador added the fyi-release For the attention of Release team label Sep 13, 2023
@ricardoamador
Copy link
Contributor

ricardoamador commented Sep 13, 2023

Some more examples of this:
#134629
#134628
#134607
#134596
#134590

@keyonghan
Copy link
Contributor Author

Marking as P1 considering high impact but there is a workaround to reset the test status considering this is a false alarm.

@keyonghan keyonghan added the P1 High-priority issues at the top of the work list label Sep 13, 2023
@keyonghan keyonghan added team-release Owned by Release team fyi-infra For the attention of Infrastructure team and removed team-infra Owned by Infrastructure team fyi-release For the attention of Release team labels Sep 13, 2023
@XilaiZhang
Copy link
Contributor

sent cl/565087659 for review and put more context in #134637 (comment)

@vashworth
Copy link
Contributor

I have a couple PRs (#134493, #134542) that are having this issue to. Will overriding the status even work if FroB says it's "Deleted" and there's no CL?

@XilaiZhang
Copy link
Contributor

yes it would work even if its deleted and theres no cl

@vashworth
Copy link
Contributor

vashworth commented Sep 13, 2023

I tried overriding the Google testing status in FroB and it worked temporarily (said it was passing in the Github checks), but when it tried to autosubmit, it failed with message

auto label is removed for flutter/flutter/134493, due to - The status or check suite [Google testing](https://github.com/flutter/flutter/wiki/Understanding-Google-Testing#my-cl-reached-max-number-of-retry-why-and-how-do-i-resolve-this) has failed. Please fix the issues identified (or deflake) before re-applying this label.

#134493

@XilaiZhang
Copy link
Contributor

umm i tried the same with autosubmit but for some reasons autosubmit merged it. Would be great if you could file a bug and document what happened. thank you!

@ricardoamador
Copy link
Contributor

Latency in reporting the status?

@christopherfujino
Copy link
Member

Latency in reporting the status?

It went from red -> green -> red again? and persisted red, until Xilai overrode it a second time from FRoB.

@ricardoamador
Copy link
Contributor

Latency in reporting the status?

It went from red -> green -> red again? and persisted red, until Xilai overrode it a second time from FRoB.

I did not know that.

@christopherfujino
Copy link
Member

This happened again on #134590 cc @XilaiZhang

@christopherfujino
Copy link
Member

christopherfujino commented Sep 13, 2023

I will file a separate issue for the check going from green back to red: #134684 public, with cross-link to Google-internal bug.

@ricardoamador
Copy link
Contributor

Isn't that part of this issue? Also what is the work around here then? Do you need to go on Frob and toggle the status to land the PR? I am assuming you do not since you can squash and merge in flutter.

@christopherfujino
Copy link
Member

Isn't that part of this issue? Also what is the work around here then?

If you're referring to #134684, it is not obvious to me that it is the same issue as this one. I will defer to you however if you think it is the same issue.

@ricardoamador
Copy link
Contributor

@christopherfujino no I am fine with this, I thought the actual issue was the one you pointed out. My mistake I thought there were two issues beyond the missing triage info. Please keep it open.

@drewroengoogle
Copy link
Contributor

Hi @XilaiZhang, any updates on this? Just caught up on the thread

@XilaiZhang
Copy link
Contributor

Yeah i sent updates in the PSA on Saturday

@drewroengoogle
Copy link
Contributor

Gotcha. Thanks! I will close this, but feel free to reopen if necessary.

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fyi-infra For the attention of Infrastructure team P1 High-priority issues at the top of the work list team-release Owned by Release team
Projects
Archived in project
Development

No branches or pull requests

6 participants