I tried to get the engine side fix working on Friday, but ran into some issues with some stuff we're doing in one of our unit tests. I'm not 100% sure what's going on, but I think there are some subtle differences between allowInterop and the toJS function conversion that don't interact well with some admittedly weird stuff we are doing in our unit tests. I'll try to get a more definitive answer today.

In the meantime I suggest we land the revert on the Dart SDK side ASAP to unblock the roller, and reland it after I am confident we have an engine-side fix that works properly.

revert reland sgtm, just in case you needed an extra 1 I approved the revert CL.

Following the revert, the Dart -> Engine roll is still failing flutter/engine#45683. I see many tests failing with:

Failed to load "clip_op_golden_test.dart": Failed to fetch and instantiate wasm module: CompileError: WebAssembly.compileStreaming(): Compiling function #7973:"Highlighter. constructor body" failed: call[0] expected type (ref 580), found local.get of type (ref 51) @ 1136077

As an update, I have a PR out on the engine side to prepare things for the reland of the dart changes that make JS interop declarations more strict about what types can be used: flutter/engine#45668

The other failure Zach posted about above seems like a separate issue. I will try to figure out the breaking dart change in a bit.

I have a revert that should resolve the remaining issues blocking the dart -> engine roll: https://dart-review.googlesource.com/c/sdk/ /325445

Also, flutter/engine#45668 just landed, and I think we can at least attempt a roll to dart 3.2.0-140.0, which is before the other breaking change.

Can this be closed? Looks like the dart rollers are running now.

Yes.

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.