-
Notifications
You must be signed in to change notification settings - Fork 27.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[app_extension_safe] Add integration tests for extension safe framework #124292
Closed
Tracked by
#124287
cyanglaz opened this issue
Apr 6, 2023
· 2 comments
· Fixed by flutter/engine#46283, flutter/engine#46328 or flutter/engine#46329
Closed
Tracked by
#124287
[app_extension_safe] Add integration tests for extension safe framework #124292
cyanglaz opened this issue
Apr 6, 2023
· 2 comments
· Fixed by flutter/engine#46283, flutter/engine#46328 or flutter/engine#46329
Labels
P2
Important issues not at the top of the work list
platform-ios
iOS applications specifically
platform-mac
Building on or for macOS specifically
team-ios
Owned by iOS platform team
triaged-ios
Triaged by iOS platform team
Comments
12 tasks
8 tasks
This can be done in the scenario app. |
auto-submit bot
pushed a commit
to flutter/engine
that referenced
this issue
Sep 26, 2023
…46283) Directly use "flutter_assets" as the default path to find the asset path, this works for app extension when the bundle is unloaded. This PR also adds integration tests for app extensions, which also tests the asset path. Fixes flutter/flutter#124292 [C , Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Merged
8 tasks
auto-submit bot
added a commit
to flutter/engine
that referenced
this issue
Sep 27, 2023
…d bundle" (#46328) Reverts #46283 Initiated by: CaseyHillers This change reverts the following previous change: Directly use "flutter_assets" as the default path to find the asset path, this works for app extension when the bundle is unloaded. This PR also adds integration tests for app extensions, which also tests the asset path. Fixes flutter/flutter#124292 [C , Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
8 tasks
auto-submit bot
pushed a commit
to flutter/engine
that referenced
this issue
Sep 28, 2023
#46329) Relands #46283 The original PR had a bug where the relative assets path is reset after not being found in the `bundle`. It should not be reset unless it was not found inside the info.plist in `bundle` Fixes flutter/flutter#124292 [C , Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
harryterkelsen
pushed a commit
to flutter/engine
that referenced
this issue
Oct 23, 2023
…46283) Directly use "flutter_assets" as the default path to find the asset path, this works for app extension when the bundle is unloaded. This PR also adds integration tests for app extensions, which also tests the asset path. Fixes flutter/flutter#124292 [C , Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
harryterkelsen
pushed a commit
to flutter/engine
that referenced
this issue
Oct 23, 2023
…d bundle" (#46328) Reverts #46283 Initiated by: CaseyHillers This change reverts the following previous change: Directly use "flutter_assets" as the default path to find the asset path, this works for app extension when the bundle is unloaded. This PR also adds integration tests for app extensions, which also tests the asset path. Fixes flutter/flutter#124292 [C , Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
harryterkelsen
pushed a commit
to flutter/engine
that referenced
this issue
Oct 23, 2023
#46329) Relands #46283 The original PR had a bug where the relative assets path is reset after not being found in the `bundle`. It should not be reset unless it was not found inside the info.plist in `bundle` Fixes flutter/flutter#124292 [C , Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
P2
Important issues not at the top of the work list
platform-ios
iOS applications specifically
platform-mac
Building on or for macOS specifically
team-ios
Owned by iOS platform team
triaged-ios
Triaged by iOS platform team
Add integration tests in flutter/flutter for extension safe framework:
From design doc: https://flutter.dev/go/app-extensions
In the framework repo, a non-Flutter iOS app implementing a share sheet will be added to the framework integration test directory to serve as the reliable “host app”. This will exercise a new Flutter integration test app with the Share sheet implemented. A test script will install the Flutter app (and thus the share plugin), and a XCUITest will launch the host app, navigate to the share sheet, and select the Flutter app share option. Basic functionality in the Flutter share extension will be smoke tested.
part of #124287
The text was updated successfully, but these errors were encountered: