Re-enable dds for flutter drive tests that use DevTools

flutter · Aug 8, 2024 · 1ef160c · 1ef160c
1 parent cb9b2f7
commit 1ef160c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/dev/devicelab/lib/framework/utils.dart b/dev/devicelab/lib/framework/utils.dart
@@ -433,6  433,9 @@ Future<String> eval(
   List<String> arguments, {
   Map<String, String>? environment,
   bool canFail = false, // as in, whether failures are ok. False means that they are fatal.
   bool driveWithDds = false,  // `flutter drive` tests should generally have dds disabled.
                               // The exception is tests that also exercise DevTools, such as
                               // DevToolsMemoryTest in perf_tests.dart.
   String? workingDirectory,
   StringBuffer? stdout, // if not null, the stdout will be written here
   StringBuffer? stderr, // if not null, the stderr will be written here
@@ -478,9  481,9 @@ List<String> _flutterCommandArgs(String command, List<String> options) {
         '5',
       ],
 
-    // DDS should be disabled for flutter drive in CI.
     // DDS should generally be disabled for flutter drive in CI.
     // See https://github.com/flutter/flutter/issues/152684.
-    if (command == 'drive') '--no-dds',
     if (command == 'drive' && !driveWithDds) '--no-dds',
 
     if (command == 'drive' && hostAgent.dumpDirectory != null) ...<String>[
       '--screenshot',

diff --git a/dev/devicelab/lib/tasks/perf_tests.dart b/dev/devicelab/lib/tasks/perf_tests.dart
@@ -2160,6  2160,7 @@ class DevToolsMemoryTest {
 
       await flutter(
         'drive',
         driveWithDds: true,
         options: <String>[
           '-d', _device.deviceId,
           '--profile',