[skwasm] Fix platform view occlusion logic. #54061
Open
65
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjbanov
approved these changes
Jul 24, 2024
|
|
||
| @override | ||
| ui.Rect inverseMapRect(ui.Rect rect) => rect; | ||
| ui.Rect mapRect(ui.Rect contentRect) => (filter as SceneImageFilter).filterBounds(contentRect); |
There was a problem hiding this comment.
Should we cast it in the constructor so we don't have to cast on every usage?
| final Matrix4 matrix = getMatrix()..invert(); | ||
| return matrix.transformRect(rect); | ||
| } | ||
| ui.Rect mapRect(ui.Rect contentRect) => getMatrix().transformRect(contentRect); |
There was a problem hiding this comment.
Is the matrix immutable? If so, can we create the matrix in the constructor and reuse it when rendering?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The occlusion rectangle for platform views was going through this
inverseMapRectcode path, which actually was giving us the wrong results. The operations should just be doing the normal transformation on the rectangles to get the right result. It actually turns out we don't need the inverse mapping function, so I removed it, and I renamed the somewhat confusingly namedcullRectfunction tomapRectwhich I think makes a bit more sense.This should resolve flutter/flutter#152139