[web] Set touch-action:none in embedded views. (#53945) #54007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds `touch-action:none` to `flutter-view` elements, so the browser lets the flutter engine fully handle all touch gestures. This fix is more delicate than the first approach, which broke some merged taps when accessibility/semantics are enabled. ## Issues * Found while testing: flutter/flutter#130950 * "More correct" fix for: flutter#53647 ## Demos * Flutter scroll: https://dit-multiview-scroll.web.app * Semantics: https://dit-tests.web.app * Scrollable platform views: https://dit-multiview-tests.web.app [C , Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
|
The tests that are failing seem to be related to some repo tooling; did I pick the right base branch for the CP? |
7 tasks
kevmoo
added
autosubmit
itsjustkevin
added
the
autosubmit
auto-submit
bot
merged commit bb9e2fd
into
flutter:flutter-3.24-candidate.0
26 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
touch-action:nonetoflutter-viewelements, so the browser lets the flutter engine fully handle all touch gestures.This fix is more delicate than the first approach, which broke some merged taps when accessibility/semantics are enabled.
Issues
Demos
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].
Cherry-pick of #53945