Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flutter_releases] Flutter beta 3.24.0-0.1.pre Engine Cherrypicks #54003

Conversation

itsjustkevin
Copy link
Contributor

@itsjustkevin itsjustkevin commented Jul 19, 2024

Flutter beta 3.24.0-0.1.pre Engine

Scheduled Cherrypicks

Infrastructure Issues

Tracked in flutter/flutter#152118

@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@itsjustkevin
Copy link
Contributor Author

itsjustkevin commented Jul 19, 2024

linux_host_engine, linux_unopt and mac_host_engine are failing the following command:

/b/s/w/ir/cache/builder/src/out/ci/host_debug_unopt/dart-sdk/bin/dart --disable-dart-dev /b/s/w/ir/cache/builder/src/flutter/tools/clang_tidy/test/header_filter_regex_test.dart
  Command "/b/s/w/ir/cache/builder/src/out/ci/host_debug_unopt/dart-sdk/bin/dart --disable-dart-dev /b/s/w/ir/cache/builder/src/flutter/tools/clang_tidy/test/header_filter_regex_test.dart" exited with code 255.

I am not entirely sure if these test rely on main or the specific branch, and the only recent commit that I can find that may be related is: 8bcf638

cherry-picking for science, will revert afterward.

Any ideas @christopherfujino?

CC: @matanlurey

matanlurey and others added 2 commits July 19, 2024 15:57
…3539)

... and use it in `engine_tool` to prove everything is working, i.e. on CI and elsewhere.

Partial work towards flutter/flutter#147883.
Supersedes and closes flutter#51782 (which was a prototype).

See also:
- https://flutter.dev/go/pub-workspace, the design doc on the feature.
- dart-lang/pub-dev#7762, an example PR.

I'll probably end up moving the inline docs in `pubspec.yaml` to a `docs/*.md` once that's a thing.
@christopherfujino
Copy link
Member

We should add a failure reason to this expectation: 8bcf638#diff-4b985d2a9688539b821af5a865e52e7e4eb2ef4cb6784229ef304feb33c7099dR68

@zanderso
Copy link
Member

My guess would be that this test is getting confused due to buildmoot-related directory shifting combined with infra caching issues(?). But yeah this test should definitely print more info when it fails.

@itsjustkevin itsjustkevin added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 22, 2024
@auto-submit auto-submit bot merged commit 5d520f7 into flutter:flutter-3.24-candidate.0 Jul 22, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants