Move top-level packages, and testing/*, to pub workspaces
#53997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdero
reviewed
Jul 22, 2024
|
|
||
| linter: | ||
| rules: | ||
| - public_member_api_docs |
There was a problem hiding this comment.
For the Flutter GPU analyzer failures, would it make sense to keep this old rules file until I'm able to migrate it to the new rules we've agreed on for Flutter Engine Dart files?
|
I am taking this back to a draft so I can land things more piece-meal, as I really don't understand the failures |
|
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. |
auto-submit bot
pushed a commit
that referenced
this pull request
Jul 24, 2024
More incremental version of #53997.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial work towards flutter/flutter#147883.
This should be a no-op, that is, there are no changes to behavior or dependencies as part of this change.