Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race in image_filter_test.dart #53996

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Fix race in image_filter_test.dart #53996

merged 1 commit into from
Jul 18, 2024

Conversation

zanderso
Copy link
Member

@zanderso zanderso requested a review from matanlurey July 18, 2024 17:33
Copy link
Contributor

@matanlurey matanlurey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof. This will be fixed by moving to pkg/test ;)

LGTM!

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 18, 2024
@auto-submit auto-submit bot merged commit 564ded4 into main Jul 18, 2024
27 checks passed
@auto-submit auto-submit bot deleted the zanderso-patch-7 branch July 18, 2024 17:47
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 18, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 18, 2024
…151986)

flutter/engine@8bcf638...564ded4

2024-07-18 [email protected] Fix race in image_filter_test.dart (flutter/engine#53996)
2024-07-18 [email protected] Roll Dart SDK from 7b3c16ac1cf9 to 0f61238a27b0 (1 revision) (flutter/engine#53995)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/ doc/main/autoroll/README.md
TytaniumDev pushed a commit to TytaniumDev/flutter that referenced this pull request Aug 7, 2024
…lutter#151986)

flutter/engine@8bcf638...564ded4

2024-07-18 [email protected] Fix race in image_filter_test.dart (flutter/engine#53996)
2024-07-18 [email protected] Roll Dart SDK from 7b3c16ac1cf9 to 0f61238a27b0 (1 revision) (flutter/engine#53995)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/ doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
…lutter#151986)

flutter/engine@8bcf638...564ded4

2024-07-18 [email protected] Fix race in image_filter_test.dart (flutter/engine#53996)
2024-07-18 [email protected] Roll Dart SDK from 7b3c16ac1cf9 to 0f61238a27b0 (1 revision) (flutter/engine#53995)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/ doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flake in image_filter_test due to non-synchronous test addtion
2 participants