[macOS] Only bundle gen_snapshot_${target_arch} #53971
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
approved these changes
Jul 17, 2024
On most platforms, we support only a single host architecture and a
single target architecture per build. macOS supports both arm64 and
x86_64 host platforms via multi-arch (universal) binaries generated with
the `lipo` tool and as such, we have two gen_snapshot binaries, one for
each target architecture. These binaries are universal binaries named
`gen_snapshot_${target_arch}`. The unqualified `gen_snapshot` binary
used for other platforms is unused on macOS.
This eliminates the unqualified binary from the uploaded bundles used by
the tool.
On most platforms, we support only a single host architecture and a
single target architecture per build. macOS supports both arm64 and
x86_64 host platforms via multi-arch (universal) binaries generated with
the `lipo` tool and as such, we have two gen_snapshot binaries, one for
each target architecture. These binaries are universal binaries named
`gen_snapshot_${target_arch}`. The unqualified `gen_snapshot` binary
used for other platforms is unused on macOS.
This eliminates the unqualified binary from the uploaded bundles used by
the tool.
cbracken
force-pushed
the
mac-remove-unqualified-gen_snapshot
branch
from
b9b216f
to
95bb3f4
Compare
|
This pull request executed golden file tests, but it has not been updated in a while (20 days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. |
|
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. |
|
(PR triage): @cbracken is this still on your radar? |
|
I'll file a proper issue for this, self-assign and then close this once I've collected up the error messages. Thanks for the reminder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On most platforms, we support only a single host architecture and a single target architecture per build. macOS supports both arm64 and x86_64 host platforms via multi-arch (universal) binaries generated with the
lipotool and as such, we have two gen_snapshot binaries, one for each target architecture. These binaries are universal binaries namedgen_snapshot_${target_arch}. The unqualifiedgen_snapshotbinary used for other platforms is unused on macOS.This eliminates the unqualified binary from the uploaded bundles used by the tool.
Cleanup related to:
Issue: flutter/flutter#101138
Issue: flutter/flutter#69157
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.