[Impeller] Switch from AIKS canvas to DL based canvas implementation. #53781
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
You have to get the other tests to pass to see the goldens. |
…nto enable_exp_canvas
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
|
Golden file changes are available for triage from new commit, Click here to view. |
|
Golden file changes are available for triage from new commit, Click here to view. |
|
Golden file changes are available for triage from new commit, Click here to view. |
jonahwilliams
changed the title
|
Golden file changes are available for triage from new commit, Click here to view. |
|
Golden file changes are available for triage from new commit, Click here to view. |
jonahwilliams
added
the
autosubmit
…ions) (#153525) Manual roll requested by [email protected] flutter/engine@971ddd9...8f3f80e 2024-08-15 [email protected] [Impeller] revert experimental canvas. (flutter/engine#54570) 2024-08-15 69794332 [email protected] Fix typo in AppLifecycleState documentation (flutter/engine#54544) 2024-08-15 [email protected] Update RBE troubleshooting (flutter/engine#54568) 2024-08-15 [email protected] [Impeller] Switch from AIKS canvas to DL based canvas implementation. (flutter/engine#53781) 2024-08-15 [email protected] [Impeller] convert aiks blur tests to new canvas. (flutter/engine#54565) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/ doc/main/autoroll/README.md
…ions) (flutter#153525) Manual roll requested by [email protected] flutter/engine@971ddd9...8f3f80e 2024-08-15 [email protected] [Impeller] revert experimental canvas. (flutter/engine#54570) 2024-08-15 69794332 [email protected] Fix typo in AppLifecycleState documentation (flutter/engine#54544) 2024-08-15 [email protected] Update RBE troubleshooting (flutter/engine#54568) 2024-08-15 [email protected] [Impeller] Switch from AIKS canvas to DL based canvas implementation. (flutter/engine#53781) 2024-08-15 [email protected] [Impeller] convert aiks blur tests to new canvas. (flutter/engine#54565) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/ doc/main/autoroll/README.md
…ions) (flutter#153525) Manual roll requested by [email protected] flutter/engine@971ddd9...8f3f80e 2024-08-15 [email protected] [Impeller] revert experimental canvas. (flutter/engine#54570) 2024-08-15 69794332 [email protected] Fix typo in AppLifecycleState documentation (flutter/engine#54544) 2024-08-15 [email protected] Update RBE troubleshooting (flutter/engine#54568) 2024-08-15 [email protected] [Impeller] Switch from AIKS canvas to DL based canvas implementation. (flutter/engine#53781) 2024-08-15 [email protected] [Impeller] convert aiks blur tests to new canvas. (flutter/engine#54565) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/ doc/main/autoroll/README.md
The first part of switching Impeller/Aiks to using the display list instead of re-recording rendering operations. This should eventually let us cut CPU overhead of the raster thread for complex applications, though it should have no impact on GPU performance.
This does introduce a GLES only rendering bug that I haven't had luck tracking down, but is almost certainly due to switching to DL computed depth values. I'd like to handle this as a follow up when we prioritize GLES. flutter/flutter#153504
Part of flutter/flutter#142054