Upgrade Engine Android SDK to 35 #53574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
Failures seem unrelated? Submitting for review |
gmackall
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
Changes lgtm (as long as the pointing to fork for test purpose is removed) - total guess but are these test failures related to the buildmoot effort?
Creating file ./src/flutter/GeneratedPluginRegistrant.java
PASS: ban_generated_plugin_registrant_java failed as expected
Creating file ./src/third_party/GeneratedPluginRegistrant.java
touch: cannot touch '/b/s/w/ir/cache/builder/src/third_party/GeneratedPluginRegistrant.java': No such file or directory
I believe at some point recently the src/third_party directory had reached uselessness (everything migrated out), perhaps the test needs to be changed to not try to create a file in that directory?
cc @matanlurey
It is still valuable but the relative location of the directory changed. I think this should be an updated not removed test. |
|
Landing this buildroot changed blocked by flutter/flutter#152177. |
auto-submit bot
pushed a commit
to flutter/buildroot
that referenced
this pull request
Jul 23, 2024
**DO NOT LAND YET:** Please review flutter/engine#53574 first; will merge this once it is approved. Change engine to use Android 15. Buildroot step of https://github.com/flutter/flutter/blob/master/docs/platforms/android/Upgrading-Engine's-Android-API-version.md to complete flutter/flutter#150215.
reidbaker
approved these changes
Jul 24, 2024
camsim99
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 24, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 24, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 24, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 24, 2024
…152260) flutter/engine@490576d...c2f489d 2024-07-24 [email protected] Fix embedder comments about struct_size (flutter/engine#54077) 2024-07-24 [email protected] share platform view slicing logic across iOS and Android. (flutter/engine#54010) 2024-07-24 [email protected] [skwasm] Fix platform view occlusion logic. (flutter/engine#54061) 2024-07-24 [email protected] Roll Skia from 25f26f673502 to c11932925658 (4 revisions) (flutter/engine#54081) 2024-07-24 43054281 [email protected] Upgrade Engine Android SDK to 35 (flutter/engine#53574) 2024-07-24 [email protected] Roll Skia from a9b1043eb23e to 25f26f673502 (1 revision) (flutter/engine#54079) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/ doc/main/autoroll/README.md
8 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Aug 5, 2024
Updates/corrects steps to update Gradle version used in the engine based on what @gmackall and I did to update the engine's Gradle version in #53574. [C , Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
…lutter#152260) flutter/engine@490576d...c2f489d 2024-07-24 [email protected] Fix embedder comments about struct_size (flutter/engine#54077) 2024-07-24 [email protected] share platform view slicing logic across iOS and Android. (flutter/engine#54010) 2024-07-24 [email protected] [skwasm] Fix platform view occlusion logic. (flutter/engine#54061) 2024-07-24 [email protected] Roll Skia from 25f26f673502 to c11932925658 (4 revisions) (flutter/engine#54081) 2024-07-24 43054281 [email protected] Upgrade Engine Android SDK to 35 (flutter/engine#53574) 2024-07-24 [email protected] Roll Skia from a9b1043eb23e to 25f26f673502 (1 revision) (flutter/engine#54079) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/ doc/main/autoroll/README.md
This was referenced Aug 13, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 14, 2024
Updates the steps based on what I found by working on flutter/engine#54186 and flutter/engine#53574 general cleanup.
DBowen33
pushed a commit
to DBowen33/flutter
that referenced
this pull request
Aug 16, 2024
Updates the steps based on what I found by working on flutter/engine#54186 and flutter/engine#53574 general cleanup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REVIEW BUT DO NOT MERGE: Will merge after flutter/buildroot#870 lands.
1: Updates engine to use Android 35. Part of flutter/flutter#150215.
Engine step of https://github.com/flutter/flutter/blob/master/docs/platforms/android/Upgrading-Engine's-Android-API-version.md.
2: Updates test runner AGP version to 8.5, engine Gradle version to 8.9 to accommodate update.
3: Fixes lint and suppresses deprecation warnings caused by the update. None of the deprecations are unknown by the team (they are handled in the code), but the tests emitted warnings.
Pre-launch Checklist
///).