Add SurfaceProducer.Callback lifecycle hooks
#53280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnmccutchan
requested changes
Jun 7, 2024
matanlurey
requested review from
johnmccutchan and
gmackall
and removed request for
jonahwilliams
gmackall
reviewed
Jun 12, 2024
shell/platform/android/build.gradle
Outdated
| @@ -63,3 63,7 @@ android { | |||
| } | |||
| } | |||
|
|
|||
| dependencies { | |||
| implementation 'androidx.lifecycle:lifecycle-process:2.2.0' | |||
There was a problem hiding this comment.
This shouldn't be necessary - do the new classes not resolve in android studio for you without it?
If they don't resolve without, I may need to revert #50840, I think something about that PR may have messed up how we resolve the android_embedding_dependencies jars
There was a problem hiding this comment.
You know, I'm not sure. I think this was auto-added by IntelliJ. Let me try removing and resyncing.
There was a problem hiding this comment.
It appears to work fine w/o, removing.
matanlurey
added a commit
that referenced
this pull request
Jun 13, 2024
…ndererTest` (#53361) In #53280, I'm adding lifecycle-aware methods to `SurfaceProducer`. That means, in order to test that it WAI, we'll need to be running in a simulated activity, and be able to switch scenario states (i.e. to `RESUMED`). This was mentioned as well in flutter/flutter#133151 as being something we want to do. This PR adds a `FlutterEngineRule`, which allows the creation of a "real" `FlutterEngine` and an `Intent` that can power `AndroidScenarioRule<FlutterActivity>`. I felt bad doing all of this work for a single `@Test`, so I also refactored the rest of the file and cleaned things up a bit. That said, I'm happy to revert or make changes if we liked how things were setup before.
matanlurey
force-pushed
the
surface-producer-lifecycle-148417
branch
from
4865484
to
c8b4446
Compare
matanlurey
changed the title
SurfaceProducer.setOnSurfaceRecreatedCallback lifecycle hookSurfaceProducer.Callback lifecycle hooks
| void setCallback(Callback callback); | ||
|
|
||
| /** Callback invoked by {@link #setCallback(Callback)}. */ | ||
| interface Callback { |
There was a problem hiding this comment.
naming nit: Callbacks?
There was a problem hiding this comment.
johnmccutchan
approved these changes
Jun 24, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 24, 2024
jason-simmons
added a commit
to jason-simmons/flutter
that referenced
this pull request
Jun 24, 2024
Includes updates to Gradle lockfiles required by flutter/engine#53280
jason-simmons
added a commit
to jason-simmons/flutter
that referenced
this pull request
Jun 24, 2024
Includes updates to Gradle lockfiles required by flutter/engine#53280
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 24, 2024
Includes updates to Gradle lockfiles required by flutter/engine#53280
sigurdm
pushed a commit
to sigurdm/flutter
that referenced
this pull request
Jun 26, 2024
Includes updates to Gradle lockfiles required by flutter/engine#53280
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards flutter/flutter#148417.