More correctly name methods regarding event loop that are currently named microtask #50138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…amed microtask Flutter implements the UI isolates message via posting to a UI task queue. That task queue has a primary and a secondary queue. The * primary is used for running tasks resulated to framework (e.g. draw frame) * secondary is used to run Dart event loop messages (e.g. received data on a socket) The Dart semantics requires running microtasks before processing the next event loop message. The way flutter implements by attaching an observer to the secondary queue. Every time a task from the queue is run, all observers are run and one of them is going to run pending microtasks. In some situations the engine pauses the dart event loop. The terminology used in the code is "microtask" when in reality what it means is "event loop". => This PR changes this terminology to reflect what actually happens.
mkustermann
force-pushed
the
microtask-eventloop-terminology
branch
from
aa21207
to
94a3687
Compare
dnfield
approved these changes
Jan 31, 2024
dnfield
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 31, 2024
…urrently named microtask (flutter/engine#50138)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 31, 2024
…142583) flutter/engine@2d2d880...8e7df85 2024-01-31 [email protected] Roll Skia from bf27636582c7 to 1fbb575f968d (1 revision) (flutter/engine#50190) 2024-01-31 [email protected] More correctly name methods regarding event loop that are currently named microtask (flutter/engine#50138) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/ doc/main/autoroll/README.md
lrhn
reviewed
Feb 5, 2024
| @@ -79,8 79,8 @@ class VsyncWaiter : public std::enable_shared_from_this<VsyncWaiter> { | |||
| Callback callback_; | |||
| std::unordered_map<uintptr_t, fml::closure> secondary_callbacks_; | |||
|
|
|||
| void PauseDartMicroTasks(); | |||
| static void ResumeDartMicroTasks(fml::TaskQueueId ui_task_queue_id); | |||
| void PauseDartEventLoopTasks(); | |||
There was a problem hiding this comment.
Should the "Tasks" be removed from the end?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flutter implements the UI isolates message via posting to a UI task queue. That task queue has a primary and a secondary queue. The
The Dart semantics requires running microtasks before processing the next event loop message.
The way flutter implements by attaching an observer to the secondary queue. Every time a task from the queue is run, all observers are run and one of them is going to run pending microtasks.
In some situations the engine pauses the dart event loop. The terminology used in the code is "microtask" when in reality what it means is "event loop".
=> This PR changes this terminology to reflect what actually happens.