Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenGL <4.x does not support stencil-only formats, so delete the TODO #47286

Merged
merged 1 commit into from
Oct 24, 2023
Merged

OpenGL <4.x does not support stencil-only formats, so delete the TODO #47286

merged 1 commit into from
Oct 24, 2023

Conversation

matanlurey
Copy link
Contributor

jonahwilliams
jonahwilliams approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We might need a bug to make sure we do the right thing when we have both a depth and stencil attachment in GLES; avoid creating two separate DEPTH_STENCIL attachments and instead do a similar trick to map both attachments to the same texture.

@matanlurey matanlurey merged commit 5e1c7dc into flutter:main Oct 24, 2023
27 checks passed
@matanlurey matanlurey deleted the impeller-gles-depth-stencil-todo branch October 24, 2023 23:27
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 25, 2023
@engine-flutter-autoroll
5e1c7dcbc OpenGL <4.x does not support stencil-only formats, so delet…
542cbb0 
…e the TODO (flutter/engine#47286)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 25, 2023
@engine-flutter-autoroll
5e1c7dcbc OpenGL <4.x does not support stencil-only formats, so delet…
33e8713 
…e the TODO (flutter/engine#47286)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 25, 2023
@engine-flutter-autoroll
5e1c7dcbc OpenGL <4.x does not support stencil-only formats, so delet…
e350fcf 
…e the TODO (flutter/engine#47286)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 25, 2023
@engine-flutter-autoroll
5e1c7dcbc OpenGL <4.x does not support stencil-only formats, so delet…
eafb982 
…e the TODO (flutter/engine#47286)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 26, 2023
@engine-flutter-autoroll
5e1c7dcbc OpenGL <4.x does not support stencil-only formats, so delet…
d890ea6 
…e the TODO (flutter/engine#47286)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 26, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 26, 2023
@engine-flutter-autoroll
5e1c7dcbc OpenGL <4.x does not support stencil-only formats, so delet…
d4be38d 
…e the TODO (flutter/engine#47286)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 26, 2023
@engine-flutter-autoroll
Roll Flutter Engine from 6e09ee14e244 to 6428ed576841 (38 revisions) (#…
53a5d56 
…137310)

Roll Flutter Engine from 6e09ee14e244 to 6428ed576841 (38 revisions)

flutter/engine@6e09ee1...6428ed5

2023-10-26 [email protected] Revert Dart SDK to 360370ff93b053253343832432f8329a11372ffc (flutter/engine#47326)
2023-10-25 [email protected] Roll Skia from fb979d0ce053 to a5da4435bb5c (1 revision) (flutter/engine#47325)
2023-10-25 [email protected] [Impeller] Cache location in metadata. (flutter/engine#46640)
2023-10-25 [email protected] Roll Skia from 8492914821fa to fb979d0ce053 (1 revision) (flutter/engine#47324)
2023-10-25 737941 [email protected] [Windows] Introduce FlutterWindowsViewController (flutter/engine#47242)
2023-10-25 [email protected] Roll Skia from 773abacc1581 to 8492914821fa (2 revisions) (flutter/engine#47322)
2023-10-25 [email protected] Roll Dart SDK from 73fa7b3e048a to 7745c140d1fe (1 revision) (flutter/engine#47321)
2023-10-25 [email protected] Cleanup Dart package dependencies a bit (flutter/engine#47306)
2023-10-25 [email protected] Roll Skia from d511fa1f1533 to 773abacc1581 (1 revision) (flutter/engine#47312)
2023-10-25 [email protected] Roll Fuchsia Mac SDK from SOv1RJmbyDByvud8D... to kNdyn03p28H7VeMcd... (flutter/engine#47313)
2023-10-25 [email protected] Roll Fuchsia Linux SDK from vX5n99OIWgLX6bObI... to zTq0jH2Y3Fl0uUUSa... (flutter/engine#47309)
2023-10-25 [email protected] Roll Skia from 0748053419cd to d511fa1f1533 (1 revision) (flutter/engine#47308)
2023-10-25 30870216 [email protected] Missed linter argument comment violations (flutter/engine#47310)
2023-10-25 [email protected] [Impeller] Remove use of FML_DISALLOW_<FOO> macros in Impeller. (flutter/engine#47307)
2023-10-25 30870216 [email protected] Adds lint for checking argument commments (flutter/engine#47305)
2023-10-25 [email protected] Roll Dart SDK from 2791495ed583 to 73fa7b3e048a (1 revision) (flutter/engine#47304)
2023-10-25 [email protected] Roll Skia from 4848dd9b5dab to 0748053419cd (2 revisions) (flutter/engine#47302)
2023-10-25 [email protected] Roll Skia from 788eafdcf70d to 4848dd9b5dab (1 revision) (flutter/engine#47301)
2023-10-25 [email protected] Roll Skia from 5c315b761a24 to 788eafdcf70d (1 revision) (flutter/engine#47300)
2023-10-25 [email protected] Roll Skia from 18ad006ec7f9 to 5c315b761a24 (1 revision) (flutter/engine#47299)
2023-10-25 [email protected] Roll Dart SDK from 57661d5dbc1e to 2791495ed583 (1 revision) (flutter/engine#47298)
2023-10-25 [email protected] Roll Skia from 9537c25509ea to 18ad006ec7f9 (1 revision) (flutter/engine#47297)
2023-10-25 [email protected] Roll Fuchsia Mac SDK from YqSO1OByhoexFJSCr... to SOv1RJmbyDByvud8D... (flutter/engine#47296)
2023-10-25 [email protected] Roll Skia from d51d3bcbcacd to 9537c25509ea (1 revision) (flutter/engine#47295)
2023-10-25 [email protected] Roll Skia from f98fc9536c43 to d51d3bcbcacd (1 revision) (flutter/engine#47294)
2023-10-25 [email protected] Roll Fuchsia Linux SDK from tqukMrdJ6j-845-57... to vX5n99OIWgLX6bObI... (flutter/engine#47293)
2023-10-25 [email protected] Roll Skia from 0d4fcf388a6f to f98fc9536c43 (1 revision) (flutter/engine#47292)
2023-10-24 [email protected] [Impeller] Update shader compilation pipeline documentation to detail multi-arch archives. (flutter/engine#47289)
2023-10-24 [email protected] Roll Skia from 076a9dd0094f to 0d4fcf388a6f (2 revisions) (flutter/engine#47290)
2023-10-24 [email protected] OpenGL <4.x does not support stencil-only formats, so delete the TODO (flutter/engine#47286)
2023-10-24 [email protected] [Impeller] Unconditionally dither in gradient shader fragments. (flutter/engine#46746)
2023-10-24 [email protected] Roll Skia from f491209e969d to 076a9dd0094f (1 revision) (flutter/engine#47285)
2023-10-24 [email protected] [Impeller] Add support for multi-rendering-backend fat shader archives. (flutter/engine#47278)
2023-10-24 [email protected] Roll Skia from 502277be15cf to f491209e969d (1 revision) (flutter/engine#47281)
2023-10-24 [email protected] Roll Dart SDK from 360370ff93b0 to 57661d5dbc1e (1 revision) (flutter/engine#47280)
2023-10-24 30870216 [email protected] Migrated away from UnmodifiableUint8ListView (flutter/engine#47276)
2023-10-24 [email protected] Roll Skia from bc90585b0dd4 to 502277be15cf (1 revision) (flutter/engine#47277)
2023-10-24 1961493 [email protected] Reland "Use a single OffscreenCanvas for rendering in CanvasKit (#45744)" (flutter/engine#47241)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from tqukMrdJ6j-8 to zTq0jH2Y3Fl0
  fuchsia/sdk/core/mac-amd64 from YqSO1OByhoex to kNdyn03p28H7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Assignees
No one assigned
Labels
e: impeller
Projects
No open projects
Impeller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Impeller] OpenGLES MSAA Follow-up: Avoid using GL_DEPTH_STENCIL
2 participants
@matanlurey @jonahwilliams