Tighten up ImageReaderPlatformViewRenderTarget code #45889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
johnmccutchan
commented
Sep 15, 2023
johnmccutchan
commented
- Fix a missing Image close in an error path.
- Ensure we close the Image when the TextureEntry is finalized.
- Fix an inconsistency in the maxImages when running on Android < 33.
- Wrap acquireLatestImage in a try block and return a null image instead of crashing the application.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
johnmccutchan
force-pushed
the
tighten_image
branch
from
cc4cba6
to
4d5cc0a
Compare
jason-simmons
approved these changes
Sep 18, 2023
- Fix a missing Image close in an error path. - Ensure we close the Image when the TextureEntry is finalized. - Fix an inconsistency in the maxImages when running on Android < 33. - Wrap acquireLatestImage in a try block and return a null image instead of crashing the application.
johnmccutchan
force-pushed
the
tighten_image
branch
from
4d5cc0a
to
c869ab9
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 19, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 19, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 19, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 19, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 19, 2023
…134998) flutter/engine@e1c784e...589bde9 2023-09-19 [email protected] Roll Skia from 4122791099ce to 744807d740c7 (1 revision) (flutter/engine#46019) 2023-09-19 [email protected] [Android] Add support for setting thread affinity based on core speed. (flutter/engine#45673) 2023-09-19 [email protected] [Impeller] Fix STB backend to account for max texture sizes. (flutter/engine#46010) 2023-09-19 [email protected] [Impeller] Hold the CommandPoolVK at a higher scope. (flutter/engine#46013) 2023-09-19 [email protected] Roll Skia from 0c990ab9e097 to 4122791099ce (19 revisions) (flutter/engine#46016) 2023-09-18 [email protected] Add missing include of SkPath (flutter/engine#45996) 2023-09-18 [email protected] [Impeller] Respect max supported texture size when allocating glyph atlas texture. (flutter/engine#45992) 2023-09-18 [email protected] Roll Fuchsia Mac SDK from 3_Lh8otTpmVuf-Zwb... to qy5FU4y6sx1FscCpd... (flutter/engine#45998) 2023-09-18 [email protected] Revert "[Windows] Update vsync on raster thread (#45310)" (flutter/engine#46000) 2023-09-18 [email protected] Provide a default `--target-variant` for `clang_tidy`. (flutter/engine#45909) 2023-09-18 [email protected] Revert "[ios] use python script to generate extension safe frameworks and code sign them" (flutter/engine#46004) 2023-09-18 [email protected] Disable HardwareBuffer backed Platform Views temporarily (flutter/engine#45986) 2023-09-18 [email protected] Tighten up ImageReaderPlatformViewRenderTarget code (flutter/engine#45889) 2023-09-18 [email protected] [ios] use python script to generate extension safe frameworks and code sign them (flutter/engine#45781) 2023-09-18 [email protected] Bump impeller-cmake to HEAD. (flutter/engine#45953) 2023-09-18 31859944 [email protected] [iOS] Remove selectionDidChange call in UndoManager (flutter/engine#45657) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from 3_Lh8otTpmVu to qy5FU4y6sx1F If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/ doc/main/autoroll/README.md
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
…lutter#134998) flutter/engine@e1c784e...589bde9 2023-09-19 [email protected] Roll Skia from 4122791099ce to 744807d740c7 (1 revision) (flutter/engine#46019) 2023-09-19 [email protected] [Android] Add support for setting thread affinity based on core speed. (flutter/engine#45673) 2023-09-19 [email protected] [Impeller] Fix STB backend to account for max texture sizes. (flutter/engine#46010) 2023-09-19 [email protected] [Impeller] Hold the CommandPoolVK at a higher scope. (flutter/engine#46013) 2023-09-19 [email protected] Roll Skia from 0c990ab9e097 to 4122791099ce (19 revisions) (flutter/engine#46016) 2023-09-18 [email protected] Add missing include of SkPath (flutter/engine#45996) 2023-09-18 [email protected] [Impeller] Respect max supported texture size when allocating glyph atlas texture. (flutter/engine#45992) 2023-09-18 [email protected] Roll Fuchsia Mac SDK from 3_Lh8otTpmVuf-Zwb... to qy5FU4y6sx1FscCpd... (flutter/engine#45998) 2023-09-18 [email protected] Revert "[Windows] Update vsync on raster thread (flutter#45310)" (flutter/engine#46000) 2023-09-18 [email protected] Provide a default `--target-variant` for `clang_tidy`. (flutter/engine#45909) 2023-09-18 [email protected] Revert "[ios] use python script to generate extension safe frameworks and code sign them" (flutter/engine#46004) 2023-09-18 [email protected] Disable HardwareBuffer backed Platform Views temporarily (flutter/engine#45986) 2023-09-18 [email protected] Tighten up ImageReaderPlatformViewRenderTarget code (flutter/engine#45889) 2023-09-18 [email protected] [ios] use python script to generate extension safe frameworks and code sign them (flutter/engine#45781) 2023-09-18 [email protected] Bump impeller-cmake to HEAD. (flutter/engine#45953) 2023-09-18 31859944 [email protected] [iOS] Remove selectionDidChange call in UndoManager (flutter/engine#45657) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from 3_Lh8otTpmVu to qy5FU4y6sx1F If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/ doc/main/autoroll/README.md
harryterkelsen
pushed a commit
that referenced
this pull request
Oct 23, 2023
- Fix a missing Image close in an error path. - Ensure we close the Image when the TextureEntry is finalized. - Fix an inconsistency in the maxImages when running on Android < 33. - Wrap acquireLatestImage in a try block and return a null image instead of crashing the application.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.