-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Lazily allocate RasterCacheItems only when caching is enabled" #45734
Conversation
Prospective revert. Not sure this is right. Need input from @jason-simmons and/or @flar |
Confirmed that the b/298583505 issue does not occur if #45211 is reverted in a local engine build. |
I confirmed that it does reproduce in a local engine build on the commit JUST PRIOR to that PR commit...? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My attempts to reproduce the problem indicated that this change was not suspect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like my reproducing attempts weren't correct so I'm going to defer to Jason on this one.
…134597) flutter/engine@c90fadf...7c78ea2 2023-09-12 [email protected] Revert "Lazily allocate RasterCacheItems only when caching is enabled" (flutter/engine#45734) 2023-09-12 1961493 [email protected] Revert "Use a single OffscreenCanvas for rendering in CanvasKit" (flutter/engine#45744) 2023-09-12 [email protected] [Impeller] Patch the compiler to account for subpass inputs and PSO metadata. (flutter/engine#45739) 2023-09-12 [email protected] [Impeller] Fix swapchain recreation for non-polling cases. (flutter/engine#45740) 2023-09-12 [email protected] Roll Fuchsia Mac SDK from QgAHx3BtJfN3TmodS... to UCa49z8fu0hD9cypj... (flutter/engine#45738) 2023-09-12 [email protected] [ios] upload extension safe artifacts (flutter/engine#45664) 2023-09-12 30870216 [email protected] Added test to assert the vulkan embedder threadsafe vkqueue usage (flutter/engine#45732) 2023-09-12 [email protected] [Impeller] If validations are enabled but not found, still create the VK context. (flutter/engine#45674) 2023-09-12 [email protected] Roll Skia from 211d63b1e1f5 to 2d295711337c (7 revisions) (flutter/engine#45729) 2023-09-12 1961493 [email protected] Use a single OffscreenCanvas for rendering in CanvasKit (flutter/engine#42672) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from QgAHx3BtJfN3 to UCa49z8fu0hD If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/ doc/main/autoroll/README.md
flutter#45747) …" (flutter#45734) Reverts flutter#45211 b/298583505
…abled… (#45756) …… (#45747) …" (#45734) Reverts #45211 b/298583505 preemptively cp the revert to the next roll i am looking at. I do see the recipe branch show up on https://flutter-review.googlesource.com/admin/repos/recipes,branches/q/filter:flutter-3.15 , I will assume the recipe branch is created for now. We will see the post submit results. If it doesn't work I will create the recipe branch manually. Co-authored-by: Zachary Anderson <[email protected]>
…caching is enabled… (#45811) …" (#45734) Reverts #45211 b/298583505 Co-authored-by: Zachary Anderson <[email protected]>
…lutter#134597) flutter/engine@c90fadf...7c78ea2 2023-09-12 [email protected] Revert "Lazily allocate RasterCacheItems only when caching is enabled" (flutter/engine#45734) 2023-09-12 1961493 [email protected] Revert "Use a single OffscreenCanvas for rendering in CanvasKit" (flutter/engine#45744) 2023-09-12 [email protected] [Impeller] Patch the compiler to account for subpass inputs and PSO metadata. (flutter/engine#45739) 2023-09-12 [email protected] [Impeller] Fix swapchain recreation for non-polling cases. (flutter/engine#45740) 2023-09-12 [email protected] Roll Fuchsia Mac SDK from QgAHx3BtJfN3TmodS... to UCa49z8fu0hD9cypj... (flutter/engine#45738) 2023-09-12 [email protected] [ios] upload extension safe artifacts (flutter/engine#45664) 2023-09-12 30870216 [email protected] Added test to assert the vulkan embedder threadsafe vkqueue usage (flutter/engine#45732) 2023-09-12 [email protected] [Impeller] If validations are enabled but not found, still create the VK context. (flutter/engine#45674) 2023-09-12 [email protected] Roll Skia from 211d63b1e1f5 to 2d295711337c (7 revisions) (flutter/engine#45729) 2023-09-12 1961493 [email protected] Use a single OffscreenCanvas for rendering in CanvasKit (flutter/engine#42672) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from QgAHx3BtJfN3 to UCa49z8fu0hD If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/ doc/main/autoroll/README.md
Reverts #45211
b/298583505