[Impeller] Context VK can create vulkan surface from Android Native Window #37214
Conversation
This is going to be used for creating a surface from Android native window.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
iskakaushik
changed the title
| return vk::UniqueSurfaceKHR{VK_NULL_HANDLE}; | ||
| } | ||
|
|
||
| auto create_info = vk::AndroidSurfaceCreateInfoKHR().setWindow(window); |
There was a problem hiding this comment.
Don't you need to hold a reference to the ANativeWindow? Something like ANativeWindow_acquire and _release
There was a problem hiding this comment.
In my planned usage: AndroidNativeWindow is going to be held by AndroidSurfaceVulkanImpeller <- is a WIP PR.
iskakaushik
added
the
autosubmit
This is going to be used for creating a surface from Android native window.